From: Naohiro Tamura via Libc-alpha <libc-alpha@sourceware.org>
To: libc-alpha@sourceware.org
Subject: [PATCH] config: Remove HAVE_BUILTIN_MEMSET macro
Date: Mon, 26 Jul 2021 08:34:33 +0000 [thread overview]
Message-ID: <20210726083433.385572-1-naohirot@fujitsu.com> (raw)
In-Reply-To: <20210713082214.307529-1-naohirot@fujitsu.com>
s patch removed HAVE_BUILTIN_MEMSET macro because GCC 6.2 that is
minimum requirement to compile glibc already support
__builtin_memset()[1].
Interestingly, removed code had a critical bug that is
HAVE_BUILTIN_MEMSET macro never be defined, because yes/no assignment
to libc_cv_gcc_builtin_memset was reversed in configure.ac as below:
1519 if AC_TRY_COMMAND([${CC-cc} -O3 -S conftest.c -o - | grep -F "memset" > /dev/null]);
1520 then
1521 libc_cv_gcc_builtin_memset=no # shold be yes
1522 else
1523 libc_cv_gcc_builtin_memset=yes # should be no
1524 fi
1525 rm -f conftest* ])
1526 if test "$libc_cv_gcc_builtin_memset" = yes ; then
1527 AC_DEFINE(HAVE_BUILTIN_MEMSET)
1528 fi
Therefor __builtin_memset() in elf/rtld.c was never be compiled.
534 # ifdef HAVE_BUILTIN_MEMSET
535 __builtin_memset (bootstrap_map.l_info, '\0', sizeof (bootstrap_map.l_info));
536 # else
[1] https://gcc.gnu.org/onlinedocs/gcc-6.2.0/gcc/Other-Builtins.html
---
config.h.in | 3 ---
configure | 31 -------------------------------
configure.ac | 19 -------------------
elf/rtld.c | 15 ++++-----------
4 files changed, 4 insertions(+), 64 deletions(-)
diff --git a/config.h.in b/config.h.in
index 8b45a3a61d77..4647632f2632 100644
--- a/config.h.in
+++ b/config.h.in
@@ -40,9 +40,6 @@
shared between GNU libc and GNU gettext projects. */
#define HAVE_BUILTIN_EXPECT 1
-/* Define if the compiler supports __builtin_memset. */
-#undef HAVE_BUILTIN_MEMSET
-
/* Define if compiler accepts -ftree-loop-distribute-patterns. */
#undef HAVE_CC_INHIBIT_LOOP_TO_LIBCALL
diff --git a/configure b/configure
index 9619c10991d0..6f85d28ea085 100755
--- a/configure
+++ b/configure
@@ -6261,37 +6261,6 @@ if test $libc_cv_have_section_quotes = yes; then
fi
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for __builtin_memset" >&5
-$as_echo_n "checking for __builtin_memset... " >&6; }
-if ${libc_cv_gcc_builtin_memset+:} false; then :
- $as_echo_n "(cached) " >&6
-else
- cat > conftest.c <<\EOF
-void zero (void *x)
-{
- __builtin_memset (x, 0, 1000);
-}
-EOF
-if { ac_try='${CC-cc} -O3 -S conftest.c -o - | grep -F "memset" > /dev/null'
- { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
- (eval $ac_try) 2>&5
- ac_status=$?
- $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
- test $ac_status = 0; }; };
-then
- libc_cv_gcc_builtin_memset=no
-else
- libc_cv_gcc_builtin_memset=yes
-fi
-rm -f conftest*
-fi
-{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_gcc_builtin_memset" >&5
-$as_echo "$libc_cv_gcc_builtin_memset" >&6; }
-if test "$libc_cv_gcc_builtin_memset" = yes ; then
- $as_echo "#define HAVE_BUILTIN_MEMSET 1" >>confdefs.h
-
-fi
-
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for redirection of built-in functions" >&5
$as_echo_n "checking for redirection of built-in functions... " >&6; }
if ${libc_cv_gcc_builtin_redirection+:} false; then :
diff --git a/configure.ac b/configure.ac
index 34ecbba54054..0c5ee6623c4c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1508,25 +1508,6 @@ if test $libc_cv_have_section_quotes = yes; then
AC_DEFINE(HAVE_SECTION_QUOTES)
fi
-AC_CACHE_CHECK(for __builtin_memset, libc_cv_gcc_builtin_memset, [dnl
-cat > conftest.c <<\EOF
-void zero (void *x)
-{
- __builtin_memset (x, 0, 1000);
-}
-EOF
-dnl
-if AC_TRY_COMMAND([${CC-cc} -O3 -S conftest.c -o - | grep -F "memset" > /dev/null]);
-then
- libc_cv_gcc_builtin_memset=no
-else
- libc_cv_gcc_builtin_memset=yes
-fi
-rm -f conftest* ])
-if test "$libc_cv_gcc_builtin_memset" = yes ; then
- AC_DEFINE(HAVE_BUILTIN_MEMSET)
-fi
-
AC_CACHE_CHECK(for redirection of built-in functions, libc_cv_gcc_builtin_redirection, [dnl
cat > conftest.c <<\EOF
extern char *strstr (const char *, const char *) __asm ("my_strstr");
diff --git a/elf/rtld.c b/elf/rtld.c
index d733359eaf80..d0da99bd6d78 100644
--- a/elf/rtld.c
+++ b/elf/rtld.c
@@ -526,19 +526,12 @@ _dl_start (void *arg)
/* Partly clean the `bootstrap_map' structure up. Don't use
`memset' since it might not be built in or inlined and we cannot
- make function calls at this point. Use '__builtin_memset' if we
- know it is available. We do not have to clear the memory if we
- do not have to use the temporary bootstrap_map. Global variables
- are initialized to zero by default. */
+ make function calls at this point. Use '__builtin_memset' instead.
+ We do not have to clear the memory if we do not have to use the
+ temporary bootstrap_map. Global variables are initialized to zero
+ by default. */
#ifndef DONT_USE_BOOTSTRAP_MAP
-# ifdef HAVE_BUILTIN_MEMSET
__builtin_memset (bootstrap_map.l_info, '\0', sizeof (bootstrap_map.l_info));
-# else
- for (size_t cnt = 0;
- cnt < sizeof (bootstrap_map.l_info) / sizeof (bootstrap_map.l_info[0]);
- ++cnt)
- bootstrap_map.l_info[cnt] = 0;
-# endif
#endif
/* Figure out the run-time load address of the dynamic linker itself. */
--
2.17.1
next prev parent reply other threads:[~2021-07-26 8:35 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 8:22 [PATCH] benchtests: Add memset zero fill benchmark tests Naohiro Tamura via Libc-alpha
2021-07-13 13:50 ` Lucas A. M. Magalhaes via Libc-alpha
2021-07-20 6:31 ` [PATCH v2 0/5] " Naohiro Tamura via Libc-alpha
2021-08-05 7:47 ` [PATCH v3 0/5] benchtests: Add memset zero fill benchmark test Naohiro Tamura via Libc-alpha
2021-08-05 7:49 ` [PATCH v3 1/5] benchtests: Enable scripts/plot_strings.py to read stdin Naohiro Tamura via Libc-alpha
2021-08-05 7:56 ` Siddhesh Poyarekar
2021-09-08 1:46 ` naohirot--- via Libc-alpha
2021-09-08 12:56 ` Siddhesh Poyarekar
2021-09-09 0:22 ` naohirot--- via Libc-alpha
2021-09-13 3:45 ` Siddhesh Poyarekar
2021-08-05 7:50 ` [PATCH v3 2/5] benchtests: Add memset zero fill benchtest Naohiro Tamura via Libc-alpha
2021-09-08 2:03 ` naohirot--- via Libc-alpha
2021-09-10 20:40 ` Lucas A. M. Magalhaes via Libc-alpha
2021-09-13 0:53 ` naohirot--- via Libc-alpha
2021-09-13 14:05 ` Lucas A. M. Magalhaes via Libc-alpha
2021-09-14 0:38 ` [PATCH v4] " Naohiro Tamura via Libc-alpha
2021-09-14 0:44 ` [PATCH v3 2/5] " naohirot--- via Libc-alpha
2021-09-14 14:02 ` Wilco Dijkstra via Libc-alpha
2021-09-15 8:24 ` naohirot--- via Libc-alpha
2021-09-21 1:27 ` naohirot--- via Libc-alpha
2021-09-21 11:09 ` Wilco Dijkstra via Libc-alpha
2021-09-22 1:05 ` [PATCH v5] " Naohiro Tamura via Libc-alpha
2023-02-09 17:23 ` Carlos O'Donell via Libc-alpha
2023-02-10 1:26 ` Siddhesh Poyarekar via Libc-alpha
2021-09-22 1:07 ` [PATCH v3 2/5] " naohirot--- via Libc-alpha
2021-09-28 1:40 ` naohirot--- via Libc-alpha
2021-09-30 0:55 ` Tamura, Naohiro/田村 直� via Libc-alpha
2021-10-18 12:57 ` Lucas A. M. Magalhaes via Libc-alpha
2021-10-20 13:44 ` Wilco Dijkstra via Libc-alpha
2021-10-20 15:35 ` Lucas A. M. Magalhaes via Libc-alpha
2021-10-20 17:47 ` Wilco Dijkstra via Libc-alpha
2021-10-22 13:08 ` Lucas A. M. Magalhaes via Libc-alpha
2021-08-05 7:51 ` [PATCH v3 3/5] benchtests: Remove redundant assert.h Naohiro Tamura via Libc-alpha
2021-09-08 1:59 ` naohirot--- via Libc-alpha
2021-09-13 3:36 ` Siddhesh Poyarekar
2021-08-05 7:51 ` [PATCH v3 4/5] benchtests: Fix validate_benchout.py exceptions Naohiro Tamura via Libc-alpha
2021-09-08 1:55 ` naohirot--- via Libc-alpha
2021-09-13 3:42 ` Siddhesh Poyarekar
2021-09-13 3:50 ` Siddhesh Poyarekar
2021-09-13 13:44 ` [PATCH v4] " Naohiro Tamura via Libc-alpha
2021-09-15 3:23 ` Siddhesh Poyarekar
2021-09-16 1:12 ` naohirot--- via Libc-alpha
2021-09-16 1:41 ` Siddhesh Poyarekar
2021-09-16 2:23 ` [PATCH v5] " Naohiro Tamura via Libc-alpha
2021-09-16 3:48 ` Siddhesh Poyarekar
2021-09-16 5:23 ` naohirot--- via Libc-alpha
2021-09-16 2:26 ` [PATCH v4] " naohirot--- via Libc-alpha
2021-09-13 13:46 ` [PATCH v3 4/5] " naohirot--- via Libc-alpha
2021-08-05 7:52 ` [PATCH v3 5/5] config: Rename HAVE_BUILTIN_MEMSET macro Naohiro Tamura via Libc-alpha
2021-08-11 20:34 ` Adhemerval Zanella via Libc-alpha
2021-07-20 6:34 ` [PATCH v2 1/5] benchtests: Enable scripts/plot_strings.py to read stdin Naohiro Tamura via Libc-alpha
2021-07-20 6:35 ` [PATCH v2 2/5] benchtests: Add memset zero fill benchtest Naohiro Tamura via Libc-alpha
2021-07-20 16:48 ` Noah Goldstein via Libc-alpha
2021-07-21 12:56 ` naohirot--- via Libc-alpha
2021-07-21 13:07 ` naohirot--- via Libc-alpha
2021-07-21 18:14 ` Noah Goldstein via Libc-alpha
2021-07-21 19:17 ` Wilco Dijkstra via Libc-alpha
2021-07-26 8:42 ` naohirot--- via Libc-alpha
2021-07-26 11:15 ` Wilco Dijkstra via Libc-alpha
2021-07-27 2:24 ` naohirot--- via Libc-alpha
2021-07-27 17:26 ` Wilco Dijkstra via Libc-alpha
2021-07-28 7:27 ` naohirot--- via Libc-alpha
2021-08-04 9:11 ` naohirot--- via Libc-alpha
2021-07-26 8:39 ` naohirot--- via Libc-alpha
2021-07-26 17:22 ` Noah Goldstein via Libc-alpha
2021-07-20 6:35 ` [PATCH v2 3/5] benchtests: Add a script to convert benchout string JSON to CSV Naohiro Tamura via Libc-alpha
2021-07-21 2:41 ` naohirot--- via Libc-alpha
2021-07-27 20:17 ` Joseph Myers
2021-07-29 1:56 ` naohirot--- via Libc-alpha
2021-07-29 4:42 ` Siddhesh Poyarekar
2021-07-30 7:05 ` naohirot--- via Libc-alpha
2021-07-31 10:47 ` Siddhesh Poyarekar
2021-07-20 6:36 ` [PATCH v2 4/5] benchtests: Remove redundant assert.h Naohiro Tamura via Libc-alpha
2021-07-20 6:37 ` [PATCH v2 5/5] benchtests: Fix validate_benchout.py exceptions Naohiro Tamura via Libc-alpha
2021-07-26 8:34 ` Naohiro Tamura via Libc-alpha [this message]
2021-07-26 8:48 ` [PATCH] config: Remove HAVE_BUILTIN_MEMSET macro naohirot--- via Libc-alpha
2021-07-26 8:49 ` Andreas Schwab
2021-07-26 9:42 ` naohirot--- via Libc-alpha
2021-07-26 9:51 ` Andreas Schwab
2021-07-26 13:16 ` naohirot--- via Libc-alpha
2021-07-26 8:35 ` [PATCH] benchtests: Add a script to merge two benchout string files Naohiro Tamura via Libc-alpha
2021-07-27 20:51 ` Joseph Myers
2021-07-30 7:04 ` naohirot--- via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726083433.385572-1-naohirot@fujitsu.com \
--to=libc-alpha@sourceware.org \
--cc=naohirot@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).