From: Samuel Thibault via Libc-alpha <libc-alpha@sourceware.org>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: libc-alpha@sourceware.org
Subject: Re: tst-interpose-static-thread-{m,malloc-}check linking statically?
Date: Fri, 23 Jul 2021 09:45:48 +0200 [thread overview]
Message-ID: <20210723074548.35dd5wag7co5jden@begin> (raw)
In-Reply-To: <17363f16-77d7-ec99-606e-667ff3c4c410@gotplt.org>
Siddhesh Poyarekar, le ven. 23 juil. 2021 06:58:01 +0530, a ecrit:
> On 7/23/21 12:06 AM, Samuel Thibault wrote:
> > Siddhesh Poyarekar, le jeu. 22 juil. 2021 02:48:06 +0530, a ecrit:
> > > On 22-Jul-2021 00:34, Samuel Thibault via Libc-alpha
> > > <libc-alpha@sourceware.org> wrote:
> > >
> > > > tl;dr: I believe we want the patch below? AIUI the
> > > > tst-interpose-static-{no,}thread-{m,malloc-}check tests are supposed to
> > > > be linked completely statically?
> > >
> > > Those tests ought to be removed when malloc hooks get dropped since mcheck and
> > > malloc-check won't work with static libraries.
> >
> > So this? Or just excluding tst-interpose-static-thread?
>
> Excluding all static tets, like this:
>
> https://patchwork.sourceware.org/project/glibc/patch/20210722140115.2911835-1-siddhesh@sourceware.org/
>
> Could you please see if the above patch fixes it for you?
Yes, that fixes it!
Samuel
next prev parent reply other threads:[~2021-07-23 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 19:04 tst-interpose-static-thread-{m,malloc-}check linking statically? Samuel Thibault via Libc-alpha
[not found] ` <41e663cf-208d-4d9d-a8eb-351163d6e168@email.android.com>
2021-07-22 2:09 ` Siddhesh Poyarekar
2021-07-22 18:36 ` Samuel Thibault via Libc-alpha
2021-07-23 1:28 ` Siddhesh Poyarekar
2021-07-23 7:45 ` Samuel Thibault via Libc-alpha [this message]
2021-07-23 11:18 ` Siddhesh Poyarekar
2021-07-22 14:01 ` [PATCH] Exclude static tests for mcheck and malloc-check Siddhesh Poyarekar via Libc-alpha
2021-07-24 14:52 ` Samuel Thibault via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723074548.35dd5wag7co5jden@begin \
--to=libc-alpha@sourceware.org \
--cc=samuel.thibault@gnu.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).