From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RDNS_DYNAMIC, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 56F3B1F5AE for ; Thu, 22 Jul 2021 18:36:39 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 88C5E3853802 for ; Thu, 22 Jul 2021 18:36:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 88C5E3853802 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626978998; bh=sTmICzvJ3IllOKrfPMrrFQ+mspEMlruzRLKlKVvpkcw=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mto62jPyR49jkoF/1iXB1eN08VU0+fk/c+mDX7u1OgJqU9/n4EVgGTxRuF2S4xMQB QCapto8oKn3zjvhcMrhTKrh5+6FHxJoZ8jmCFKjgPacysWIYfFrh8wW6pt6UQe9ndX T/e+x4gxnLge/Yjs7mwivNui7wWVP0pVlP/qOpTs= Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by sourceware.org (Postfix) with ESMTPS id 62680398A4BC for ; Thu, 22 Jul 2021 18:36:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 62680398A4BC Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7161842B; Thu, 22 Jul 2021 20:36:05 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MHq_MatJfolG; Thu, 22 Jul 2021 20:36:04 +0200 (CEST) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 717A9164; Thu, 22 Jul 2021 20:36:04 +0200 (CEST) Received: from samy by begin with local (Exim 4.94.2) (envelope-from ) id 1m6dYB-00HWqz-Ek; Thu, 22 Jul 2021 20:36:03 +0200 Date: Thu, 22 Jul 2021 20:36:03 +0200 To: Siddhesh Poyarekar Subject: Re: tst-interpose-static-thread-{m,malloc-}check linking statically? Message-ID: <20210722183603.oyhlseeauavd2toa@begin> References: <20210721190428.dfnqd4lpqdpohy2a@begin> <41e663cf-208d-4d9d-a8eb-351163d6e168@email.android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41e663cf-208d-4d9d-a8eb-351163d6e168@email.android.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: - X-Rspamd-Server: hera X-Rspamd-Queue-Id: 7161842B X-Spamd-Result: default: False [-1.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; SUBJECT_ENDS_QUESTION(1.00)[]; BAYES_HAM(-3.00)[100.00%] X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Samuel Thibault via Libc-alpha Reply-To: Samuel Thibault Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Siddhesh Poyarekar, le jeu. 22 juil. 2021 02:48:06 +0530, a ecrit: > On 22-Jul-2021 00:34, Samuel Thibault via Libc-alpha > wrote: > > > tl;dr: I believe we want the patch below? AIUI the > > tst-interpose-static-{no,}thread-{m,malloc-}check tests are supposed to > > be linked completely statically? > > Those tests ought to be removed when malloc hooks get dropped since mcheck and > malloc-check won't work with static libraries. So this? Or just excluding tst-interpose-static-thread? diff --git a/malloc/Makefile b/malloc/Makefile index d54285192a..0980e2901b 100644 --- a/malloc/Makefile +++ b/malloc/Makefile @@ -72,7 +72,8 @@ test-srcs = tst-mtrace # with MALLOC_CHECK_=3 because they expect a specific failure. tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \ tst-mxfast tst-safe-linking \ - tst-compathooks-off tst-compathooks-on + tst-compathooks-off tst-compathooks-on \ + tst-interpose-static-nothread tst-interpose-static-thread # Run all tests with MALLOC_CHECK_=3 tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests)) @@ -92,7 +93,8 @@ tests-exclude-mcheck = tst-mallocstate \ tst-malloc-thread-fail \ tst-malloc-usable-tunables \ tst-malloc_info \ - tst-compathooks-off tst-compathooks-on + tst-compathooks-off tst-compathooks-on \ + tst-interpose-static-nothread tst-interpose-static-thread tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests)) endif