From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id CEEAE1F5AE for ; Tue, 20 Jul 2021 10:25:46 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4F042398B8AE for ; Tue, 20 Jul 2021 10:25:45 +0000 (GMT) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by sourceware.org (Postfix) with ESMTPS id 9FFDA384F02E for ; Tue, 20 Jul 2021 10:25:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FFDA384F02E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=denx.de Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id AC03D82039; Tue, 20 Jul 2021 12:25:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626776730; bh=edr4FjuSzcWXQ6RmzEPh7ibWen6TEyose6Ptds5zF2I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QPrLev5FCNqOPNAOKrCABJxRke2guDSfig0x+o8D+vp3vQaq9PRcmQoG/SZAjmZ0c m8Gi2cCVtHKCJmE5NO112WFpmZSb2Fm2r7TJ7Ac8K/rRK4K6DZk6MwBLS9N+ZBC1kE dsjeD66gXO+/ov4Fntfp+WK28i0/6oSshYyVPhDgd5SgJQpLmCiDFfyd1AQUEfcRhA b1VHK3nNAG86Rr4nO9a137CdsAa4mUqmM7fE0+kv/DzWHpPFPuIriZYn/BFwqJMp8e 4cWagV50mYl38CTw4hIfuZyeFAqZYe0CgG9CDVMY3XC1UPF5LSQ4CP/T84GC7dwBX7 FvLdgI7IwvPXg== Date: Tue, 20 Jul 2021 12:25:24 +0200 From: Lukasz Majewski To: Florian Weimer Subject: Re: [PATCH 7/8] socket: Add time64 alias for getsockopt Message-ID: <20210720122524.01e9fc5a@ktm> In-Reply-To: <87y2a1s5ss.fsf@oldenburg.str.redhat.com> References: <539b2c5d20735487ae6c1276f42679dc4ff38ae0.1625492203.git.fweimer@redhat.com> <20210720111059.40b6a49d@ktm> <87y2a1s5ss.fsf@oldenburg.str.redhat.com> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/to0YBPk7yik8YYT=.Rke+Un"; protocol="application/pgp-signature" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer via Libc-alpha Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" --Sig_/to0YBPk7yik8YYT=.Rke+Un Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 20 Jul 2021 11:17:23 +0200 Florian Weimer wrote: > * Lukasz Majewski: >=20 > >> diff --git a/socket/sys/socket.h b/socket/sys/socket.h > >> index e779dc837f..b37c87e7df 100644 > >> --- a/socket/sys/socket.h > >> +++ b/socket/sys/socket.h > >> @@ -251,9 +251,24 @@ extern int __REDIRECT (recvmmsg, (int __fd, > >> struct mmsghdr *__vmessages, /* Put the current value for socket > >> FD's option OPTNAME at protocol level LEVEL into OPTVAL (which is > >> *OPTLEN bytes long), and set *OPTLEN to the value's actual length. > >> Returns 0 on success, -1 for errors. */ +#ifndef > >> __USE_TIME_BITS64 extern int getsockopt (int __fd, int __level, > >> int __optname, void *__restrict __optval, > >> socklen_t *__restrict __optlen) __THROW; > >> +#else =20 > > > > [*] > > =20 > >> +# ifdef __REDIRECT > >> +extern int __REDIRECT_NTH (getsockopt, > >> + (int __fd, int __level, int __optname, > >> + void *__restrict __optval, > >> + socklen_t *__restrict __optlen), > >> + __getsockopt64); > >> +# else > >> +extern int __getsockopt64 (int __fd, int __level, int __optname, > >> + void *__restrict __optval, > >> + socklen_t *__restrict __optlen) > >> __THROW; =20 > > > > Shouldn't the __getsockopt64() declaration be placed at [*]. =20 >=20 > I think __REDIRECT_NTH does not need a declaration for the redirection > target. >=20 Ok. > Thanks, > Florian >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/to0YBPk7yik8YYT=.Rke+Un Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmD2pJQACgkQAR8vZIA0 zr0RcQf+N+ma2Y0unw66Yaaoea415vHK9RQa9Y5bl+WsZHUwOW+G7iCot1fukBcr 08a7c2w3FVMHVNh396VXoGVCrFsrXf7N81VCFKWT2gID9MJVf3NfIuc0p3hqRD5l stdCg0mdEG393XMFdb4pl91RiA29PTMR5TlGxG8OiD2APLWOKQURsHr1QXl1WJGv MNxQHeUphrk1h7heBSEVaC52rBHC65wjdNzw83m2j5dKVTZfdMlpOUUrmzQDR56z qqSvQEvBGROrGkmfbJ0UeJdwlGaRLq08q7CYaQ4OXiQWX/pWgkDnyQmWRX+B4RWI x13c+F0xcTIndl2Io1X61HmV6qnjNg== =vYXr -----END PGP SIGNATURE----- --Sig_/to0YBPk7yik8YYT=.Rke+Un--