From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E77DA1F5AE for ; Mon, 19 Jul 2021 10:08:58 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 333393889C01 for ; Mon, 19 Jul 2021 10:08:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 333393889C01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626689338; bh=fSWgQV6OzozNK01LQvlc74c+1U3J7m43CZdqGg8h4mU=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WG0Ht4QUjYKA2FuRqiOK1/xrE0RdhOSf31mXybN0fzafcuVY8z2j6JHiSRrMuBdY5 J2eyRS8cU1LE8BtKgK4rkD4EV8lEgHoUn41zsIUQpm0R++31sP5M4Y/dG66KTuRLVd Rm1OFC0CPacDWIN43vQqQcFLx2j6lYt4smkiRfsQ= Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 9F9693943406 for ; Mon, 19 Jul 2021 10:06:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9F9693943406 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F42E6D; Mon, 19 Jul 2021 03:06:44 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E0803F73D; Mon, 19 Jul 2021 03:06:43 -0700 (PDT) Date: Mon, 19 Jul 2021 11:05:26 +0100 To: Mark Brown Subject: Re: [PATCH v4 4/4] elf: Remove has_interp property from arch_parse_elf_property() Message-ID: <20210719100526.GW4187@arm.com> References: <20210712115259.29547-1-broonie@kernel.org> <20210712115259.29547-5-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712115259.29547-5-broonie@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Dave Martin via Libc-alpha Reply-To: Dave Martin Cc: linux-arch@vger.kernel.org, Yu-cheng Yu , libc-alpha@sourceware.org, Szabolcs Nagy , Catalin Marinas , Jeremy Linton , Will Deacon , linux-arm-kernel@lists.infradead.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Mon, Jul 12, 2021 at 12:52:59PM +0100, Mark Brown wrote: > Since all current users of arch_parse_elf_property() are able to treat the > interpreter and main executable orthogonaly the has_interp argument is now > redundant so remove it. Reviewed-by: Dave Martin > > Signed-off-by: Mark Brown > Tested-by: Jeremy Linton > --- > arch/arm64/include/asm/elf.h | 2 +- > fs/binfmt_elf.c | 2 +- > include/linux/elf.h | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h > index 9f86dbce2680..a6e9032b951a 100644 > --- a/arch/arm64/include/asm/elf.h > +++ b/arch/arm64/include/asm/elf.h > @@ -262,7 +262,7 @@ struct arch_elf_state { > > static inline int arch_parse_elf_property(u32 type, const void *data, > size_t datasz, bool compat, > - bool has_interp, bool is_interp, > + bool is_interp, > struct arch_elf_state *arch) > { > /* No known properties for AArch32 yet */ > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index ae8094d42480..f0b3c24215f6 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -753,7 +753,7 @@ static int parse_elf_property(const char *data, size_t *off, size_t datasz, > > ret = arch_parse_elf_property(pr->pr_type, data + o, > pr->pr_datasz, ELF_COMPAT, > - has_interp, is_interp, arch); > + is_interp, arch); > if (ret) > return ret; > > diff --git a/include/linux/elf.h b/include/linux/elf.h > index d8392531899d..cdb080d4b34a 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -88,14 +88,14 @@ struct arch_elf_state; > #ifndef CONFIG_ARCH_USE_GNU_PROPERTY > static inline int arch_parse_elf_property(u32 type, const void *data, > size_t datasz, bool compat, > - bool has_interp, bool is_interp, > + bool is_interp, > struct arch_elf_state *arch) > { > return 0; > } > #else > extern int arch_parse_elf_property(u32 type, const void *data, size_t datasz, > - bool compat, bool has_interp, bool is_interp, > + bool compat, bool is_interp, > struct arch_elf_state *arch); > #endif > > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel