* [PATCH] elf: Add -Wl, --no-as-needed for tst-tls-manydynamic*mod-dep-bad.so (BZ #28089)
@ 2021-07-15 11:22 Adhemerval Zanella via Libc-alpha
2021-07-15 11:59 ` [PATCH] elf: Add -Wl,--no-as-needed " Adhemerval Zanella via Libc-alpha
0 siblings, 1 reply; 2+ messages in thread
From: Adhemerval Zanella via Libc-alpha @ 2021-07-15 11:22 UTC (permalink / raw
To: libc-alpha
The tests explicit requires the dependencies and it is required for
the case the toolchain defaults to -Wl,--as-needed.
Checked on x86_64-linux-gnu.
---
elf/Makefile | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/elf/Makefile b/elf/Makefile
index bdd5cc9e1a..4fe60947ad 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -1854,25 +1854,36 @@ $(objpfx)tst-tls-manydynamic16mod-dep.so: $(objpfx)tst-tls-manydynamic18mod-dep.
# Same but with an invalid module.
# Single dependency.
$(objpfx)tst-tls-manydynamic0mod-dep-bad.so: $(objpfx)tst-tls20mod-bad.so
+LDFLAGS-tst-tls-manydynamic0mod-dep-bad.so = -Wl,--no-as-needed
# Double dependencies.
$(objpfx)tst-tls-manydynamic1mod-dep-bad.so: $(objpfx)tst-tls-manydynamic2mod-dep-bad.so \
$(objpfx)tst-tls20mod-bad.so
+LDFLAGS-tst-tls-manydynamic1mod-dep-bad.so = -Wl,--no-as-needed
# Double dependencies with each dependency depent of another module.
$(objpfx)tst-tls-manydynamic3mod-dep-bad.so: $(objpfx)tst-tls-manydynamic4mod-dep-bad.so \
$(objpfx)tst-tls-manydynamic5mod-dep-bad.so
+LDFLAGS-tst-tls-manydynamic3mod-dep-bad.so = -Wl,--no-as-needed
$(objpfx)tst-tls-manydynamic4mod-dep-bad.so: $(objpfx)tst-tls20mod-bad.so
+LDFLAGS-tst-tls-manydynamic4mod-dep-bad.so = -Wl,--no-as-needed
$(objpfx)tst-tls-manydynamic5mod-dep-bad.so: $(objpfx)tst-tls20mod-bad.so
+LDFLAGS-tst-tls-manydynamic5mod-dep-bad.so = -Wl,--no-as-needed
# Long chain with one double dependency in the middle
$(objpfx)tst-tls-manydynamic6mod-dep-bad.so: $(objpfx)tst-tls-manydynamic7mod-dep-bad.so \
$(objpfx)tst-tls-manydynamic8mod-dep-bad.so
+LDFLAGS-tst-tls-manydynamic6mod-dep-bad.so = -Wl,--no-as-needed
$(objpfx)tst-tls-manydynamic7mod-dep-bad.so: $(objpfx)tst-tls-manydynamic9mod-dep-bad.so
+LDFLAGS-tst-tls-manydynamic7mod-dep-bad.so = -Wl,--no-as-needed
$(objpfx)tst-tls-manydynamic9mod-dep-bad.so: $(objpfx)tst-tls20mod-bad.so
+LDFLAGS-tst-tls-manydynamic9mod-dep-bad.so = -Wl,--no-as-needed
# Long chain with two double depedencies in the middle
$(objpfx)tst-tls-manydynamic10mod-dep-bad.so: $(objpfx)tst-tls-manydynamic11mod-dep-bad.so
+LDFLAGS-tst-tls-manydynamic10mod-dep-bad.so = -Wl,--no-as-needed
$(objpfx)tst-tls-manydynamic11mod-dep-bad.so: $(objpfx)tst-tls-manydynamic12mod-dep-bad.so \
$(objpfx)tst-tls-manydynamic13mod-dep-bad.so
+LDFLAGS-tst-tls-manydynamic11mod-dep-bad.so = -Wl,--no-as-needed
$(objpfx)tst-tls-manydynamic12mod-dep-bad.so: $(objpfx)tst-tls-manydynamic14mod-dep-bad.so \
$(objpfx)tst-tls20mod-bad.so
+LDFLAGS-tst-tls-manydynamic12mod-dep-bad.so = -Wl,--no-as-needed
$(objpfx)tst-tls20: $(shared-thread-library)
$(objpfx)tst-tls20.out: $(objpfx)tst-tls20mod-bad.so \
$(tst-tls-many-dynamic-modules:%=$(objpfx)%.so) \
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] elf: Add -Wl,--no-as-needed for tst-tls-manydynamic*mod-dep-bad.so (BZ #28089)
2021-07-15 11:22 [PATCH] elf: Add -Wl, --no-as-needed for tst-tls-manydynamic*mod-dep-bad.so (BZ #28089) Adhemerval Zanella via Libc-alpha
@ 2021-07-15 11:59 ` Adhemerval Zanella via Libc-alpha
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella via Libc-alpha @ 2021-07-15 11:59 UTC (permalink / raw
To: libc-alpha
On 15/07/2021 08:22, Adhemerval Zanella wrote:
> The tests explicit requires the dependencies and it is required for
> the case the toolchain defaults to -Wl,--as-needed.
>
> Checked on x86_64-linux-gnu.
The subject should be 'COMMITTED', since it is a straightforward patch
and I already pushed upstream.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-15 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-15 11:22 [PATCH] elf: Add -Wl, --no-as-needed for tst-tls-manydynamic*mod-dep-bad.so (BZ #28089) Adhemerval Zanella via Libc-alpha
2021-07-15 11:59 ` [PATCH] elf: Add -Wl,--no-as-needed " Adhemerval Zanella via Libc-alpha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).