From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A648D1F8C6 for ; Tue, 13 Jul 2021 07:40:13 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 024CD3945C0D for ; Tue, 13 Jul 2021 07:40:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 024CD3945C0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626162009; bh=SN26LroHqO7oMbuFq1ib68ZY1a6gAsms4aAJVyVbSlU=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RzzI9nK5J7ULlemwrQD2bs+1moFMp2CVDEEeO41Gm+dikw9Co1G3g8eUSZQsAANhy WnHf5xHLPb491GiOjrBd++nKuQ3eBOvHoLnBBeeXyD+gjbu9T1AVEU6TrwVKMtphrS 4jSKG2a+U1x2BDemRrd2Bbut5ojbrshgdr5AJZKk= Received: from butterfly.birch.relay.mailchannels.net (butterfly.birch.relay.mailchannels.net [23.83.209.27]) by sourceware.org (Postfix) with ESMTPS id ACE493896833 for ; Tue, 13 Jul 2021 07:39:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACE493896833 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6E1EC341E66; Tue, 13 Jul 2021 07:39:04 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-17-89.trex-nlb.outbound.svc.cluster.local [100.96.17.89]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id EAF71341DA0; Tue, 13 Jul 2021 07:39:03 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a18.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.17.89 (trex/6.3.3); Tue, 13 Jul 2021 07:39:04 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Hysterical-Wiry: 4a25de9318888c4f_1626161944240_1547251226 X-MC-Loop-Signature: 1626161944240:3977795281 X-MC-Ingress-Time: 1626161944240 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id 9B0EA87DC6; Tue, 13 Jul 2021 00:39:03 -0700 (PDT) Received: from rhbox.intra.reserved-bit.com (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 4A79285B78; Tue, 13 Jul 2021 00:39:00 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a18 To: libc-alpha@sourceware.org Subject: [PATCH v8 01/10] Make mcheck tests conditional on GLIBC_2.24 or earlier Date: Tue, 13 Jul 2021 13:08:36 +0530 Message-Id: <20210713073845.504356-2-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210713073845.504356-1-siddhesh@sourceware.org> References: <20210713073845.504356-1-siddhesh@sourceware.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Siddhesh Poyarekar via Libc-alpha Reply-To: Siddhesh Poyarekar Cc: fweimer@redhat.com Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Targets with base versions later than 2.24 won't have __malloc_initialize_hook because of which the tests will essentially be the same as the regular malloc tests. Avoid running them instead and save time. --- malloc/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/malloc/Makefile b/malloc/Makefile index 47369b6084..d15729569b 100644 --- a/malloc/Makefile +++ b/malloc/Makefile @@ -78,6 +78,8 @@ tests-exclude-malloc-check =3D tst-malloc-check tst-mal= loc-usable \ # Run all tests with MALLOC_CHECK_=3D3 tests-malloc-check =3D $(filter-out $(tests-exclude-malloc-check),$(test= s)) =20 +# -lmcheck needs __malloc_initialize_hook, which was deprecated in 2.24. +ifeq ($(have-GLIBC_2.24)$(build-shared),yesyes) # Tests that don't play well with mcheck. They are either bugs in mchec= k or # the tests expect specific internal behavior that is changed due to lin= king to # libmcheck.a. @@ -100,6 +102,7 @@ tests-exclude-mcheck =3D tst-mallocstate \ tst-reallocarray =20 tests-mcheck =3D $(filter-out $(tests-exclude-mcheck), $(tests)) +endif =20 routines =3D malloc morecore mcheck mtrace obstack reallocarray \ scratch_buffer_dupfree \ --=20 2.31.1