unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Raoni Fassina Firmino via Libc-alpha <libc-alpha@sourceware.org>
To: Raphael M Zinsly <rzinsly@linux.ibm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc64le: Optimize memset for POWER10
Date: Thu, 29 Apr 2021 15:39:56 -0300	[thread overview]
Message-ID: <20210429183956.d6fxgb3ztmhisq3x@work-tp> (raw)
In-Reply-To: <4eb56953-1cda-7c79-1fc3-c8b7057284c6@linux.ibm.com>


Thanks for the review Raphael.

> > diff --git a/sysdeps/powerpc/powerpc64/le/power10/memset.S b/sysdeps/powerpc/powerpc64/le/power10/memset.S
> > new file mode 100644
> > index 000000000000..c8b77fc64596
> > --- /dev/null
> > +++ b/sysdeps/powerpc/powerpc64/le/power10/memset.S
> > @@ -0,0 +1,251 @@
> > +/* Optimized memset implementation for PowerPC64/POWER10.
> 
> Could be just POWER10.

Done. kind of.

I had missed that now there is a reference in the same folder :D. Used
"POWER10 LE.", hope that is ok.


> > diff --git a/sysdeps/powerpc/powerpc64/multiarch/memset-power10.S b/sysdeps/powerpc/powerpc64/multiarch/memset-power10.S
> > new file mode 100644
> > index 000000000000..53a9535a2401
> > --- /dev/null
> > +++ b/sysdeps/powerpc/powerpc64/multiarch/memset-power10.S
> > @@ -0,0 +1,27 @@
> > +/* Optimized memset implementation for PowerPC64/POWER10.

Also changed here.


o/
Raoni

  reply	other threads:[~2021-04-29 18:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 14:40 [PATCH] powerpc64le: Optimize memset for POWER10 Raoni Fassina Firmino via Libc-alpha
2021-04-28 18:48 ` Lucas A. M. Magalhaes via Libc-alpha
2021-04-29 18:40   ` Raoni Fassina Firmino via Libc-alpha
2021-04-28 20:28 ` Raphael M Zinsly via Libc-alpha
2021-04-29 18:39   ` Raoni Fassina Firmino via Libc-alpha [this message]
2021-04-28 20:49 ` Matheus Castanho via Libc-alpha
2021-04-29 21:40   ` Raoni Fassina Firmino via Libc-alpha
  -- strict thread matches above, loose matches on Subject: below --
2021-04-29 23:41 Raoni Fassina Firmino via Libc-alpha
2021-04-29 23:49 ` Raoni Fassina Firmino via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210429183956.d6fxgb3ztmhisq3x@work-tp \
    --to=libc-alpha@sourceware.org \
    --cc=raoni@linux.ibm.com \
    --cc=rzinsly@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).