From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AF30E1F4B4 for ; Thu, 22 Oct 2020 09:25:45 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A7F12386F42C; Thu, 22 Oct 2020 09:25:44 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 541443844047 for ; Thu, 22 Oct 2020 09:25:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 541443844047 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4CH25x2SZ8z1rxMC; Thu, 22 Oct 2020 11:25:41 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4CH25x1cvFz1qvgZ; Thu, 22 Oct 2020 11:25:41 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id NSSrWZvkVaL2; Thu, 22 Oct 2020 11:25:39 +0200 (CEST) X-Auth-Info: YzmOqxjFEIlMyOyy/TuCB42+Dlh9OU6riOEQX2wPuSM= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 22 Oct 2020 11:25:39 +0200 (CEST) Date: Thu, 22 Oct 2020 11:25:09 +0200 From: Lukasz Majewski To: Adhemerval Zanella Subject: Re: [PATCH 4/5] login: User 64-bit time on struct lastlog Message-ID: <20201022112509.1fe28427@jawa> In-Reply-To: <20200729205117.2925113-4-adhemerval.zanella@linaro.org> References: <20200729205117.2925113-1-adhemerval.zanella@linaro.org> <20200729205117.2925113-4-adhemerval.zanella@linaro.org> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/A7fRKvB0cDbS/_vqg9VaYEK"; protocol="application/pgp-signature" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --Sig_/A7fRKvB0cDbS/_vqg9VaYEK Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adhemerval, > It is not used directly on any symbol, so there is no need to add > compat ones. > --- > bits/struct_lastlog.h | 4 +-- > .../sysv/linux/s390/bits/struct_lastlog.h | 35 > ------------------- 2 files changed, 2 insertions(+), 37 deletions(-) > delete mode 100644 sysdeps/unix/sysv/linux/s390/bits/struct_lastlog.h >=20 > diff --git a/bits/struct_lastlog.h b/bits/struct_lastlog.h > index 122a44abd0..6882015d7c 100644 > --- a/bits/struct_lastlog.h > +++ b/bits/struct_lastlog.h > @@ -24,8 +24,8 @@ > previous logins. */ > struct lastlog > { > -#if __WORDSIZE_TIME64_COMPAT32 > - int32_t ll_time; > +#if __TIMESIZE !=3D 64 > + int64_t ll_time; Maybe __time64_t would fit better here? > #else > __time_t ll_time; > #endif Reviewed-by: Lukasz Majewski > diff --git a/sysdeps/unix/sysv/linux/s390/bits/struct_lastlog.h > b/sysdeps/unix/sysv/linux/s390/bits/struct_lastlog.h deleted file > mode 100644 index 2fa409aeec..0000000000 > --- a/sysdeps/unix/sysv/linux/s390/bits/struct_lastlog.h > +++ /dev/null > @@ -1,35 +0,0 @@ > -/* The 'struct lastlog' type. > - Copyright (C) 2020 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be > useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, see > - . */ > - > -#ifndef _UTMP_H > -# error "Never include directly; use > instead." -#endif > - > -/* The structure describing an entry in the database of > - previous logins. */ > -struct lastlog > - { > -#if __WORDSIZE =3D=3D 32 > - int64_t ll_time; > -#else > - __time_t ll_time; > -#endif > - char ll_line[UT_LINESIZE]; > - char ll_host[UT_HOSTSIZE]; > - }; > - Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/A7fRKvB0cDbS/_vqg9VaYEK Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl+RT/UACgkQAR8vZIA0 zr1W/AgApR7TR1r/jMgfj9VRvGAQUvi9EmJ1NkfSfhzRaz2/n7YrSapdDeVVVjgL Mpl0/FJ3tprp/VtMojQCSJ4K8mNHsZ/8nlFj8sRKXDi/bakMukk07HotoRN/URSK BpWsCi48vSqrwe4P5dG8PbhjCYC1q6IqVLvXB13J9f2qaMDdEJIBHxw+9A3gRTKx lalBnGian4rERBOkhBqH2VLPDU448B3exIs8ELhwHlHRWJZhGqVL++eadAxjqok1 JtB6n4gCW8h1gM21EQRWVGEji8T21Bu5BRQEMEznGAu6a+hPlOv7tLjkcS2NcAzP +H7YVCXKdFKdN4LkVz+teO4bn3+rrA== =THkc -----END PGP SIGNATURE----- --Sig_/A7fRKvB0cDbS/_vqg9VaYEK--