From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 373A51F4B4 for ; Tue, 13 Oct 2020 13:59:14 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 29DFA3894403; Tue, 13 Oct 2020 13:59:13 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 7787B3851C15 for ; Tue, 13 Oct 2020 13:59:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7787B3851C15 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C9cbd3kTnz1qs42; Tue, 13 Oct 2020 15:59:09 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C9cbd3K33z1sM9W; Tue, 13 Oct 2020 15:59:09 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id kFdeNrb_Hsfp; Tue, 13 Oct 2020 15:59:08 +0200 (CEST) X-Auth-Info: oQAn/O6LoyIp+sYGAE9ftxzbKOJgzhLLEzDLsygl13I= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 13 Oct 2020 15:59:08 +0200 (CEST) Date: Tue, 13 Oct 2020 15:58:38 +0200 From: Lukasz Majewski To: Adhemerval Zanella Subject: Re: [PATCH 15/16] linux: Add {f}stat{at} y2038 support Message-ID: <20201013155838.0e61252b@jawa> In-Reply-To: <331ab260-ef82-8e94-7148-5522fdb6e195@linaro.org> References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-16-adhemerval.zanella@linaro.org> <20201006114802.1450d29b@jawa> <99a35800-d0ed-5561-b36b-4416f041ab5d@linaro.org> <331ab260-ef82-8e94-7148-5522fdb6e195@linaro.org> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/AEZinX7xrG1+wrtXIbNMVrc"; protocol="application/pgp-signature" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --Sig_/AEZinX7xrG1+wrtXIbNMVrc Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adhemerval, > On 07/10/2020 09:52, Adhemerval Zanella wrote: > >=20 > >=20 > > On 06/10/2020 06:48, Lukasz Majewski wrote: =20 > >> Hi Adhemerval, > >> =20 > >>> A new struct __stat{64}_t64 type is added with the required > >>> __timespec64 time definition. Both non-LFS and LFS support were > >>> done with an extra __NR_statx call plus a conversion to the new > >>> __stat{64}_t64 type. The statx call is done only for > >>> architectures with support for 32-bit time_t ABI. > >>> > >>> Internally some extra routines to copy from/to struct stat{64} > >>> to struct __stat{64} used on multiple implementations (stat, > >>> fstat, lstat, and fstatat) are added on a extra file > >>> (stat_t64_cp.c). Aslo some extra routines to copy from statx to > >>> __stat{64} is added on statx_cp.c. > >>> > >>> Checked with a build for all affected ABIs. I also checked on > >>> x86_64, i686, powerpc, powerpc64le, sparcv9, sparc64, s390, and > >>> s390x. =20 > >> > >> When do you plan to pull this patch set to -master? > >> Those patches have been available for review on the mailing list > >> for more than two months now. =20 > >=20 > > Hi Lukasz, thanks to remind me. I will rebase against master and run > > some regressions tests against some platforms and push it. > > =20 >=20 > One required change with the rebase is adapt the riscv32 ABI to > exclude the __{f,l}xstat{at} symbol and replace with proper {f,l}stat > ones. It is possible because the new ABI was added on current > development branch, however one minor inconvenient is the toolchain > need to be rebuild with a updated glibc branch to avoid linking > failures with libstd++ (which uses __{f,l}xstat{at}). >=20 I'm not sure if this is related, but on my ARMv7 (32 bit) sandbox there is an issue with fstat accesses to files. When I try to run a program build against newest glibc (installed in /opt/lib) I do see issues with {f}stat on other libraries (e.g. /opt/lib/librt.so). To be more specific I do experience the EOVERFLOW error: error while loading shared libraries: librt.so.1: cannot stat shared object: Error 75 The "base" glibc is 2.28 (installed in /lib). The glibc under test is the newest master installed in /opt/lib. I'm now investigating this issue. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/AEZinX7xrG1+wrtXIbNMVrc Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl+Fso4ACgkQAR8vZIA0 zr1v8Af/SW9YNwf+g63yJLF+oJk9lSUNHjxat4kpJzRW6hIegBSuoBy1R8yFKEmn iMxaks1hBUltjtTvNHCMZ0Xl4mCU+cKcSvVhXzrErUx5Ejx+Oh6CK6x7zhbbHaqE G1Zxh5zEK5D2k7NAeoReBGuo8RM3Ou76gHSOG3UBfKCvPwLlOCKklj2hfX/abdbu qVLmwAXEk8Uahv8MDbkG33fT0L+fU82xqS0pZigau1Dpm08aVyaTrnLq82g9Uocm 9JFVR8KG9koH2LhcpCvb9jkvghSaHqVrX1fR48puTZvO/4yBXVkVuhAM6dyAtbV/ 1zAcZvSMQB0qgVS6h9x2cPaunumIAA== =nEt+ -----END PGP SIGNATURE----- --Sig_/AEZinX7xrG1+wrtXIbNMVrc--