From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0C7441F4B4 for ; Fri, 9 Oct 2020 15:40:58 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C185385780E; Fri, 9 Oct 2020 15:40:56 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 1D01B3857C55 for ; Fri, 9 Oct 2020 15:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1D01B3857C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C7C2q5qCFz1sBRH; Fri, 9 Oct 2020 17:40:51 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C7C2q5DMnz1sM9h; Fri, 9 Oct 2020 17:40:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 6TM_2RhfV5Qk; Fri, 9 Oct 2020 17:40:36 +0200 (CEST) X-Auth-Info: Ep1T/DR2xXJENP84Xx1Gk3WtukWX/519YEJPlcmWvtw= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 9 Oct 2020 17:40:36 +0200 (CEST) Date: Fri, 9 Oct 2020 17:39:47 +0200 From: Lukasz Majewski To: Adhemerval Zanella Subject: Re: [PATCH 15/16] linux: Add {f}stat{at} y2038 support Message-ID: <20201009173947.101164c1@jawa> In-Reply-To: <6c95d492-4ca2-bec8-eb25-1095d190d462@linaro.org> References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-16-adhemerval.zanella@linaro.org> <20201006114802.1450d29b@jawa> <99a35800-d0ed-5561-b36b-4416f041ab5d@linaro.org> <331ab260-ef82-8e94-7148-5522fdb6e195@linaro.org> <04ea13cc-5d00-fb13-9ff6-68645620d5b0@linaro.org> <20201008095748.1d3d7226@jawa> <6c95d492-4ca2-bec8-eb25-1095d190d462@linaro.org> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/nLC+.OoCID6D.yxIWgEm=cu"; protocol="application/pgp-signature" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --Sig_/nLC+.OoCID6D.yxIWgEm=cu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adhemerval, > On 08/10/2020 04:57, Lukasz Majewski wrote: > > Hi Adhemerval, > > =20 > >> On 07/10/2020 11:25, Adhemerval Zanella wrote: =20 > >>> > >>> > >>> On 07/10/2020 09:52, Adhemerval Zanella wrote: =20 > >>>> > >>>> > >>>> On 06/10/2020 06:48, Lukasz Majewski wrote: =20 > >>>>> Hi Adhemerval, > >>>>> =20 > >>>>>> A new struct __stat{64}_t64 type is added with the required > >>>>>> __timespec64 time definition. Both non-LFS and LFS support > >>>>>> were done with an extra __NR_statx call plus a conversion to > >>>>>> the new __stat{64}_t64 type. The statx call is done only for > >>>>>> architectures with support for 32-bit time_t ABI. > >>>>>> > >>>>>> Internally some extra routines to copy from/to struct stat{64} > >>>>>> to struct __stat{64} used on multiple implementations (stat, > >>>>>> fstat, lstat, and fstatat) are added on a extra file > >>>>>> (stat_t64_cp.c). Aslo some extra routines to copy from statx > >>>>>> to __stat{64} is added on statx_cp.c. > >>>>>> > >>>>>> Checked with a build for all affected ABIs. I also checked on > >>>>>> x86_64, i686, powerpc, powerpc64le, sparcv9, sparc64, s390, and > >>>>>> s390x. =20 > >>>>> > >>>>> When do you plan to pull this patch set to -master? > >>>>> Those patches have been available for review on the mailing list > >>>>> for more than two months now. =20 > >>>> > >>>> Hi Lukasz, thanks to remind me. I will rebase against master and > >>>> run some regressions tests against some platforms and push it. > >>>> =20 > >>> > >>> One required change with the rebase is adapt the riscv32 ABI to > >>> exclude the __{f,l}xstat{at} symbol and replace with proper > >>> {f,l}stat ones. It is possible because the new ABI was added on > >>> current development branch, however one minor inconvenient is the > >>> toolchain need to be rebuild with a updated glibc branch to avoid > >>> linking failures with libstd++ (which uses __{f,l}xstat{at}). > >>> =20 > >> > >> Ok, I have ran the testsuite on x86_64, x32, i686, aarch64, armhf, > >> powerpc, powerpc64, powerpc64le, sparc64, sparcv9, s390x, and s390 > >> without regression. I will just finish the testing on mips, mips64, > >> and alpha since they require some specific implementations. > >> =20 > >=20 > > That would be a huge step forward. > >=20 > > According to list in the following commit message: > > https://github.com/lmajewski/y2038_glibc/commit/73215359e184d96b415e87b= 585a4396b5bd0936c > > =20 >=20 > The mips testing caught an issue on where the "linux: Disentangle=20 > fstatat from fxstatat" patch uses INTERNAL_SYSCALL_CALL where > it should use INLINE_SYSCALL_CALL (which sets the errno). I have > fixed and this only affects mips, so my testing should cover all > the affects architectures (I got access to a ia64 machine again > and I will run a regression test once I commit this to master). Ok. Does it mean that we can expect those patches being pull to -master soon? >=20 > >=20 > > Then I will send an RFC for enabling support for 64 bit time on > > eligible architectures. =20 >=20 > There still some missing implementations I have on my local tree: >=20 > 1. wait3: it is a straightforward fix since it just calls > __wait4_time64.=20 Ok. >2. ftime: we need to move it to a compatibility > symbol, so there will be no need to add a time64 variant to support > the deprecated symbol. IIRC, such deprecation patch for ftime was already pulled to master: SHA1: 2b5fea833bcd0f651579afd16ed7842770ecbae1 "Consolidate and deprecate ftime" =46rom the commit description - it shall be removed by Y2038 :-) > 3. futimesat: we need to remove the > implementation on generic folder and handle UTIME_NOW and UTIME_OMIT > correctly. Ok. > 4. recvvmsg/recvmsg: we need to handle ancillary data. I > recently send patch that tries to handle it [1] [2] [3]. It is more > in a RFC and I don't think it is strictly necessary. Ok. > 5. utmp/utmpx/lastlog: I also sent a fix to handle the 64-bit support > on this [4] I saw conversion patches in your y2038 tree (sourceware/azanella/y2038) on top of the stat conversion work, so I guess that it will be next in the queue. >=20 > I will send 1. 2. 3., since they are the easiest one to review. Ok. Thanks :-) >=20 > [1] > https://sourceware.org/pipermail/libc-alpha/2020-September/117484.html > [2] > https://sourceware.org/pipermail/libc-alpha/2020-September/117485.html > [3] > https://sourceware.org/pipermail/libc-alpha/2020-September/117486.html > [4] > https://sourceware.org/pipermail/libc-alpha/2020-August/116850.html >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/nLC+.OoCID6D.yxIWgEm=cu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl+AhEMACgkQAR8vZIA0 zr26aAf+PSzrPNPYpexizg1J+rjiCwJMe9FzpLyVwPerbzkTt/f58/zwD3IfyPH9 PEdR2cNBR3VO8lTCrItThahpNWuGKrc/wfZnQKjwlEmLiva9QXzn0uw8oZ4jt7sp hgmvuYtoOp+p2bXRifwzQ/+xheoTcC0NvnSC4GAyxHrmXmZT5xYrN4AAFR/mWgob AP3E8VaXGdVRmb/ozAdJ9Xzg3Ui708W10XqGFBYbnpvYnmG8rDGZNguARzrnYV9M m7r7qzh9FxZApjkoXMu8JgDUL2DzamPx7Np0VqhCSXM9+gbuPG5ijx5BUAq44m/d oyRtq7o7L5kIW5hj+ICra+zW5oNKuw== =xvDi -----END PGP SIGNATURE----- --Sig_/nLC+.OoCID6D.yxIWgEm=cu--