From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4EA6F1F4B4 for ; Thu, 8 Oct 2020 07:58:14 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C7E23850411; Thu, 8 Oct 2020 07:58:13 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 009933857C6F for ; Thu, 8 Oct 2020 07:58:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 009933857C6F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C6NqM4w4Cz1qt4D; Thu, 8 Oct 2020 09:58:07 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C6NqM3wChz1r577; Thu, 8 Oct 2020 09:58:07 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id KlhU07y_WOKY; Thu, 8 Oct 2020 09:58:05 +0200 (CEST) X-Auth-Info: BGgwZhdhctbJURxZsqryHMCbussBm39cgmHYfnbhfxI= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 8 Oct 2020 09:58:05 +0200 (CEST) Date: Thu, 8 Oct 2020 09:57:48 +0200 From: Lukasz Majewski To: Adhemerval Zanella Subject: Re: [PATCH 15/16] linux: Add {f}stat{at} y2038 support Message-ID: <20201008095748.1d3d7226@jawa> In-Reply-To: <04ea13cc-5d00-fb13-9ff6-68645620d5b0@linaro.org> References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-16-adhemerval.zanella@linaro.org> <20201006114802.1450d29b@jawa> <99a35800-d0ed-5561-b36b-4416f041ab5d@linaro.org> <331ab260-ef82-8e94-7148-5522fdb6e195@linaro.org> <04ea13cc-5d00-fb13-9ff6-68645620d5b0@linaro.org> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/MZCg15vF3VGXAaaQQbjDXEr"; protocol="application/pgp-signature" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --Sig_/MZCg15vF3VGXAaaQQbjDXEr Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adhemerval, > On 07/10/2020 11:25, Adhemerval Zanella wrote: > >=20 > >=20 > > On 07/10/2020 09:52, Adhemerval Zanella wrote: =20 > >> > >> > >> On 06/10/2020 06:48, Lukasz Majewski wrote: =20 > >>> Hi Adhemerval, > >>> =20 > >>>> A new struct __stat{64}_t64 type is added with the required > >>>> __timespec64 time definition. Both non-LFS and LFS support were > >>>> done with an extra __NR_statx call plus a conversion to the new > >>>> __stat{64}_t64 type. The statx call is done only for > >>>> architectures with support for 32-bit time_t ABI. > >>>> > >>>> Internally some extra routines to copy from/to struct stat{64} > >>>> to struct __stat{64} used on multiple implementations (stat, > >>>> fstat, lstat, and fstatat) are added on a extra file > >>>> (stat_t64_cp.c). Aslo some extra routines to copy from statx to > >>>> __stat{64} is added on statx_cp.c. > >>>> > >>>> Checked with a build for all affected ABIs. I also checked on > >>>> x86_64, i686, powerpc, powerpc64le, sparcv9, sparc64, s390, and > >>>> s390x. =20 > >>> > >>> When do you plan to pull this patch set to -master? > >>> Those patches have been available for review on the mailing list > >>> for more than two months now. =20 > >> > >> Hi Lukasz, thanks to remind me. I will rebase against master and > >> run some regressions tests against some platforms and push it. > >> =20 > >=20 > > One required change with the rebase is adapt the riscv32 ABI to > > exclude the __{f,l}xstat{at} symbol and replace with proper > > {f,l}stat ones. It is possible because the new ABI was added on > > current development branch, however one minor inconvenient is the > > toolchain need to be rebuild with a updated glibc branch to avoid > > linking failures with libstd++ (which uses __{f,l}xstat{at}). > > =20 >=20 > Ok, I have ran the testsuite on x86_64, x32, i686, aarch64, armhf, > powerpc, powerpc64, powerpc64le, sparc64, sparcv9, s390x, and s390 > without regression. I will just finish the testing on mips, mips64, > and alpha since they require some specific implementations. >=20 That would be a huge step forward. According to list in the following commit message: https://github.com/lmajewski/y2038_glibc/commit/73215359e184d96b415e87b585a= 4396b5bd0936c Then I will send an RFC for enabling support for 64 bit time on eligible architectures. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/MZCg15vF3VGXAaaQQbjDXEr Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl9+xnwACgkQAR8vZIA0 zr2OVwf/RaFUUEj4UYWh8iMatq37bEFB0Lvc1BRMJC8oKWZF353PslC0M1I33hIb +mAFL3Un/aE4hM0oEY96Xc6V3sWGGJN3pyxGRarNGrlBQvt5WRi3erq4eRgxqUsK VyiloCPgsDGoeZ0tsuYopLzT+vKW+1eqWcfWidpyNymF6UHwgdX8FQ0z/YUbcXUr II81E9VKLO1hA7b7jHSc0DIYLJblHCwRa5FLq3FVl6u2jpqTjgEqU79gHwVCODKa u8ToKO3jEYVZinrk/PSpPslAOQ4C28ICqiTIQDgnGLSHupAb8D9J5KZjVoe3iPgl sNVSQsbyTLLbrRV0tkQiWTQmVlUOtQ== =O4ZX -----END PGP SIGNATURE----- --Sig_/MZCg15vF3VGXAaaQQbjDXEr--