From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 262FD1F5AE for ; Fri, 24 Jul 2020 08:20:34 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 66EAD3857C42; Fri, 24 Jul 2020 08:20:33 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 17BDC3857C42 for ; Fri, 24 Jul 2020 08:20:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 17BDC3857C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4BChvw2L2Wz1rwDW; Fri, 24 Jul 2020 10:20:12 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4BChvw1y5Qz1qy6B; Fri, 24 Jul 2020 10:20:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ecWwfXWZxyQX; Fri, 24 Jul 2020 10:20:10 +0200 (CEST) X-Auth-Info: rWqtJTPxgyvV1QKnqCRk7GGCgfbjnQrxs9hJxVecAxM= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 24 Jul 2020 10:20:10 +0200 (CEST) Date: Fri, 24 Jul 2020 10:20:09 +0200 From: Lukasz Majewski To: Adhemerval Zanella Subject: Re: [PATCH 02/16] linux: Define STAT64_IS_KERNEL_STAT64 Message-ID: <20200724102009.59f03bd9@jawa> In-Reply-To: <20200723194641.1949404-3-adhemerval.zanella@linaro.org> References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-3-adhemerval.zanella@linaro.org> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/UzqOX0bxg7cClb=l8C5gdZz"; protocol="application/pgp-signature" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --Sig_/UzqOX0bxg7cClb=l8C5gdZz Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 23 Jul 2020 16:46:27 -0300 Adhemerval Zanella wrote: > It indicates that the glibc export stat64 is similar in size and > layout of the kernel stat64 used on the syscall. It is not currently > used on stat implementation, but the idea is to indicate whether > to use the kernel_stat to issue on the syscall on the *stat*64 > variant (more specifically on mips which its exported ABI does not > match the kernel). Reviewed-by: Lukasz Majewski > --- > sysdeps/unix/sysv/linux/alpha/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/arc/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/hppa/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/ia64/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/microblaze/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/mips/kernel_stat.h | 6 ++++++ > sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h | 6 ++++++ > sysdeps/unix/sysv/linux/x86_64/kernel_stat.h | 1 + > 13 files changed, 23 insertions(+) >=20 > diff --git a/sysdeps/unix/sysv/linux/alpha/kernel_stat.h > b/sysdeps/unix/sysv/linux/alpha/kernel_stat.h index > 9bcc96c577..ff69045f8f 100644 --- > a/sysdeps/unix/sysv/linux/alpha/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/alpha/kernel_stat.h @@ -86,5 +86,6 @@ > struct glibc21_stat }; > =20 > #define STAT_IS_KERNEL_STAT 0 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 1 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/arc/kernel_stat.h > b/sysdeps/unix/sysv/linux/arc/kernel_stat.h index > 8fdd86b9e8..fd9b113f45 100644 --- > a/sysdeps/unix/sysv/linux/arc/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/arc/kernel_stat.h @@ -19,6 +19,7 @@ > =20 > /* Needed to elide the itemized copy code in common xstatconv.c. */ > #define STAT_IS_KERNEL_STAT 1 > +#define STAT64_IS_KERNEL_STAT64 1 > =20 > /* Nice side-effect of 64-bit time_t switch is these are same. */ > #define XSTAT_IS_XSTAT64 1 > diff --git a/sysdeps/unix/sysv/linux/hppa/kernel_stat.h > b/sysdeps/unix/sysv/linux/hppa/kernel_stat.h index > 0cbd010fc3..e8ad135e70 100644 --- > a/sysdeps/unix/sysv/linux/hppa/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/hppa/kernel_stat.h @@ -31,5 +31,6 @@ struct > kernel_stat { #define _HAVE_STAT64_NSEC > =20 > #define STAT_IS_KERNEL_STAT 0 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/ia64/kernel_stat.h > b/sysdeps/unix/sysv/linux/ia64/kernel_stat.h index > b38bf741d3..c96a0589dc 100644 --- > a/sysdeps/unix/sysv/linux/ia64/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/ia64/kernel_stat.h @@ -17,5 +17,6 @@ > . */ > =20 > #define STAT_IS_KERNEL_STAT 1 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 1 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/kernel_stat.h > b/sysdeps/unix/sysv/linux/kernel_stat.h index ff54a4524c..b1bc1459f0 > 100644 --- a/sysdeps/unix/sysv/linux/kernel_stat.h > +++ b/sysdeps/unix/sysv/linux/kernel_stat.h > @@ -35,5 +35,6 @@ struct kernel_stat > #define _HAVE_STAT64_NSEC > =20 > #define STAT_IS_KERNEL_STAT 0 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/microblaze/kernel_stat.h > b/sysdeps/unix/sysv/linux/microblaze/kernel_stat.h index > 4daaedc4b6..9ab1e50115 100644 --- > a/sysdeps/unix/sysv/linux/microblaze/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/microblaze/kernel_stat.h @@ -49,5 +49,6 @@ > struct kernel_stat }; > =20 > #define STAT_IS_KERNEL_STAT 0 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/mips/kernel_stat.h > b/sysdeps/unix/sysv/linux/mips/kernel_stat.h index > e75f3e805b..21dba2de73 100644 --- > a/sysdeps/unix/sysv/linux/mips/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/mips/kernel_stat.h @@ -1,3 +1,6 @@ > +#ifndef _KERNEL_STAT_H > +#define _KERNEL_STAT_H > + > #include > /* As tempting as it is to define XSTAT_IS_XSTAT64 for n64, the > userland data structures are not identical, because of different > @@ -57,5 +60,8 @@ struct kernel_stat > #endif > =20 > #define STAT_IS_KERNEL_STAT 0 > +#define STAT64_IS_KERNEL_STAT64 0 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > + > +#endif > diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h > b/sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h index > 75610b8df3..5757e65f8e 100644 --- > a/sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h @@ -48,5 > +48,6 @@ struct kernel_stat #define _HAVE_STAT64_NSEC > =20 > #define STAT_IS_KERNEL_STAT 0 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h > b/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h index > 5c10da3356..9f11b69e4f 100644 --- > a/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h @@ -17,5 > +17,6 @@ . */ > =20 > #define STAT_IS_KERNEL_STAT 1 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 1 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h > b/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h index > b38bf741d3..c96a0589dc 100644 --- > a/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h @@ -17,5 +17,6 @@ > . */ > =20 > #define STAT_IS_KERNEL_STAT 1 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 1 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h > b/sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h index > 5c8cacaf67..4a2df42d37 100644 --- > a/sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h @@ -32,5 +32,6 > @@ struct kernel_stat #define _HAVE_STAT64_NSEC > =20 > #define STAT_IS_KERNEL_STAT 0 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h > b/sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h index > d14b2487ac..0f3d405239 100644 --- > a/sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h @@ -1,3 +1,6 @@ > +#ifndef _KERNEL_STAT_H > +#define _KERNEL_STAT_H > + > /* Definition of `struct stat' used in the kernel */ > struct kernel_stat > { > @@ -45,5 +48,8 @@ struct kernel_stat64 > }; > =20 > #define STAT_IS_KERNEL_STAT 0 > +#define STAT64_IS_KERNEL_STAT64 0 > #define XSTAT_IS_XSTAT64 1 > #define STATFS_IS_STATFS64 0 > + > +#endif /* _KERNEL_STAT_H */ > diff --git a/sysdeps/unix/sysv/linux/x86_64/kernel_stat.h > b/sysdeps/unix/sysv/linux/x86_64/kernel_stat.h index > b38bf741d3..c96a0589dc 100644 --- > a/sysdeps/unix/sysv/linux/x86_64/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/x86_64/kernel_stat.h @@ -17,5 +17,6 @@ > . */ > =20 > #define STAT_IS_KERNEL_STAT 1 > +#define STAT64_IS_KERNEL_STAT64 1 > #define XSTAT_IS_XSTAT64 1 > #define STATFS_IS_STATFS64 0 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/UzqOX0bxg7cClb=l8C5gdZz Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl8ambkACgkQAR8vZIA0 zr06UAgA2iDTKcNpbacG7LhMsHL1haalFe9y5ZafmDwCkCcbWccVHxQCgJaEN9j4 4blrzRuHVdShA/Y53w9HUNh3pAERhMkIHGybIeS5B/IaiP/m/iwwB2joRCGEAW7A t6isPTgOSiNv2pCCoLZhwYLi06NCOg3uFrtWHQGy3jxdLbSKlUCVtXPAMEmY3A2o aY8y5RvCiZwdxIGIk2hS1vS3R3X1+6PRd0XK1LYn944MOuVxaiWsvXBRSblSyQXh RSFw/3goEbuBSUACjF+pZ4FqtVpEOuQ71v2L8MtFKXaJSAv8gqi3yHuga+RCqlps zs1qOw8/j5RJpo3/xsVYL1VXdGwGcw== =CuTB -----END PGP SIGNATURE----- --Sig_/UzqOX0bxg7cClb=l8C5gdZz--