From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,UNWANTED_LANGUAGE_BODY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 338C71F5AE for ; Fri, 24 Jul 2020 08:17:40 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F25A5388CC27; Fri, 24 Jul 2020 08:17:38 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id AD63F3857C42 for ; Fri, 24 Jul 2020 08:17:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AD63F3857C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4BChrt30Ppz1rwZq; Fri, 24 Jul 2020 10:17:34 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4BChrt2SDYz1qy6B; Fri, 24 Jul 2020 10:17:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 49C20PPghe4F; Fri, 24 Jul 2020 10:17:32 +0200 (CEST) X-Auth-Info: Bi9CVLTlOeylTRNRXyHecmDeiM/6567UzHpB2TDE/OQ= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 24 Jul 2020 10:17:32 +0200 (CEST) Date: Fri, 24 Jul 2020 10:17:25 +0200 From: Lukasz Majewski To: Adhemerval Zanella Subject: Re: [PATCH 01/16] linux: Always define STAT_IS_KERNEL_STAT Message-ID: <20200724101725.2519f7ed@jawa> In-Reply-To: <20200723194641.1949404-2-adhemerval.zanella@linaro.org> References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-2-adhemerval.zanella@linaro.org> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/ArI/LVr0RYTBvcEolZ2oupR"; protocol="application/pgp-signature" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --Sig_/ArI/LVr0RYTBvcEolZ2oupR Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adhemerval, > It allows to check for its value instead of its existence. >=20 > Checked with a build for all affected ABIS. Reviewed-by: Lukasz Majewski > --- > sysdeps/unix/sysv/linux/alpha/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/fxstat.c | 2 +- > sysdeps/unix/sysv/linux/fxstatat.c | 4 ++-- > sysdeps/unix/sysv/linux/hppa/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/lxstat.c | 2 +- > sysdeps/unix/sysv/linux/microblaze/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/mips/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h | 1 + > sysdeps/unix/sysv/linux/xstat.c | 2 +- > sysdeps/unix/sysv/linux/xstatconv.c | 2 +- > sysdeps/unix/sysv/linux/xstatconv.h | 2 +- > 14 files changed, 15 insertions(+), 7 deletions(-) >=20 > diff --git a/sysdeps/unix/sysv/linux/alpha/kernel_stat.h > b/sysdeps/unix/sysv/linux/alpha/kernel_stat.h index > d637e099cf..9bcc96c577 100644 --- > a/sysdeps/unix/sysv/linux/alpha/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/alpha/kernel_stat.h @@ -85,5 +85,6 @@ > struct glibc21_stat long __glibc_reserved[4]; > }; > =20 > +#define STAT_IS_KERNEL_STAT 0 > #define XSTAT_IS_XSTAT64 1 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/fxstat.c > b/sysdeps/unix/sysv/linux/fxstat.c index ce474dcd47..a88404b5c3 100644 > --- a/sysdeps/unix/sysv/linux/fxstat.c > +++ b/sysdeps/unix/sysv/linux/fxstat.c > @@ -38,7 +38,7 @@ __fxstat (int vers, int fd, struct stat *buf) > if (vers =3D=3D _STAT_VER_KERNEL) > return INLINE_SYSCALL (fstat, 2, fd, buf); > =20 > -#ifdef STAT_IS_KERNEL_STAT > +#if STAT_IS_KERNEL_STAT > return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL); > #else > struct kernel_stat kbuf; > diff --git a/sysdeps/unix/sysv/linux/fxstatat.c > b/sysdeps/unix/sysv/linux/fxstatat.c index 3eb898e322..937fec45c2 > 100644 --- a/sysdeps/unix/sysv/linux/fxstatat.c > +++ b/sysdeps/unix/sysv/linux/fxstatat.c > @@ -37,7 +37,7 @@ int > __fxstatat (int vers, int fd, const char *file, struct stat *st, int > flag) { > int result; > -#ifdef STAT_IS_KERNEL_STAT > +#if STAT_IS_KERNEL_STAT > # define kst (*st) > #else > struct kernel_stat kst; > @@ -46,7 +46,7 @@ __fxstatat (int vers, int fd, const char *file, > struct stat *st, int flag) result =3D INTERNAL_SYSCALL_CALL > (newfstatat, fd, file, &kst, flag); if (!__glibc_likely > (INTERNAL_SYSCALL_ERROR_P (result))) { > -#ifdef STAT_IS_KERNEL_STAT > +#if STAT_IS_KERNEL_STAT > return 0; > #else > return __xstat_conv (vers, &kst, st); > diff --git a/sysdeps/unix/sysv/linux/hppa/kernel_stat.h > b/sysdeps/unix/sysv/linux/hppa/kernel_stat.h index > a3ac53a1ef..0cbd010fc3 100644 --- > a/sysdeps/unix/sysv/linux/hppa/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/hppa/kernel_stat.h @@ -30,5 +30,6 @@ struct > kernel_stat { #define _HAVE_STAT_NSEC > #define _HAVE_STAT64_NSEC > =20 > +#define STAT_IS_KERNEL_STAT 0 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/kernel_stat.h > b/sysdeps/unix/sysv/linux/kernel_stat.h index eecc962de3..ff54a4524c > 100644 --- a/sysdeps/unix/sysv/linux/kernel_stat.h > +++ b/sysdeps/unix/sysv/linux/kernel_stat.h > @@ -34,5 +34,6 @@ struct kernel_stat > #define _HAVE_STAT64___ST_INO > #define _HAVE_STAT64_NSEC > =20 > +#define STAT_IS_KERNEL_STAT 0 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/lxstat.c > b/sysdeps/unix/sysv/linux/lxstat.c index e0cfc4f1fa..dcd685873d 100644 > --- a/sysdeps/unix/sysv/linux/lxstat.c > +++ b/sysdeps/unix/sysv/linux/lxstat.c > @@ -37,7 +37,7 @@ __lxstat (int vers, const char *name, struct stat > *buf) if (vers =3D=3D _STAT_VER_KERNEL) > return INLINE_SYSCALL (lstat, 2, name, buf); > =20 > -#ifdef STAT_IS_KERNEL_STAT > +#if STAT_IS_KERNEL_STAT > return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL); > #else > struct kernel_stat kbuf; > diff --git a/sysdeps/unix/sysv/linux/microblaze/kernel_stat.h > b/sysdeps/unix/sysv/linux/microblaze/kernel_stat.h index > 765e0dca67..4daaedc4b6 100644 --- > a/sysdeps/unix/sysv/linux/microblaze/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/microblaze/kernel_stat.h @@ -48,5 +48,6 @@ > struct kernel_stat #define _HAVE_STAT64___UNUSED5 > }; > =20 > +#define STAT_IS_KERNEL_STAT 0 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/mips/kernel_stat.h > b/sysdeps/unix/sysv/linux/mips/kernel_stat.h index > 388df1bfff..e75f3e805b 100644 --- > a/sysdeps/unix/sysv/linux/mips/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/mips/kernel_stat.h @@ -56,5 +56,6 @@ struct > kernel_stat }; > #endif > =20 > +#define STAT_IS_KERNEL_STAT 0 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h > b/sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h index > c5948a4d3c..75610b8df3 100644 --- > a/sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h @@ -47,5 > +47,6 @@ struct kernel_stat #define _HAVE_STAT64___PAD2 > #define _HAVE_STAT64_NSEC > =20 > +#define STAT_IS_KERNEL_STAT 0 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h > b/sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h index > a4416009f1..5c8cacaf67 100644 --- > a/sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h @@ -31,5 +31,6 > @@ struct kernel_stat #define _HAVE_STAT_NSEC > #define _HAVE_STAT64_NSEC > =20 > +#define STAT_IS_KERNEL_STAT 0 > #define XSTAT_IS_XSTAT64 0 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h > b/sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h index > 30afb553b9..d14b2487ac 100644 --- > a/sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h +++ > b/sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h @@ -44,5 +44,6 > @@ struct kernel_stat64 long int __glibc_reserved[3]; > }; > =20 > +#define STAT_IS_KERNEL_STAT 0 > #define XSTAT_IS_XSTAT64 1 > #define STATFS_IS_STATFS64 0 > diff --git a/sysdeps/unix/sysv/linux/xstat.c > b/sysdeps/unix/sysv/linux/xstat.c index a93d635611..76c90e20c7 100644 > --- a/sysdeps/unix/sysv/linux/xstat.c > +++ b/sysdeps/unix/sysv/linux/xstat.c > @@ -37,7 +37,7 @@ __xstat (int vers, const char *name, struct stat > *buf) if (vers =3D=3D _STAT_VER_KERNEL) > return INLINE_SYSCALL (stat, 2, name, buf); > =20 > -#ifdef STAT_IS_KERNEL_STAT > +#if STAT_IS_KERNEL_STAT > return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL); > #else > struct kernel_stat kbuf; > diff --git a/sysdeps/unix/sysv/linux/xstatconv.c > b/sysdeps/unix/sysv/linux/xstatconv.c index c01fb00a3a..3622a82cd0 > 100644 --- a/sysdeps/unix/sysv/linux/xstatconv.c > +++ b/sysdeps/unix/sysv/linux/xstatconv.c > @@ -20,7 +20,7 @@ > #include > #include > =20 > -#ifdef STAT_IS_KERNEL_STAT > +#if STAT_IS_KERNEL_STAT > =20 > /* Dummy. */ > struct kernel_stat; > diff --git a/sysdeps/unix/sysv/linux/xstatconv.h > b/sysdeps/unix/sysv/linux/xstatconv.h index 39102c9469..5319236cae > 100644 --- a/sysdeps/unix/sysv/linux/xstatconv.h > +++ b/sysdeps/unix/sysv/linux/xstatconv.h > @@ -16,7 +16,7 @@ > License along with the GNU C Library; if not, see > . */ > =20 > -#ifndef STAT_IS_KERNEL_STAT > +#if !STAT_IS_KERNEL_STAT > extern int __xstat_conv (int vers, struct kernel_stat *kbuf, void > *ubuf) attribute_hidden; > extern int __xstat64_conv (int vers, struct kernel_stat *kbuf, void > *ubuf) Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/ArI/LVr0RYTBvcEolZ2oupR Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl8amRUACgkQAR8vZIA0 zr0gXwf+LL4nHruxsgvjZwuXPv99ueidE5u/k56MN9yjLCbtFQLFqebpCDQVh1t7 yb40H6xX5UMd4xOr1/Xy9/UWkxcE2eVdMPQKG28LJZCu7jimqK8b1mpY6oaCLe5K VqtEf61MS3emHW7qx+mf7L9ucXH2J0888HEVHivksncBKNbIi6clb7cPSI4zV7Nz q/HiMkRtHJQCOfpk5UpMru/755jpmtHITrPxazDlmJ7lQO/vD1webe0CT7rVzIlg wAX4kiSGwY1HgJ3GXVUEIwm0nwOYjmk5VXeAXkjAy/kEtWk4qzP7cRWuEw+646rl DyywCoR4W46iqptloaNM7G6eB8pSog== =8B3E -----END PGP SIGNATURE----- --Sig_/ArI/LVr0RYTBvcEolZ2oupR--