From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 76E771FA04 for ; Thu, 28 May 2020 09:32:18 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 702A5386F471; Thu, 28 May 2020 09:32:17 +0000 (GMT) Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1]) by sourceware.org (Postfix) with ESMTPS id 125C0386F430 for ; Thu, 28 May 2020 09:32:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 125C0386F430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=samuel.thibault@gnu.org Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 2B1CC488B; Thu, 28 May 2020 11:32:13 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qNEHIYF0Ig2w; Thu, 28 May 2020 11:32:12 +0200 (CEST) Received: from function (lfbn-bor-1-797-11.w86-234.abo.wanadoo.fr [86.234.239.11]) by hera.aquilenet.fr (Postfix) with ESMTPSA id E5B694856; Thu, 28 May 2020 11:32:11 +0200 (CEST) Received: from samy by function with local (Exim 4.93) (envelope-from ) id 1jeEtX-004eOK-9C; Thu, 28 May 2020 11:32:11 +0200 Date: Thu, 28 May 2020 11:32:11 +0200 From: Samuel Thibault To: Florian Weimer Subject: Re: [PATCH 2/2] Hurd: Move internals into wrapper header Message-ID: <20200528093211.tpeauiodlkowd3sn@function> References: <87y2pcmn3a.fsf@totally-fudged-out-message-id> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y2pcmn3a.fsf@totally-fudged-out-message-id> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: commit-hurd@gnu.org, libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Florian Weimer, le jeu. 28 mai 2020 11:23:20 +0200, a ecrit: > _hurdsig_preemptors and _hurdsig_preempted_set are not ABI symbols, > so do not declare them. HURD_PREEMPT_SIGNAL_P is an implementation > detail, so move it as well. Reviewed-by: Samuel Thibault > --- > hurd/hurd/sigpreempt.h | 10 -------- > sysdeps/hurd/include/hurd/sigpreempt.h | 32 ++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+), 10 deletions(-) > create mode 100644 sysdeps/hurd/include/hurd/sigpreempt.h > > diff --git a/hurd/hurd/sigpreempt.h b/hurd/hurd/sigpreempt.h > index 4ab5b1369f..8cbf66a198 100644 > --- a/hurd/hurd/sigpreempt.h > +++ b/hurd/hurd/sigpreempt.h > @@ -50,16 +50,6 @@ struct hurd_signal_preemptor > struct hurd_signal_preemptor *next; /* List structure. */ > }; > > -#define HURD_PREEMPT_SIGNAL_P(preemptor, signo, sigcode) \ > - (((preemptor)->signals & __sigmask (signo)) \ > - && (sigcode) >= (preemptor)->first && (sigcode) <= (preemptor)->last) > - > - > -/* Signal preemptors applying to all threads; locked by _hurd_siglock. */ > -extern struct hurd_signal_preemptor *_hurdsig_preemptors; > -extern sigset_t _hurdsig_preempted_set; > - > - > /* The caller must initialize all members of *PREEMPTOR except `next'. > The preemptor is registered on the global list. */ > void hurd_preempt_signals (struct hurd_signal_preemptor *preemptor); > diff --git a/sysdeps/hurd/include/hurd/sigpreempt.h b/sysdeps/hurd/include/hurd/sigpreempt.h > new file mode 100644 > index 0000000000..fc0fdfd5e8 > --- /dev/null > +++ b/sysdeps/hurd/include/hurd/sigpreempt.h > @@ -0,0 +1,32 @@ > +/* Preemption of Hurd signals before POSIX.1 semantics take over. Wrapper. > + Copyright (C) 1996-2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#ifndef _HURD_SIGPREEMPT_H > +# include > + > +# ifndef _ISOMAC > +# define HURD_PREEMPT_SIGNAL_P(preemptor, signo, sigcode) \ > + (((preemptor)->signals & __sigmask (signo)) \ > + && (sigcode) >= (preemptor)->first && (sigcode) <= (preemptor)->last) > + > +/* Signal preemptors applying to all threads; locked by _hurd_siglock. */ > +extern struct hurd_signal_preemptor *_hurdsig_preemptors; > +extern sigset_t _hurdsig_preempted_set; > + > +# endif /* _ISOMAC */ > +#endif /* _HURD_SIGPREEMPT_H */ > -- > 2.20.1 > -- Samuel +#if defined(__alpha__) && defined(CONFIG_PCI) + /* + * The meaning of life, the universe, and everything. Plus + * this makes the year come out right. + */ + year -= 42; +#endif (From the patch for 1.3.2: (kernel/time.c), submitted by Marcus Meissner)