From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A792E1F55B for ; Wed, 27 May 2020 10:31:10 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F31493984FCD; Wed, 27 May 2020 10:31:08 +0000 (GMT) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by sourceware.org (Postfix) with ESMTPS id D7C293984042 for ; Wed, 27 May 2020 10:31:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D7C293984042 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ubuntu.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=christian.brauner@ubuntu.com Received: from ip5f5af183.dynamic.kabel-deutschland.de ([95.90.241.131] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jdtKw-0005g7-Q9; Wed, 27 May 2020 10:31:02 +0000 Date: Wed, 27 May 2020 12:31:02 +0200 From: Christian Brauner To: Florian Weimer Subject: Re: [PATCH 3/3] Linux: Require properly configured /dev/pts for PTYs Message-ID: <20200527103102.u3jti3yngvj2rnes@wittgenstein> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Wed, May 27, 2020 at 12:14:37PM +0200, Florian Weimer via Libc-alpha wrote: > Current systems do not have BSD terminals, so the fallback code in > posix_openpt/getpt does not do anything. Also remove the file system > check for /dev/pts. Current systems always have a devpts file system > mounted there if /dev/ptmx exists. Good change! In addition, on newer kernels you also have TIOCGPTPEER which wouldn't even require /dev/pts be present and permits race-free access to a /dev/pts/* device solely based on the /dev/ptmx fd. And we've made sure that glibc already supports that. So ack from me. Christian