From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 726B11F55B for ; Tue, 26 May 2020 18:39:11 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CBAC4388F045; Tue, 26 May 2020 18:39:09 +0000 (GMT) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2052.outbound.protection.outlook.com [40.107.20.52]) by sourceware.org (Postfix) with ESMTPS id 99905385C426 for ; Tue, 26 May 2020 18:39:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 99905385C426 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Szabolcs.Nagy@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DfnrX7NvFN3/b5sNkanZCBYgpHXUrpg3jb7tuPwsY+Q=; b=y69p2CXd7XQHW+7xKH6qqL+8TSdXbqobGp2HLG17n0oF6Lpz/1ur7sLVWnIA+aBPuCZGyj5M3z6XJ2WESph5m1CaIjzL7DWlwoqY1aFLUc53bQgR3P0vnnQVezS2zdDEuHltNXcwXuBw1dpiAEoaYl2MwjAm1qzIoCcVBQnIpK0= Received: from AM6P193CA0084.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::25) by VE1PR08MB5151.eurprd08.prod.outlook.com (2603:10a6:803:10c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.27; Tue, 26 May 2020 18:39:04 +0000 Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:88:cafe::de) by AM6P193CA0084.outlook.office365.com (2603:10a6:209:88::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17 via Frontend Transport; Tue, 26 May 2020 18:39:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Tue, 26 May 2020 18:39:04 +0000 Received: ("Tessian outbound 952576a3272a:v57"); Tue, 26 May 2020 18:39:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 22128676fd6b55ca X-CR-MTA-TID: 64aa7808 Received: from 7ff676976d8a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CFA9AF9E-8572-46F9-B780-242F0FD667E6.1; Tue, 26 May 2020 18:38:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7ff676976d8a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 May 2020 18:38:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q2jgNqmt6IvPiB3kpvjG0pF6XxCqNqOaaktzc7I+rY4Dypgpq2tWGo2jvhQ5PNrdMK/Nrr60aXL4lGDLdKdRSoqcvuo80ZanwJye1f686z5dNj5xd0l1GR2EHtys0d8MAfUPToNOCLRBuqUoDTjzYNfOlvb8ZN7BqZkrkhkJ8YzpN/alR0YGRywBUy5OLLpRWB+7gK7uwPtvhwZ31urQAC+DsIrnot1p/HP1KjTM9HQct+xPH6/iNv2w/9RGO4A5nDJa04WErJXSzub9dUj3ZGt1xM0Tfm5mK60Tm4ysTjPIawC/xgJUm42ZYFeRuFZZCxcXqFuEW+PjZL5/xV0Abw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DfnrX7NvFN3/b5sNkanZCBYgpHXUrpg3jb7tuPwsY+Q=; b=WgfxR8A3hj/MXI0QgT6hXhkmEjhnoYS3WAYUyrAoy1By1qZR6NsjsV1ZO27OZymep0jcW7Rzr1EdcPO5Ljf1mF1iMmTYdEEb3I3pZAPqIn2hmYzTftkPpfUjVDi67tvK5OBpLeotR37sZyp4m0S3DUa+au5lKS2jnIZ+HEzPviwOfzC22m16y/ONnnVJVySs31FhHaKiZgZ/a731+oartuVhJauM55NqxkDVHlXrrhTc4nZtrPyrrIoMxkv3QOK+zhAHmwj3mo6cJIQdW9IMrtKylUkVafFKLfKIEXSSdOksHEhXwqJx+BvSNqWJq+ppL6RYgIHdqCG0S2tEJdi36w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DfnrX7NvFN3/b5sNkanZCBYgpHXUrpg3jb7tuPwsY+Q=; b=y69p2CXd7XQHW+7xKH6qqL+8TSdXbqobGp2HLG17n0oF6Lpz/1ur7sLVWnIA+aBPuCZGyj5M3z6XJ2WESph5m1CaIjzL7DWlwoqY1aFLUc53bQgR3P0vnnQVezS2zdDEuHltNXcwXuBw1dpiAEoaYl2MwjAm1qzIoCcVBQnIpK0= Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB3047.eurprd08.prod.outlook.com (2603:10a6:209:4c::23) by AM6PR08MB4721.eurprd08.prod.outlook.com (2603:10a6:20b:c7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.26; Tue, 26 May 2020 18:38:56 +0000 Received: from AM6PR08MB3047.eurprd08.prod.outlook.com ([fe80::49fd:6ded:4da7:8862]) by AM6PR08MB3047.eurprd08.prod.outlook.com ([fe80::49fd:6ded:4da7:8862%7]) with mapi id 15.20.3021.029; Tue, 26 May 2020 18:38:56 +0000 Date: Tue, 26 May 2020 19:38:54 +0100 From: Szabolcs Nagy To: Adhemerval Zanella Subject: Re: [PATCH v3 13/13] aarch64: fix _mcount for pac-ret Message-ID: <20200526183853.GA24512@arm.com> References: <3d422103bcd42547829b53fa07d3891e5bfabba3.1589552055.git.szabolcs.nagy@arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: LO2P265CA0080.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::20) To AM6PR08MB3047.eurprd08.prod.outlook.com (2603:10a6:209:4c::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.55) by LO2P265CA0080.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24 via Frontend Transport; Tue, 26 May 2020 18:38:56 +0000 X-Originating-IP: [217.140.106.55] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: bbb8401f-99bb-4b84-80d1-08d801a410fb X-MS-TrafficTypeDiagnostic: AM6PR08MB4721:|VE1PR08MB5151: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219; X-Forefront-PRVS: 041517DFAB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9qWy5XrNa5znVrs3RKgfoVU/PR4ykS1kFUV4VjMdeJWL/aJxLk07I/8RghQ9Pk1Rs3zcqSZrbby7LLONCov6Tb/bbb2X1CtNUtJstDy7Cmz28wQ7r5CjP7UhEmHvvGMqGjZe9WHZwVT/bfL0nCUOBjjD3zG9zVCL6gG6ik4RnHDcWmfAs9ZDjfQ6nmWEq6O7vswqgkecjKPDOLz/hgvMm18pLw4NKs4zC7PAqRba1wY8NyEpFNeaQTWYOuM2d1H45xtqpwuR0vm/xmK9e20Wt8pgtLfiFWbh2aEjopOQH8iiMUl1rCC2wThEKf3aX667U3MKybiblf+1p9xJNdrcjV9ILqHnjCHzYM9GuVSYV3MkHZNYTC/6PtlLolihZCgTI3a9nE6A3WqyXYd78YoqcQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB3047.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(136003)(376002)(366004)(396003)(346002)(2616005)(36756003)(8936002)(33656002)(956004)(8676002)(316002)(8886007)(86362001)(1076003)(44832011)(2906002)(966005)(478600001)(4326008)(186003)(6916009)(7696005)(66556008)(66476007)(55016002)(66946007)(52116002)(5660300002)(53546011)(16526019)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Gn3v2lJwa5l7TNMxOPOY0cDXV9w7V2KPwN+z7G4lGq7+6ESASKwfvrqKPWM66THlKz+Nr9LrE8EcQFRBLxscrYK/7KENxeY5hXURvboTmi6MrSKSYsObxzqxKuSg0pwuGTb0kr1T8thkCYtOvbobYcfdjbIGtZly1u4RCRkXFEKdj6nyZqtB5AZswY6LJ3g4VY0b0ESoWjxbR7isxfxQRwu9M8GFeGRQxutqNZrwT+pU3hML5Qy5OvAxspeZu+q240UGVbFG5eTBUoWUWuBnnux7nZN4gbOhRWknTg6n7h9VHEdSQk7dkae0ElHLApgFDPHHh4fEFgM6cP/Dm5Y881nSd/XQyy3XpWMkh1AzjbnE/AVXKjhm866YI6qGPVlzyMMuzNQbh5QRIpGI1XObwcwXMCYKbGQap9h9lhchPGbUhsGqTI3sKe4vaUGiyDvareK7ylfCxv8AsYeFM969ZMpMF/RPWV4dwL7fRHbtGeV9oHkKyqdzY7/u9ZoNgGo3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4721 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(136003)(396003)(39850400004)(46966005)(36906005)(356005)(316002)(33656002)(55016002)(5660300002)(8676002)(4326008)(82310400002)(966005)(1076003)(8936002)(36756003)(86362001)(44832011)(336012)(6862004)(53546011)(26005)(82740400003)(186003)(16526019)(7696005)(8886007)(956004)(478600001)(2616005)(81166007)(70586007)(2906002)(47076004)(70206006); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: a77dbb33-b006-45e9-080a-08d801a40c37 X-Forefront-PRVS: 041517DFAB X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NW9g7VWjV907Sl4Km/peuN7C3iUc1kEnS3utsK0Cd4tOG0IXoxjdGC9a6saJAzZSeAo7bJS+smRxNEQ3ljkeo5INX2SPYx7QiCDHGU34nzDLwwffEN8rHUjMY1Yrh8ONe2mk1FsRPtX2K5agauuZNlSr14idBuxQ9oCISwchizpXTTUxjACZzOqMYzzdsH1y/1khEmSrY4UmKQ32mgltrSKMM1M6WcQR3El1FfSEdi9YjlKzTClPA4McOm3hu/TIG9nCqzXuoOLABO/ilBEalroiRqjRTwCzNUtwzMAZacnn//8zWMIwe01eEP2jwKAWKHe9M3IZb2pFhHF0eRvHDwD0YMk4Rw5B1MfyCdw09kmfbmgxuSqYT1PBhlqnYPfG86bddntIfL2eK9QeKvEpmhCU8uZ8Wl102WuJAhZ/0Vip7HFIUZ1NEntc72Oa7ZhzltindzR0mG1QwAsQH/nidoopLb07i0Q4+Y9wm0DWeCM= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2020 18:39:04.3077 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bbb8401f-99bb-4b84-80d1-08d801a410fb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5151 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" The 05/26/2020 08:33, Adhemerval Zanella via Libc-alpha wrote: > > > On 15/05/2020 11:40, Szabolcs Nagy wrote: > > gcc -pg with -mbranch-protection=pac-ret passes signed return address > > to _mcount, so _mcount now has to always strip pac from the frompc > > since that's from user code that may be built with pac-ret. > > > > This is a backward incompatible _mcount abi change introduced by > > return address signing support in gcc-7. > > Which change are you referring about specifically? gcc-7 introduced -msigned-return-address (which was later deprecated by -mbranch-protection=pac-ret) and the code generation with -pg is not compatible with existing _mcount runtime implementations (because now _mcount needs unconditional xpac) i'm still trying to see if this _mcount change is needed or we can change gcc to do the right thing (and not pass signed address to _mcount), but i need internal consensus about such abi break first. > > Besides it, LGTM. > > Reviewed-by: Adhemerval Zanella > > > > > TODO: fix -pg on the gcc side? > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94791 > > --- > > sysdeps/aarch64/machine-gmon.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sysdeps/aarch64/machine-gmon.h b/sysdeps/aarch64/machine-gmon.h > > index 730a23b781..328cbdda16 100644 > > --- a/sysdeps/aarch64/machine-gmon.h > > +++ b/sysdeps/aarch64/machine-gmon.h > > @@ -30,5 +30,5 @@ static inline void mcount_internal (u_long frompc, u_long selfpc) > > #define MCOUNT \ > > void __mcount (void *frompc) \ > > { \ > > - mcount_internal ((u_long) frompc, (u_long) RETURN_ADDRESS (0)); \ > > + mcount_internal ((u_long) strip_pac (frompc), (u_long) RETURN_ADDRESS (0)); \ > > } > > --