From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 165611F55B for ; Mon, 25 May 2020 10:40:49 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1BDAA383F870; Mon, 25 May 2020 10:40:48 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 05D9438708EB for ; Mon, 25 May 2020 10:40:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 05D9438708EB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49Vtsk4p24z1qsb0; Mon, 25 May 2020 12:40:42 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49Vtsk2fxbz1qtx0; Mon, 25 May 2020 12:40:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id W1exqtaAWef7; Mon, 25 May 2020 12:40:40 +0200 (CEST) X-Auth-Info: 2n53puRoftGA1deIIlQTOVaCWpVtWha7q7EBj7agRCQ= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 25 May 2020 12:40:40 +0200 (CEST) Date: Mon, 25 May 2020 12:40:32 +0200 From: Lukasz Majewski To: "H.J. Lu" Subject: Re: V2 [PATCH] Fix __clock_gettime64 for sysdeps/generic/hp-timing.h Message-ID: <20200525124032.20d0ca3b@jawa> In-Reply-To: References: <20200505181605.22346-1-lukma@denx.de> <20200521122423.7d98dd96@jawa> <20200524110338.0165621c@jawa> <20200524173021.3f5a926f@jawa> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/yUKXrj+OdL7.utRBPzLSexp"; protocol="application/pgp-signature" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , GNU C Library , Andreas Schwab , Alistair Francis , Joseph Myers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --Sig_/yUKXrj+OdL7.utRBPzLSexp Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 24 May 2020 16:34:44 -0700 "H.J. Lu" wrote: > On Sun, May 24, 2020 at 9:13 AM H.J. Lu wrote: > > > > On Sun, May 24, 2020 at 8:30 AM Lukasz Majewski > > wrote: =20 > > > > > > On Sun, 24 May 2020 04:39:47 -0700 > > > "H.J. Lu" wrote: > > > =20 > > > > On Sun, May 24, 2020 at 2:03 AM Lukasz Majewski > > > > wrote: =20 > > > > > > > > > > On Sat, 23 May 2020 13:32:05 -0700 > > > > > "H.J. Lu" wrote: > > > > > =20 > > > > > > On Thu, May 21, 2020 at 4:11 AM H.J. Lu > > > > > > wrote: =20 > > > > > > > > > > > > > > On Thu, May 21, 2020 at 3:24 AM Lukasz Majewski > > > > > > > wrote: =20 > > > > > > > > > > > > > > > > Hi "H.J. Lu", > > > > > > > > =20 > > > > > > > > > On Tue, May 5, 2020 at 11:21 AM Lukasz Majewski > > > > > > > > > wrote: =20 > > > > > > > > > > > > > > > > > > > > The __clock_gettime internal function is not > > > > > > > > > > supporting 64 bit time on architectures with > > > > > > > > > > __WORDSIZE =3D=3D 32 and __TIMESIZE !=3D 64 (like e.g. > > > > > > > > > > ARM 32 bit). > > > > > > > > > > > > > > > > > > > > The __clock_gettime64 function shall be used > > > > > > > > > > instead in the glibc itself as it supports 64 bit > > > > > > > > > > time on those systems. This patch does not bring > > > > > > > > > > any changes to systems with __WORDSIZE =3D=3D 64 as for > > > > > > > > > > them the __clock_gettime64 is aliased to > > > > > > > > > > __clock_gettime (in ./include/time.h). > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > Changes for v3: > > > > > > > > > > - Fix the commit message (add missing "function" > > > > > > > > > > after __clock_gettime64) > > > > > > > > > > - Refactor __nisfind_server() function to support > > > > > > > > > > 64 bit time with struct timespec instead of struct > > > > > > > > > > timeval > > > > > > > > > > - Change expires to __time64_t > > > > > > > > > > > > > > > > > > > > Changes for v2: > > > > > > > > > > - Use only TIMESPEC_TO_TIMEVAL instead of > > > > > > > > > > valid_timespec64_to_timeval in logout.c and > > > > > > > > > > logwtmp.c as it is generic enough to also support > > > > > > > > > > struct __timespec64 conversion to struct timeval --- > > > > > > > > > > benchtests/bench-timing.h | > > > > > > > > > > 2 +- include/random-bits.h > > > > > > > > > > | 4 ++-- login/logout.c > > > > > > > > > > | 4 ++-- login/logwtmp.c > > > > > > > > > > | 5 +++-- nis/nis_call.c > > > > > > > > > > | 16 +++++++--------- sysdeps/generic/hp-timing.h > > > > > > > > > > | 4 ++-- sysdeps/generic/memusage.h > > > > > > > > > > | 4 ++-- > > > > > > > > > > sysdeps/unix/sysv/linux/alpha/osf_gettimeofday.c | > > > > > > > > > > 4 ++-- sysdeps/unix/sysv/linux/clock.c > > > > > > > > > > | 7 ++----- 9 files changed, 23 insertions(+), > > > > > > > > > > 27 deletions(-) =20 > > > > > > > > > > > > > > > > > > Does this patch work with "make bench" when > > > > > > > > > sysdeps/generic/hp-timing.h is used, like on arm? I > > > > > > > > > got In file included from ./bench-timing.h:23, > > > > > > > > > from ./bench-skeleton.c:25, > > > > > > > > > from > > > > > > > > > /export/build/gnu/tools-build/glibc-gitlab/build-x86_64-l= inux/benchtests/bench-rint.c:45: > > > > > > > > > ./bench-skeleton.c: In function =E2=80=98main=E2=80=99: > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: storage > > > > > > > > > size of =E2=80=98tv=E2=80=99 isn=E2=80=99t known 37 | s= truct __timespec64 > > > > > > > > > tv; \ | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:82:8: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 82 | > > > > > > > > > TIMING_NOW (start); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:38:3: error: implicit > > > > > > > > > declaration of function =E2=80=98__clock_gettime64=E2=80= =99; did you > > > > > > > > > mean =E2=80=98clock_gettime=E2=80=99? > > > > > > > > > [-Werror=3Dimplicit-function-declaration] 38 | > > > > > > > > > __clock_gettime64 (CLOCK_MONOTONIC, &tv); \ | > > > > > > > > > ^~~~~~~~~~~~~~~~~ ./bench-timing.h:35:25: note: in > > > > > > > > > expansion of macro =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #= define > > > > > > > > > TIMING_NOW(var) HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:82:8: note: > > > > > > > > > in expansion of macro =E2=80=98TIMING_NOW=E2=80=99 82 | > > > > > > > > > TIMING_NOW (start); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: unused > > > > > > > > > variable =E2=80=98tv=E2=80=99 [-Werror=3Dunused-variable] > > > > > > > > > 37 | struct __timespec64 tv; \ > > > > > > > > > | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:82:8: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 82 | > > > > > > > > > TIMING_NOW (start); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: storage > > > > > > > > > size of =E2=80=98tv=E2=80=99 isn=E2=80=99t known 37 | s= truct __timespec64 > > > > > > > > > tv; \ | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:86:8: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 86 | > > > > > > > > > TIMING_NOW (end); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: unused > > > > > > > > > variable =E2=80=98tv=E2=80=99 [-Werror=3Dunused-variable] > > > > > > > > > 37 | struct __timespec64 tv; \ > > > > > > > > > | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:86:8: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 86 | > > > > > > > > > TIMING_NOW (end); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: storage > > > > > > > > > size of =E2=80=98tv=E2=80=99 isn=E2=80=99t known 37 | s= truct __timespec64 > > > > > > > > > tv; \ | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:90:8: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 90 | > > > > > > > > > TIMING_NOW (start); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: unused > > > > > > > > > variable =E2=80=98tv=E2=80=99 [-Werror=3Dunused-variable] > > > > > > > > > 37 | struct __timespec64 tv; \ > > > > > > > > > | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:90:8: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 90 | > > > > > > > > > TIMING_NOW (start); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: storage > > > > > > > > > size of =E2=80=98tv=E2=80=99 isn=E2=80=99t known 37 | s= truct __timespec64 > > > > > > > > > tv; \ | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:94:8: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 94 | > > > > > > > > > TIMING_NOW (end); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: unused > > > > > > > > > variable =E2=80=98tv=E2=80=99 [-Werror=3Dunused-variable] > > > > > > > > > 37 | struct __timespec64 tv; \ > > > > > > > > > | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:94:8: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 94 | > > > > > > > > > TIMING_NOW (end); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: storage > > > > > > > > > size of =E2=80=98tv=E2=80=99 isn=E2=80=99t known 37 | s= truct __timespec64 > > > > > > > > > tv; \ | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:103:3: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 103 | T= IMING_NOW > > > > > > > > > (start); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: unused > > > > > > > > > variable =E2=80=98tv=E2=80=99 [-Werror=3Dunused-variable] > > > > > > > > > 37 | struct __timespec64 tv; \ > > > > > > > > > | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:103:3: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 103 | T= IMING_NOW > > > > > > > > > (start); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: storage > > > > > > > > > size of =E2=80=98tv=E2=80=99 isn=E2=80=99t known 37 | s= truct __timespec64 > > > > > > > > > tv; \ | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:106:3: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 106 | T= IMING_NOW > > > > > > > > > (end); | ^~~~~~~~~~ > > > > > > > > > ../sysdeps/generic/hp-timing.h:37:23: error: unused > > > > > > > > > variable =E2=80=98tv=E2=80=99 [-Werror=3Dunused-variable] > > > > > > > > > 37 | struct __timespec64 tv; \ > > > > > > > > > | ^~ > > > > > > > > > ./bench-timing.h:35:25: note: in expansion of macro > > > > > > > > > =E2=80=98HP_TIMING_NOW=E2=80=99 35 | #define TIMING_NOW(v= ar) > > > > > > > > > HP_TIMING_NOW (var) | > > > > > > > > > ^~~~~~~~~~~~~ ./bench-skeleton.c:106:3: note: in > > > > > > > > > expansion of macro =E2=80=98TIMING_NOW=E2=80=99 106 | T= IMING_NOW > > > > > > > > > (end); | ^~~~~~~~~~ > > > > > > > > > cc1: all warnings being treated as errors =20 > > > > > > > > > > > > > > > > How shall I reproduce this error? =20 > > > > > > > > > > > > > > Apply the enclosed patch and do > > > > > > > > > > > > > > $ make USE_CLOCK_GETTIME=3D1 bench > > > > > > > =20 > > > > > > > > Was it supposed to be catch with build-many-glibc.py ? > > > > > > > > =20 > > > > > > > > > > > > > > No, "make bench" isn't tested by build-many-glibc.py. > > > > > > > =20 > > > > > > > > > > > > Here is the patch to fix __clock_gettime64 for > > > > > > sysdeps/generic/hp-timing.h. OK for master? > > > > > > =20 > > > > > > > > > > Thanks for preparing the fix. > > > > > > > > > > If I may ask - I do have some question about the following > > > > > code: +#else > > > > > +struct __timespec64; > > > > > +extern int __clock_gettime64 (clockid_t clock_id, struct > > > > > __timespec64 *tp); +#endif > > > > > > > > > > Why do we need the "struct __timespec64;" declaration there as > > > > > in ./sysdeps/generic/hp-timing.h you explicitly added: > > > > > #include ? > > > > > =20 > > > > > > > > include/time.h is also included by other files which may not > > > > include . > > > > =20 > > > > > > In which files you observe this situation? > > > > > > The was introduced to avoid including > > > time.h when only new, y2038 safe struct __timespec64 is necessary. > > > =20 > > > > Without it, I got > > > > cc -m32 getprtent_r.c -c -std=3Dgnu11 -fgnu89-inline -O2 -g > > -march=3Di686 -Wall -Wwrite-strings -Wundef -Werror > > -fmerge-all-constants -frounding-math -fno-stack-protector > > -Wstrict-prototypes -Wold-style-definition -fmath-errno -fPIC > > -Wa,-mtune=3Di686 -fexceptions -ftls-model=3Dinitial-exec > > -I../include > > -I/export/build/gnu/tools-build/glibc-32bit-gitlab/build-i686-linux/inet > > -I/export/build/gnu/tools-build/glibc-32bit-gitlab/build-i686-linux > > -I../sysdeps/unix/sysv/linux/i386/i686 -I../sysdeps/i386/i686/nptl > > -I../sysdeps/unix/sysv/linux/i386 > > -I../sysdeps/unix/sysv/linux/x86/include > > -I../sysdeps/unix/sysv/linux/x86 -I../sysdeps/x86/nptl > > -I../sysdeps/i386/nptl -I../sysdeps/unix/sysv/linux/include > > -I../sysdeps/unix/sysv/linux -I../sysdeps/nptl > > -I../sysdeps/pthread -I../sysdeps/gnu -I../sysdeps/unix/inet > > -I../sysdeps/unix/sysv -I../sysdeps/unix/i386 -I../sysdeps/unix > > -I../sysdeps/posix -I../sysdeps/i386/i686/fpu/multiarch > > -I../sysdeps/i386/i686/fpu -I../sysdeps/i386/i686/multiarch > > -I../sysdeps/i386/i686 -I../sysdeps/i386/fpu -I../sysdeps/x86/fpu > > -I../sysdeps/i386 -I../sysdeps/x86 -I../sysdeps/wordsize-32 > > -I../sysdeps/ieee754/float128 -I../sysdeps/ieee754/ldbl-96/include > > -I../sysdeps/ieee754/ldbl-96 -I../sysdeps/ieee754/dbl-64 > > -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754 > > -I../sysdeps/generic -I.. -I../libio -I. -D_LIBC_REENTRANT > > -include > > /export/build/gnu/tools-build/glibc-32bit-gitlab/build-i686-linux/libc-= modules.h > > -DMODULE_NAME=3Dlibc -include ../include/libc-symbols.h -DPIC > > -DSHARED -DTOP_NAMESPACE=3Dglibc -o > > /export/build/gnu/tools-build/glibc-32bit-gitlab/build-i686-linux/inet/= getprtent_r.os > > -MD -MP -MF > > /export/build/gnu/tools-build/glibc-32bit-gitlab/build-i686-linux/inet/= getprtent_r.os.dt > > -MT > > /export/build/gnu/tools-build/glibc-32bit-gitlab/build-i686-linux/inet/= getprtent_r.os > > In file included from ../sysdeps/nptl/lowlevellock.h:24, from > > ../sysdeps/unix/sysv/linux/x86/lowlevellock.h:23, from > > ../nptl/descr.h:29, from ../sysdeps/i386/nptl/tls.h:120, from > > ../sysdeps/i386/i686/nptl/tls.h:33, from ../include/link.h:51, from > > ../include/dlfcn.h:4, from ../nss/nsswitch.h:28, from > > ../include/nsswitch.h:1, from ../inet/netgroup.h:22, > > from ../include/netdb.h:203, > > from getprtent_r.c:18: > > ../include/time.h:9:58: error: =E2=80=98struct __timespec64=E2=80=99 de= clared inside > > parameter list will not be visible outside of this definition or > > declaration [-Werror] > > 9 | extern int __clock_gettime64 (clockid_t clock_id, struct > > __timespec64 *tp); > > | > > ^~~~~~~~~~~~ cc1: all warnings being treated as errors > > > > This may happen for all 32-bit targets. =20 >=20 > We can't change include/time.h. Here is the updated patch > to put __clock_gettime64 in sysdeps/generic/hp-timing.h if > _ISOMAC is defined. >=20 It looks fine for me, but I think that some other (i.e. Joseph, Florian) glibc developers shall also review it. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/yUKXrj+OdL7.utRBPzLSexp Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl7LoKAACgkQAR8vZIA0 zr1wEAf/RQMyYWc+AoSpJz7UqTRKa6eFBCkKgq+D9MLwPNxuZgNGjMYPv7lqJydZ bDKrc3MXjrKT+KPQ8DdnG8hjLgXkzy+p22RaOQl6VKe1HUJOnm6NP3h/RaBgSYhH DZXDwNSK+2j56CoduB8c9GYLdHj7qeASLTJbgX2nlqbZJug2EcCmD+iMBTmg+dq5 MqeNocHRZp57FK6k2ELciDYMoPbOXhprTYNgiVmxsM0YUw2iKufuueJ8S3xWbNn/ dk8yqc0Dlbj2Frch4CKoeSiv1pNzwAU4LFU1MH0wegtF0cF7cR1Od2gXeBRtVKrX CR1SoSI+9l91o+Wd3vIAEu460O2tXg== =RdBp -----END PGP SIGNATURE----- --Sig_/yUKXrj+OdL7.utRBPzLSexp--