From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 036411F55B for ; Tue, 19 May 2020 19:51:14 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 005833840C17; Tue, 19 May 2020 19:51:13 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id A522D38708EE for ; Tue, 19 May 2020 19:51:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A522D38708EE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49RRMc1yKnz1rs00; Tue, 19 May 2020 21:51:08 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49RRMb6nZ6z1qtwJ; Tue, 19 May 2020 21:51:07 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id xzCAQOymxueA; Tue, 19 May 2020 21:51:06 +0200 (CEST) X-Auth-Info: vw0HheuthsULA34A8b/qMTIX5d3wlfiWiA53kvza+H8= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 19 May 2020 21:51:06 +0200 (CEST) Date: Tue, 19 May 2020 21:51:04 +0200 From: Lukasz Majewski To: Joseph Myers , Adhemerval Zanella Subject: Re: [PATCH v3] y2038: Replace __clock_gettime with __clock_gettime64 Message-ID: <20200519215049.0eaf570b@jawa> In-Reply-To: <20200505181605.22346-1-lukma@denx.de> References: <20200505181605.22346-1-lukma@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/b/KDnmkCKePMg/RiOcGDFvq"; protocol="application/pgp-signature" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , GNU C Library , Alistair Francis , Andreas Schwab Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --Sig_/b/KDnmkCKePMg/RiOcGDFvq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Dear All, > The __clock_gettime internal function is not supporting 64 bit time on > architectures with __WORDSIZE =3D=3D 32 and __TIMESIZE !=3D 64 (like e.g. > ARM 32 bit). >=20 > The __clock_gettime64 function shall be used instead in the glibc > itself as it supports 64 bit time on those systems. > This patch does not bring any changes to systems with __WORDSIZE =3D=3D > 64 as for them the __clock_gettime64 is aliased to __clock_gettime (in > ./include/time.h). Gentle ping on this patch. It has been on the glibc-alpha for 2 weeks now ... Is it OK to pull? >=20 > --- > Changes for v3: > - Fix the commit message (add missing "function" after > __clock_gettime64) > - Refactor __nisfind_server() function to support 64 bit time > with struct timespec instead of struct timeval > - Change expires to __time64_t >=20 > Changes for v2: > - Use only TIMESPEC_TO_TIMEVAL instead of valid_timespec64_to_timeval > in logout.c and logwtmp.c as it is generic enough to also support > struct __timespec64 conversion to struct timeval > --- > benchtests/bench-timing.h | 2 +- > include/random-bits.h | 4 ++-- > login/logout.c | 4 ++-- > login/logwtmp.c | 5 +++-- > nis/nis_call.c | 16 > +++++++--------- sysdeps/generic/hp-timing.h | > 4 ++-- sysdeps/generic/memusage.h | 4 ++-- > sysdeps/unix/sysv/linux/alpha/osf_gettimeofday.c | 4 ++-- > sysdeps/unix/sysv/linux/clock.c | 7 ++----- > 9 files changed, 23 insertions(+), 27 deletions(-) >=20 > diff --git a/benchtests/bench-timing.h b/benchtests/bench-timing.h > index 5b9a8384bb..a0d6f82465 100644 > --- a/benchtests/bench-timing.h > +++ b/benchtests/bench-timing.h > @@ -18,7 +18,7 @@ > =20 > #undef attribute_hidden > #define attribute_hidden > -#define __clock_gettime clock_gettime > +#define __clock_gettime __clock_gettime64 > #include > #include > =20 > diff --git a/include/random-bits.h b/include/random-bits.h > index fd3fa01f9b..7561e55ca6 100644 > --- a/include/random-bits.h > +++ b/include/random-bits.h > @@ -30,8 +30,8 @@ > static inline uint32_t > random_bits (void) > { > - struct timespec tv; > - __clock_gettime (CLOCK_MONOTONIC, &tv); > + struct __timespec64 tv; > + __clock_gettime64 (CLOCK_MONOTONIC, &tv); > /* Shuffle the lower bits to minimize the clock bias. */ > uint32_t ret =3D tv.tv_nsec ^ tv.tv_sec; > ret ^=3D (ret << 24) | (ret >> 8); > diff --git a/login/logout.c b/login/logout.c > index 7653fe8886..091312eb1d 100644 > --- a/login/logout.c > +++ b/login/logout.c > @@ -47,8 +47,8 @@ logout (const char *line) > memset (ut->ut_name, '\0', sizeof ut->ut_name); > memset (ut->ut_host, '\0', sizeof ut->ut_host); > =20 > - struct timespec ts; > - __clock_gettime (CLOCK_REALTIME, &ts); > + struct __timespec64 ts; > + __clock_gettime64 (CLOCK_REALTIME, &ts); > TIMESPEC_TO_TIMEVAL (&ut->ut_tv, &ts); > ut->ut_type =3D DEAD_PROCESS; > =20 > diff --git a/login/logwtmp.c b/login/logwtmp.c > index 90406acc3d..050219c153 100644 > --- a/login/logwtmp.c > +++ b/login/logwtmp.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > =20 > =20 > void > @@ -36,8 +37,8 @@ logwtmp (const char *line, const char *name, const > char *host) strncpy (ut.ut_name, name, sizeof ut.ut_name); > strncpy (ut.ut_host, host, sizeof ut.ut_host); > =20 > - struct timespec ts; > - __clock_gettime (CLOCK_REALTIME, &ts); > + struct __timespec64 ts; > + __clock_gettime64 (CLOCK_REALTIME, &ts); > TIMESPEC_TO_TIMEVAL (&ut.ut_tv, &ts); > =20 > updwtmp (_PATH_WTMP, &ut); > diff --git a/nis/nis_call.c b/nis/nis_call.c > index 92c70e97aa..da4c52bdcd 100644 > --- a/nis/nis_call.c > +++ b/nis/nis_call.c > @@ -575,7 +575,7 @@ static struct nis_server_cache > unsigned int size; > unsigned int server_used; > unsigned int current_ep; > - time_t expires; > + __time64_t expires; > char name[]; > } *nis_server_cache[16]; > static time_t nis_cold_start_mtime; > @@ -584,7 +584,7 @@ __libc_lock_define_initialized (static, > nis_server_cache_lock) static directory_obj * > nis_server_cache_search (const_nis_name name, int search_parent, > unsigned int *server_used, unsigned int > *current_ep, > - struct timeval *now) > + struct __timespec64 *now) > { > directory_obj *ret =3D NULL; > int i; > @@ -642,7 +642,7 @@ nis_server_cache_search (const_nis_name name, int > search_parent, static void > nis_server_cache_add (const_nis_name name, int search_parent, > directory_obj *dir, unsigned int server_used, > - unsigned int current_ep, struct timeval *now) > + unsigned int current_ep, struct __timespec64 > *now) { > struct nis_server_cache **loc; > struct nis_server_cache *new; > @@ -708,8 +708,7 @@ __nisfind_server (const_nis_name name, int > search_parent, nis_error result =3D NIS_SUCCESS; > nis_error status; > directory_obj *obj; > - struct timeval now; > - struct timespec ts; > + struct __timespec64 ts; > unsigned int server_used =3D ~0; > unsigned int current_ep =3D ~0; > =20 > @@ -719,12 +718,11 @@ __nisfind_server (const_nis_name name, int > search_parent, if (*dir !=3D NULL) > return NIS_SUCCESS; > =20 > - __clock_gettime (CLOCK_REALTIME, &ts); > - TIMESPEC_TO_TIMEVAL (&now, &ts); > + __clock_gettime64 (CLOCK_REALTIME, &ts); > =20 > if ((flags & NO_CACHE) =3D=3D 0) > *dir =3D nis_server_cache_search (name, search_parent, > &server_used, > - ¤t_ep, &now); > + ¤t_ep, &ts); > if (*dir !=3D NULL) > { > unsigned int server_len =3D (*dir)->do_servers.do_servers_len; > @@ -783,7 +781,7 @@ __nisfind_server (const_nis_name name, int > search_parent, } > if ((flags & NO_CACHE) =3D=3D 0) > nis_server_cache_add (name, search_parent, obj, > - server_used, current_ep, &now); > + server_used, current_ep, &ts); > } > else > { > diff --git a/sysdeps/generic/hp-timing.h b/sysdeps/generic/hp-timing.h > index e2d7447212..af9d92f7f7 100644 > --- a/sysdeps/generic/hp-timing.h > +++ b/sysdeps/generic/hp-timing.h > @@ -34,8 +34,8 @@ typedef uint64_t hp_timing_t; > vDSO symbol. */ > #define HP_TIMING_NOW(var) \ > ({ \ > - struct timespec tv; > \ > - __clock_gettime (CLOCK_MONOTONIC, &tv); \ > + struct __timespec64 tv; > \ > + __clock_gettime64 (CLOCK_MONOTONIC, &tv); \ > (var) =3D (tv.tv_nsec + UINT64_C(1000000000) * tv.tv_sec); \ > }) > =20 > diff --git a/sysdeps/generic/memusage.h b/sysdeps/generic/memusage.h > index a111864b0b..91e56d24de 100644 > --- a/sysdeps/generic/memusage.h > +++ b/sysdeps/generic/memusage.h > @@ -28,9 +28,9 @@ > #ifndef GETTIME > # define GETTIME(low,high) > \ { > \ > - struct timespec now; > \ > + struct __timespec64 now; > \ uint64_t usecs; > \ > - clock_gettime (CLOCK_REALTIME, &now); > \ > + __clock_gettime64 (CLOCK_REALTIME, &now); > \ usecs =3D (uint64_t)now.tv_nsec / 1000 + > (uint64_t)now.tv_sec * 1000000; \ low =3D usecs & 0xffffffff; > \ high =3D usecs >> > 32; \ diff > --git a/sysdeps/unix/sysv/linux/alpha/osf_gettimeofday.c > b/sysdeps/unix/sysv/linux/alpha/osf_gettimeofday.c index > 8cf5d303f9..5075ae0444 100644 --- > a/sysdeps/unix/sysv/linux/alpha/osf_gettimeofday.c +++ > b/sysdeps/unix/sysv/linux/alpha/osf_gettimeofday.c @@ -35,8 +35,8 @@ > __gettimeofday_tv32 (struct __timeval32 *restrict tv32, void > *restrict tz) if (__glibc_unlikely (tz !=3D 0)) memset (tz, 0, sizeof > (struct timezone));=20 > - struct timespec ts; > - __clock_gettime (CLOCK_REALTIME, &ts); > + struct __timespec64 ts; > + __clock_gettime64 (CLOCK_REALTIME, &ts); > =20 > *tv32 =3D valid_timespec_to_timeval32 (ts); > return 0; > diff --git a/sysdeps/unix/sysv/linux/clock.c > b/sysdeps/unix/sysv/linux/clock.c index 24a8df0cf5..157ae8eb3f 100644 > --- a/sysdeps/unix/sysv/linux/clock.c > +++ b/sysdeps/unix/sysv/linux/clock.c > @@ -23,15 +23,12 @@ > clock_t > clock (void) > { > - struct timespec ts; > + struct __timespec64 ts; > =20 > _Static_assert (CLOCKS_PER_SEC =3D=3D 1000000, > "CLOCKS_PER_SEC should be 1000000"); > =20 > - /* clock_gettime shouldn't fail here since > CLOCK_PROCESS_CPUTIME_ID is > - supported since 2.6.12. Check the return value anyway in case > the kernel > - barfs on us for some reason. */ > - if (__glibc_unlikely (__clock_gettime (CLOCK_PROCESS_CPUTIME_ID, > &ts) !=3D 0)) > + if (__glibc_unlikely (__clock_gettime64 (CLOCK_PROCESS_CPUTIME_ID, > &ts) !=3D 0)) return (clock_t) -1; > =20 > return (ts.tv_sec * CLOCKS_PER_SEC Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/b/KDnmkCKePMg/RiOcGDFvq Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl7EOKgACgkQAR8vZIA0 zr2crwf/Ym6tJaZyP/uC7KCLXz0yw3Y1X21PQuzhodtl6TMXEp4GHwXAYu9cT/1B 6HxwRdHw8I7tQTd7PTc2HXnoqe9EftH9s/f4pD4ROb4RE3/wZ3vpaXM/KivpNPEE OxneEUqePDXnpD5lMHk6JUg1Tq7CuBUIl9Mvt6oENsZ0clMri3puKh6Zp76bXDMF L+zIRW8648JyljP+R8869qre7QzPxTN5elcs+MB3knJwQGuNGAM5zVD821afZ7lE vyCVQXmsTYa9vCZbytcx7VumP5ikIs8hSH8OVtQb0b2EfNe+eH9rINm3Wv4AObIN vUtdDvt8QpQtqQES0GsHocq4H+FzcA== =WMUe -----END PGP SIGNATURE----- --Sig_/b/KDnmkCKePMg/RiOcGDFvq--