From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 408661F619 for ; Mon, 24 Feb 2020 11:13:42 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; q=dns; s=default; b=LyJcr VRhH9Ej4/YRe61GkvFw3/daGH2J6TKS/VKXvgmU2aA3YBOLnugOn+80IDZhStUC6 oDn8Ucd8HocKSji7/NitlDVZWWtTEYTRNbMBIsaN/Zfwsvhq29dLfRAR5bemuD3Z yZyU89OC7/9hqoUDfJPNwzD9O1rVal+QJbFZvo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; s=default; bh=SkLmG11CBHS gTLClRKp4X1ax13w=; b=sNK0x0+uovOAdXug2yY3pQUhQi/Rvj3HlGH3LFLtscB qTVZH2Vgl0YTMY+oa7pn1AJaatNXvjberxoygojsJHMDjZbxyDslegzb0gg5Rcgh jQLJzj5Cwca4QllsnmAFeqGPGQxEALPG5X4099ve4vMrB+BjFha9806yElX7kd/Y = Received: (qmail 121291 invoked by alias); 24 Feb 2020 11:13:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 121280 invoked by uid 89); 24 Feb 2020 11:13:39 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-out.m-online.net Date: Mon, 24 Feb 2020 12:13:25 +0100 From: Lukasz Majewski To: Andreas Schwab Cc: Arnd Bergmann , Florian Weimer , Helmut Grohne , GNU C Library , Vineet Gupta , Palmer Dabbelt , Zong Li , debian-arm@lists.debian.org, Alistair Francis , Adhemerval Zanella , "Maciej W. Rozycki" , Alistair Francis , arcml , Joseph Myers Subject: Re: switching ARC to 64-bit time_t (Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64) Message-ID: <20200224121325.6b2fff1d@jawa> In-Reply-To: References: <4e95f95966d8d7c6a8339160dc62d81c1f6a1bfb.1578824547.git.alistair.francis@wdc.com> <00574bfb-981a-3a1c-cbdf-b2fee4eddc32@gmail.com> <8a9784b3-fc52-adc3-4595-33142b059388@synopsys.com> <20200220001136.2f14236e@jawa> <20200220103716.2f526933@jawa> <20200224100051.2511d797@jawa> <20200224111424.33759b2e@jawa> <20200224113658.275ea702@jawa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/PTW+25ccp9eC8BV.Ulfvvg."; protocol="application/pgp-signature" --Sig_/PTW+25ccp9eC8BV.Ulfvvg. Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 24 Feb 2020 11:42:23 +0100 Andreas Schwab wrote: > On Feb 24 2020, Lukasz Majewski wrote: >=20 > > On Mon, 24 Feb 2020 11:23:51 +0100 > > Andreas Schwab wrote: > > =20 > >> On Feb 24 2020, Lukasz Majewski wrote: > >> =20 > >> > If I add those functions as hidden_alias then those would be > >> > accessible inside glibc without PLT, but will not be exported > >> > (and redirection for Y2038 will not work). =20 > >>=20 > >> They aren't? PLT avoidance is about internal references, and uses > >> a different name then the exported sybmol. > >> =20 > > > > I'm probably not aware of something - but as done in the following > > patch: > > > > https://github.com/lmajewski/y2038_glibc/commit/c96eeb73175961c4ac80fdd= 3b6adc132805387c9 > > > > I do need to remove librt_hidden_proto / librt_hidden_def to have > > proper symbols visible when I do want to use redirections. =20 >=20 > You cannot redirect to GLIBC_PRIVATE symbols, they are not suposed to > be used by public interfaces. All public interfaces need to use > official versioned symbols. >=20 I've put those symbols to GLIBC_PRIVATE as up till now many more functions in glibc needs conversion to support 64 bit time. I need exported symbols to test if the redirection (and Y2038 safeness on ARM in general) works. I also do guess that when we will be heading to expose _TIME_BITS=3D=3D64 to outside word I would need to add: GLIBC_2.3X { clock_settime64; } for clock_settime64 and then: #ifdef __USE_TIME_BITS64 # if defined(__REDIRECT_NTH) extern int __REDIRECT_NTH (clock_settime, (clockid_t __clock_id, const struct timespec *__tp), clock_settime64); # else # define clock_settime clock_settime64 # endif #endif Am I correct ? > Andreas. >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/PTW+25ccp9eC8BV.Ulfvvg. Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl5Tr9UACgkQAR8vZIA0 zr3HHAf8DtyF7PEe/85wGYmHN1h+NFvCcUppBJskMb5iqslZrfiIhSMF4Clxcq3s wf76ZTXYrVXIC+VHrce4XFwQlBSC9sxMpARhTdCItilS/3bH416laMdvSXNmrYpe R2wzowKPzjCTDOYFANVHs9b0VkR3smxU6IMaGvxpZxMEU79+WjHPsDnEdjHIKo5n mAOvDjNz7rbeCCHEA/QtHj/z2tWLVpBGjvMsopjhOuwv8QWbcaKwhE9XdszcXscY SIYh7iXFjTnkiV7R3V/evVEDY2VNUoo3SW3VQ8C/W3CyUbGgFPGyEl98XTZofTt+ mCUglzkbnXy0Isb/jJrv0wgVzOAKNA== =WMBc -----END PGP SIGNATURE----- --Sig_/PTW+25ccp9eC8BV.Ulfvvg.--