From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D39571F46C for ; Tue, 21 Jan 2020 21:29:00 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=RnJf qm0SIcTdauMj5Jx7xSaxRaATv6/JiDYOumCZrhfuhEn+duyZoE7kmw4ebRfcCd4Y 1i0wDwsvx1Yzf2WYop30I+z7JxEQHuoG/S0biCXzqt4+v46sHpcB44DRgkW9KgzV JqQlOFGw0GK6XCUvWzJ0PWSKLq6IcfVxRG9d+yI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=AAV4y13htF XkXx/pi4RHDXGWRNo=; b=r2/MEaetBHbY8Ea0EKNq7UuLjjpEA7wzPD772RxUsk MUrgoxjM/HWQeKQHDJouoHdxMsdXpQoU/PycAP8Y4lgpiOM2JrJHAJufCdUfkXy6 gNylVMiq2u2kGspI3DOxCQS81I+9iZGnQDBQFDCVuq+Skr3keb+g3aB+48Kzz0Ul 4= Received: (qmail 96410 invoked by alias); 21 Jan 2020 21:28:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 96399 invoked by uid 89); 21 Jan 2020 21:28:58 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: hera.aquilenet.fr Date: Tue, 21 Jan 2020 22:28:50 +0100 From: Samuel Thibault To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 01/10] htl: Rename _pthread_mutex_init/destroy to __pthread_mutex_init/destroy Message-ID: <20200121212850.ufsmja7evi3bhwjx@function> References: <20200114185255.25813-1-samuel.thibault@ens-lyon.org> <20200114185255.25813-3-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Hello, Adhemerval Zanella, le ven. 17 janv. 2020 17:40:09 -0300, a ecrit: > > diff --git a/sysdeps/mach/hurd/i386/libpthread.abilist b/sysdeps/mach/hurd/i386/libpthread.abilist > > index 0ede90859c..cda8755960 100644 > > --- a/sysdeps/mach/hurd/i386/libpthread.abilist > > +++ b/sysdeps/mach/hurd/i386/libpthread.abilist > > @@ -14,8 +14,6 @@ GLIBC_2.12 _cthread_init_routine D 0x4 > > GLIBC_2.12 _cthreads_flockfile F > > GLIBC_2.12 _cthreads_ftrylockfile F > > GLIBC_2.12 _cthreads_funlockfile F > > -GLIBC_2.12 _pthread_mutex_destroy F > > -GLIBC_2.12 _pthread_mutex_init F > > GLIBC_2.12 _pthread_mutex_lock F > > GLIBC_2.12 _pthread_mutex_trylock F > > GLIBC_2.12 _pthread_mutex_unlock F > > I understand this change is follow Linux internal implementation > and make mtx_init.c generic, but I don't think changing hurd > libpthread exported symbols is the correct solution. > > Since the symbol won't be used anymore I think we can move to > a compat symbol, something like: > > +strong_alias (__pthread_mutex_init, pthread_mutex_init); > +hidden_def (__pthread_mutex_init) > +#if SHLIB_COMPAT (libpthread, GLIBC_2_12, GLIBC_2_31) > +compat_symbol (libpthread, __pthread_mutex_init, _pthread_mutex_init, GLIBC_2_12); > +#endif But do we need to keep the compat symbols at all? _pthread_mutex_lock has never been exposed in a .h file, it should have gotten version GLIBC_PRIVATE actually since it's only used between libc.so and libpthread.so. Samuel