From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A8E801F463 for ; Tue, 17 Dec 2019 21:50:04 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=bTwGiB+/KGTlg4TKCJDjkQLGJtv+Ywb Vg/UljveyyFLRJanCFMpyIPGLYBYeCdx+9Y93ANipQ9JTitSaPLI2ZcGaopOdRFo 6qLcnJ/8EC+d8iIPtj+xE1zHDY6pdQdALrQhR74Iv99AN8Nq5LLqY3yv+ue785QO 2ior3OpqEvGw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=nWhrlHpJkWRQuIfMax4pY1zjrUE=; b=uynRw MmBXxqujuYjwJwDYVdnMDWi1II63iNMdaYDUSzKzfVFa0yQHxsRuxKMAw7/RxTwN fSBEJ9qvUA3x419k8OQBbgvt2Of+iG0YwROegLtumqi2WS0oy7g6H8V0e6FTGxcP ZOHFTrERMnxM3ESRKBCbkQqn1K0JeH9Y3H8wD0= Received: (qmail 112794 invoked by alias); 17 Dec 2019 21:48:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 112106 invoked by uid 89); 17 Dec 2019 21:48:00 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-pj1-f65.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=EbVlLte6cM3D+rEIFJmkDeBnjV3lHOp6fJKNaMCCY8s=; b=Fwkmz7HYFhKXJpiNY5gDRdsMRBfSO6Vxg33ZvHf8KH9JMqBL3t/RgbMc8FL176NbCg MKSDluHrcdJ1u18KPFaz8mQzTit0AbWo/4hQwz1yu2mO9+81gFIaMyF5t178sEymojWo 2ud2BJNZ/ibu+w3WRfdE0PQiMIbFv16NPGNuhEUYFLyOPgVdgIny3lyPM5VlTlKINPsG UZHC7gipe3XOU3AXnamIZE4qAl6WTLtoAKTpGWPQ0Ua5wn4P3fLMdkT9YHy+DfQSj5ub xnU/kuKrpGgCFIfPekWP66WgMfAN5Vsr33KKigZUnf38lrhUtEG1+9rFPphgXJwMhmA7 w3FQ== From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 16/16] linux: Optimize fallback 32-bit clock_getres Date: Tue, 17 Dec 2019 18:47:28 -0300 Message-Id: <20191217214728.2886-16-adhemerval.zanella@linaro.org> In-Reply-To: <20191217214728.2886-1-adhemerval.zanella@linaro.org> References: <20191217214728.2886-1-adhemerval.zanella@linaro.org> This patch avoid probing the __NR_clock_getttime64 syscall each time __clock_gettime64 is issued on a kernel without 64 bit time support. Once ENOSYS is obtained, only 32-bit clock_gettime are used. The following snippet: clock_getres (CLOCK_REALTIME, &(struct timespec) { 0 }); clock_getres (CLOCK_MONOTONIC, &(struct timespec) { 0 }); clock_getres (CLOCK_BOOTTIME, &(struct timespec) { 0 }); clock_getres (20, &(struct timespec) { 0 }); On a kernel without 64 bit time support issues the syscalls: syscall_0x196(0, 0xffb83330, [...]) = -1 ENOSYS (Function not implemented) clock_getres(CLOCK_REALTIME, {tv_sec=0, tv_nsec=1}) = 0 clock_getres(CLOCK_MONOTONIC, {tv_sec=0, tv_nsec=1}) = 0 clock_getres(CLOCK_BOOTTIME, {tv_sec=0, tv_nsec=1}) = 0 Checked on i686-linux-gnu on 4.15 kernel. --- sysdeps/unix/sysv/linux/clock_getres.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/sysdeps/unix/sysv/linux/clock_getres.c b/sysdeps/unix/sysv/linux/clock_getres.c index 3d59f11d71..c1e1cf60c6 100644 --- a/sysdeps/unix/sysv/linux/clock_getres.c +++ b/sysdeps/unix/sysv/linux/clock_getres.c @@ -42,13 +42,21 @@ __clock_getres64 (clockid_t clock_id, struct __timespec64 *res) int r; /* Old 32-bit ABI with possible 64-bit time_t support. */ # ifdef __NR_clock_getres_time64 + /* Avoid issue a __NR_clock_getres_time64 syscall on kernels that do not + support 64-bit time_t. */ + static int time64_support = 1; + if (atomic_load_relaxed (&time64_support) == 1) + { # ifdef HAVE_CLOCK_GETRES64_VSYSCALL - r = INLINE_VSYSCALL (clock_getres_time64, 2, clock_id, res); + r = INLINE_VSYSCALL (clock_getres_time64, 2, clock_id, res); # else - r = INLINE_SYSCALL_CALL (clock_getres_time64, clock_id, res); + r = INLINE_SYSCALL_CALL (clock_getres_time64, clock_id, res); # endif - if (r == 0 || errno != ENOSYS) - return r; + if (r == 0 || errno != ENOSYS) + return r; + + atomic_store_relaxed (&time64_support, 0); + } # endif /* Fallback code that uses 32-bit support. */ struct timespec ts32; -- 2.17.1