From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AD3671F463 for ; Wed, 27 Nov 2019 17:04:44 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; q=dns; s=default; b=dkFQj YFXp51EfQSRQE/3eN0lm5KDbmqzcv6xTaBmiUmwBmdE5sxcVzmyuOBlMsOSsI/kz WLitqfGmZcKWrd/PBXQKkB5P8BIrFcsOsHfprY58QcYPrmNUuOFN7e29ktqsbDov 6TZ1cfcq0RYnoP+Y9jE034fAllmaacz/R+oHP4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; s=default; bh=RnU2B10lJZm A+bdzggaGmVp81Wo=; b=MHRHXkIDzJP99/yPQ6cV1xD5fa74o5hlqKeM+tynwrD LrHpRLZMcVyRnyHPLRcWqPf0cB0yaPf7HzZknkYupkT/IYYtrHZG6iBKZjyXMSZu ux/t8ZGJVAx6KijpEPI3OaTNp1idkcSJ2hnPjncfioGw1tTRSUk8qEYsHbFAYdOo = Received: (qmail 79291 invoked by alias); 27 Nov 2019 17:04:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 79279 invoked by uid 89); 27 Nov 2019 17:04:42 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-out.m-online.net Date: Wed, 27 Nov 2019 18:04:36 +0100 From: Lukasz Majewski To: Joseph Myers , Paul Eggert Cc: Alistair Francis , Alistair Francis , GNU C Library , Adhemerval Zanella , Florian Weimer , Florian Weimer , Zack Weinberg , Carlos O'Donell Subject: Re: [PATCH 1/2] linux: clock_settime: Remove check for nanoseconds validity Message-ID: <20191127180436.0e83a744@jawa> In-Reply-To: <20191111164531.1411bd48@jawa> References: <20191108153344.10949-1-lukma@denx.de> <20191111164531.1411bd48@jawa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/jh_s9ZLDpU+bR.CX03qK+G9"; protocol="application/pgp-signature" --Sig_/jh_s9ZLDpU+bR.CX03qK+G9 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Dear Joseph, Paul, > Dear Joseph, Paul, >=20 > > The check if passed nanoseconds via struct __timespec64's *tp > > pointer is also performed in the Linux kernel. Remove it from glibc > > to avoid duplication. > > --- > > sysdeps/unix/sysv/linux/clock_settime.c | 7 ------- > > 1 file changed, 7 deletions(-) > >=20 > > diff --git a/sysdeps/unix/sysv/linux/clock_settime.c > > b/sysdeps/unix/sysv/linux/clock_settime.c index > > bda113809b..6706dbb31f 100644 --- > > a/sysdeps/unix/sysv/linux/clock_settime.c +++ > > b/sysdeps/unix/sysv/linux/clock_settime.c @@ -25,13 +25,6 @@ > > int > > __clock_settime64 (clockid_t clock_id, const struct __timespec64 > > *tp) { > > - /* Make sure the time cvalue is OK. */ > > - if (! valid_nanoseconds (tp->tv_nsec)) > > - { > > - __set_errno (EINVAL); > > - return -1; > > - } > > - =20 >=20 > I'm just wondering if this patch is OK, as with other patches, which=20 > convert time to use 64 bit syscalls we do rely on Linux kernel to > check the nanoseconds (and return proper error). Are there any comments regarding this patch? >=20 > > #ifdef __ASSUME_TIME64_SYSCALLS > > # ifndef __NR_clock_settime64 > > # define __NR_clock_settime64 __NR_clock_settime =20 >=20 >=20 >=20 >=20 > Best regards, >=20 > Lukasz Majewski >=20 > -- >=20 > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > lukma@denx.de Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/jh_s9ZLDpU+bR.CX03qK+G9 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl3erKQACgkQAR8vZIA0 zr3F7Af8Dhqf2tNcUUg6u8ld41jAJmwuUzUhYVFBWCY62b9Mb32J/Bx/Fu1G4LMW v9LfKNtKwVKmkCicU0/t/HAXdjI8tOLTmKKeKaJq2FaXMwHUtA7EksMbDGfX6wgX HYiin5mC1w/gwNTlW1vZCwI68nk4xhFx5IDGpSeZC0SwqPX1+kX/5lRuuDVSHLp+ 6acrbxG8YNHvmIweCguv8i/WmrHMlgrAvFEzASoLwJ/V6TMkNn7QBI4FuiIvI+bT 2ipO+SSt9dcoJT43j9SaoBCtSfZrUjgtAFVGlftg64igOpoifQvpHDFluw/I0Kyk t1F22vPz0SS6dPVP5jcsJh5vDR/A9Q== =bx9P -----END PGP SIGNATURE----- --Sig_/jh_s9ZLDpU+bR.CX03qK+G9--