* [review] linux: Add comment on affinity set sizes to tst-skeleton-affinity.c
@ 2019-11-11 9:49 Florian Weimer (Code Review)
2019-11-15 12:03 ` [review v2] " Szabolcs Nagy (Code Review)
2019-11-15 12:30 ` [pushed] " Sourceware to Gerrit sync (Code Review)
0 siblings, 2 replies; 3+ messages in thread
From: Florian Weimer (Code Review) @ 2019-11-11 9:49 UTC (permalink / raw)
To: libc-alpha; +Cc: Florian Weimer
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/610
......................................................................
linux: Add comment on affinity set sizes to tst-skeleton-affinity.c
Change-Id: Ic6ec48f75f3a0576d3121befd04531382c92afb4
---
M sysdeps/unix/sysv/linux/tst-skeleton-affinity.c
1 file changed, 5 insertions(+), 0 deletions(-)
diff --git a/sysdeps/unix/sysv/linux/tst-skeleton-affinity.c b/sysdeps/unix/sysv/linux/tst-skeleton-affinity.c
index 32fb94c..9d1f27f 100644
--- a/sysdeps/unix/sysv/linux/tst-skeleton-affinity.c
+++ b/sysdeps/unix/sysv/linux/tst-skeleton-affinity.c
@@ -264,6 +264,11 @@
struct conf conf;
setup_conf (&conf);
+ /* Note: The CPU set size in bits can be less than the CPU count
+ (and the maximum test CPU) because the userspace interface rounds
+ up the bit count, and the rounded-up buffer size is passed into
+ the kernel. The kernel does not know that some of the buffer are
+ actually padding, and writes data there. */
printf ("info: Detected CPU set size (in bits): %d\n", conf.set_size);
printf ("info: Maximum test CPU: %d\n", conf.last_cpu);
if (conf.set_size < 0 || conf.last_cpu < 0)
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Ic6ec48f75f3a0576d3121befd04531382c92afb4
Gerrit-Change-Number: 610
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-MessageType: newchange
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [review v2] linux: Add comment on affinity set sizes to tst-skeleton-affinity.c
2019-11-11 9:49 [review] linux: Add comment on affinity set sizes to tst-skeleton-affinity.c Florian Weimer (Code Review)
@ 2019-11-15 12:03 ` Szabolcs Nagy (Code Review)
2019-11-15 12:30 ` [pushed] " Sourceware to Gerrit sync (Code Review)
1 sibling, 0 replies; 3+ messages in thread
From: Szabolcs Nagy (Code Review) @ 2019-11-15 12:03 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
Szabolcs Nagy has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/610
......................................................................
Patch Set 2: Code-Review+2
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Ic6ec48f75f3a0576d3121befd04531382c92afb4
Gerrit-Change-Number: 610
Gerrit-PatchSet: 2
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Szabolcs Nagy <szabolcs.nagy@arm.com>
Gerrit-Comment-Date: Fri, 15 Nov 2019 12:03:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pushed] linux: Add comment on affinity set sizes to tst-skeleton-affinity.c
2019-11-11 9:49 [review] linux: Add comment on affinity set sizes to tst-skeleton-affinity.c Florian Weimer (Code Review)
2019-11-15 12:03 ` [review v2] " Szabolcs Nagy (Code Review)
@ 2019-11-15 12:30 ` Sourceware to Gerrit sync (Code Review)
1 sibling, 0 replies; 3+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-15 12:30 UTC (permalink / raw)
To: Florian Weimer, libc-alpha; +Cc: Szabolcs Nagy
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/610
......................................................................
linux: Add comment on affinity set sizes to tst-skeleton-affinity.c
Change-Id: Ic6ec48f75f3a0576d3121befd04531382c92afb4
---
M sysdeps/unix/sysv/linux/tst-skeleton-affinity.c
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Szabolcs Nagy: Looks good to me, approved
diff --git a/sysdeps/unix/sysv/linux/tst-skeleton-affinity.c b/sysdeps/unix/sysv/linux/tst-skeleton-affinity.c
index 32fb94c..9d1f27f 100644
--- a/sysdeps/unix/sysv/linux/tst-skeleton-affinity.c
+++ b/sysdeps/unix/sysv/linux/tst-skeleton-affinity.c
@@ -264,6 +264,11 @@
struct conf conf;
setup_conf (&conf);
+ /* Note: The CPU set size in bits can be less than the CPU count
+ (and the maximum test CPU) because the userspace interface rounds
+ up the bit count, and the rounded-up buffer size is passed into
+ the kernel. The kernel does not know that some of the buffer are
+ actually padding, and writes data there. */
printf ("info: Detected CPU set size (in bits): %d\n", conf.set_size);
printf ("info: Maximum test CPU: %d\n", conf.last_cpu);
if (conf.set_size < 0 || conf.last_cpu < 0)
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Ic6ec48f75f3a0576d3121befd04531382c92afb4
Gerrit-Change-Number: 610
Gerrit-PatchSet: 3
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Szabolcs Nagy <szabolcs.nagy@arm.com>
Gerrit-MessageType: merged
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-15 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 9:49 [review] linux: Add comment on affinity set sizes to tst-skeleton-affinity.c Florian Weimer (Code Review)
2019-11-15 12:03 ` [review v2] " Szabolcs Nagy (Code Review)
2019-11-15 12:30 ` [pushed] " Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).