[review] nptl: Cleanup mutex internal offset tests

["Florian Weimer (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Florian Weimer has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/581
......................................................................


Patch Set 1:

(5 comments)

I ran this through a full build-many-glibcs.py run, and the results look good.

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,18 @@ 
| +Parent:     31f000a8 (Remove hppa pthreadP.h)
| +Author:     Adhemerval Zanella <adhemerval.zanella@linaro.org>
| +AuthorDate: 2019-11-07 20:58:41 +0000
| +Commit:     Adhemerval Zanella <adhemerval.zanella@linaro.org>
| +CommitDate: 2019-11-08 16:41:53 -0300
| +
| +nptl: Cleanup mutex internal offset tests
| +
| +The offset of pthread_mutex_t __data.__nusers, __data.__spins,

PS1, Line 9:

“offsets” (I think)

| +__data.elision, __data.list are not required to be constant over
| +the releases.  Only the __data.__flags are used for static
| +initializers.

PS1, Line 12:

“Only __data.__kind is used for static initializers.”

| +
| +This patch also adds an additional size check for __data.__flags.

PS1, Line 14:

__data.__kind

| +
| +Check with a build against affected abis.

PS1, Line 16:

“Checked with a build against affected ABIs.”?

| +
| +Change-Id: I7a4e48cc91b4c4ada57e9a5d1b151fb702bfaa9f
| --- nptl/pthread_mutex_init.c
| +++ nptl/pthread_mutex_init.c
| @@ -51,17 +51,11 @@ int
|  __pthread_mutex_init (pthread_mutex_t *mutex,
|  		      const pthread_mutexattr_t *mutexattr)
|  {
|    const struct pthread_mutexattr *imutexattr;
|  
|    ASSERT_TYPE_SIZE (pthread_mutex_t, __SIZEOF_PTHREAD_MUTEX_T);
|  
| -  ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_mutex_t, __data.__nusers,
| -				  __PTHREAD_MUTEX_NUSERS_OFFSET);
| +  /* The __flags is the only field where its offset should be checked to

PS1, Line 58:

Probably: /* __kind is the only field
(without the definite article, and fixed field name).

| +     avoid ABI breakage with static initializers.  */
|    ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_mutex_t, __data.__kind,
|  				  __PTHREAD_MUTEX_KIND_OFFSET);
| -  ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_mutex_t, __data.__spins,
| -				  __PTHREAD_MUTEX_SPINS_OFFSET);
| -#if __PTHREAD_MUTEX_LOCK_ELISION
| -  ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_mutex_t, __data.__elision,
| -				  __PTHREAD_MUTEX_ELISION_OFFSET);
| -#endif

-- 
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I7a4e48cc91b4c4ada57e9a5d1b151fb702bfaa9f
Gerrit-Change-Number: 581
Gerrit-PatchSet: 1
Gerrit-Owner: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Gerrit-CC: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Thu, 14 Nov 2019 14:34:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment