* [review] nios2: Work around backend bug triggered by csu/libc-tls.c (GCC PR 92...
[not found] <gerrit.1573663739000.If5df5b05d15f0418af821a9ac8cc0fad53437b10@gnutoolchain-gerrit.osci.io>
@ 2019-11-13 16:50 ` Florian Weimer (Code Review)
2019-11-14 9:54 ` Chung-Lin Tang (Code Review)
2019-11-14 11:50 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 3+ messages in thread
From: Florian Weimer (Code Review) @ 2019-11-13 16:50 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/624
......................................................................
Patch Set 1:
This change is ready for review.
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: If5df5b05d15f0418af821a9ac8cc0fad53437b10
Gerrit-Change-Number: 624
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Wed, 13 Nov 2019 16:50:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 3+ messages in thread
* [review] nios2: Work around backend bug triggered by csu/libc-tls.c (GCC PR 92...
[not found] <gerrit.1573663739000.If5df5b05d15f0418af821a9ac8cc0fad53437b10@gnutoolchain-gerrit.osci.io>
2019-11-13 16:50 ` [review] nios2: Work around backend bug triggered by csu/libc-tls.c (GCC PR 92 Florian Weimer (Code Review)
@ 2019-11-14 9:54 ` Chung-Lin Tang (Code Review)
2019-11-14 11:50 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 3+ messages in thread
From: Chung-Lin Tang (Code Review) @ 2019-11-14 9:54 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
Chung-Lin Tang has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/624
......................................................................
Patch Set 1:
This is okay, thanks for making the fix.
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: If5df5b05d15f0418af821a9ac8cc0fad53437b10
Gerrit-Change-Number: 624
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-CC: Chung-Lin Tang <chunglin.tang@gmail.com>
Gerrit-Comment-Date: Thu, 14 Nov 2019 09:54:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pushed] nios2: Work around backend bug triggered by csu/libc-tls.c (GCC PR 92...
[not found] <gerrit.1573663739000.If5df5b05d15f0418af821a9ac8cc0fad53437b10@gnutoolchain-gerrit.osci.io>
2019-11-13 16:50 ` [review] nios2: Work around backend bug triggered by csu/libc-tls.c (GCC PR 92 Florian Weimer (Code Review)
2019-11-14 9:54 ` Chung-Lin Tang (Code Review)
@ 2019-11-14 11:50 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 3+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-14 11:50 UTC (permalink / raw)
To: Florian Weimer, libc-alpha; +Cc: Chung-Lin Tang
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/624
......................................................................
nios2: Work around backend bug triggered by csu/libc-tls.c (GCC PR 92499)
Change-Id: If5df5b05d15f0418af821a9ac8cc0fad53437b10
---
M sysdeps/unix/sysv/linux/nios2/Makefile
1 file changed, 9 insertions(+), 0 deletions(-)
diff --git a/sysdeps/unix/sysv/linux/nios2/Makefile b/sysdeps/unix/sysv/linux/nios2/Makefile
index 5688a16..9342e45 100644
--- a/sysdeps/unix/sysv/linux/nios2/Makefile
+++ b/sysdeps/unix/sysv/linux/nios2/Makefile
@@ -7,3 +7,12 @@
sysdep_headers += sys/cachectl.h
sysdep_routines += cacheflush
endif
+
+ifeq ($(subdir),csu)
+# Work around an incorrect assumption that an object of variably
+# modified type, with a small fixed size but a large variable-sized
+# part (the static_slotinfo variable in libc-tls.c) is allocated in
+# the small data section, not the data section where it belongs based
+# on its size. See GCC PR 92499.
+CFLAGS-libc-tls.c += -mgpopt=none
+endif
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: If5df5b05d15f0418af821a9ac8cc0fad53437b10
Gerrit-Change-Number: 624
Gerrit-PatchSet: 2
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-CC: Chung-Lin Tang <chunglin.tang@gmail.com>
Gerrit-MessageType: merged
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-14 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <gerrit.1573663739000.If5df5b05d15f0418af821a9ac8cc0fad53437b10@gnutoolchain-gerrit.osci.io>
2019-11-13 16:50 ` [review] nios2: Work around backend bug triggered by csu/libc-tls.c (GCC PR 92 Florian Weimer (Code Review)
2019-11-14 9:54 ` Chung-Lin Tang (Code Review)
2019-11-14 11:50 ` [pushed] " Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).