From: "Florian Weimer (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>
Subject: [review v2] nptl: Add default pthread-offsets.h
Date: Thu, 14 Nov 2019 06:31:38 -0500 [thread overview]
Message-ID: <20191114113139.041C920AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573136666000.I7785a9581e651feb80d1413b9e03b5ac0452668a@gnutoolchain-gerrit.osci.io>
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/521
......................................................................
Patch Set 2:
(2 comments)
Looks okay, except for nits in the commit message.
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,15 @@
| +Parent: dcffe302 (nptl: Add default pthreadtypes-arch.h)
| +Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
| +AuthorDate: 2017-11-14 19:10:38 -0200
| +Commit: Adhemerval Zanella <adhemerval.zanella@linaro.org>
| +CommitDate: 2019-11-08 16:43:16 -0300
| +
| +nptl: Add default pthread-offsets.h
| +
| +This patch adds a default pthread-offsets.h based on default
| +thread definitions from mutex-internal.h and rwlock-internal.h.
PS2, Line 10:
Header names are outdated.
| +The idea is to simpify new ports inclusion.
PS2, Line 11:
simplify
| +
| +Checked with a build on affected abis.
| +
| +Change-Id: I7785a9581e651feb80d1413b9e03b5ac0452668a
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I7785a9581e651feb80d1413b9e03b5ac0452668a
Gerrit-Change-Number: 521
Gerrit-PatchSet: 2
Gerrit-Owner: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Gerrit-CC: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Thu, 14 Nov 2019 11:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-14 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 14:24 [review] nptl: Add default pthread-offsets.h Adhemerval Zanella (Code Review)
2019-11-08 19:43 ` [review v2] " Adhemerval Zanella (Code Review)
2019-11-14 11:31 ` Florian Weimer (Code Review) [this message]
2019-11-20 14:49 ` Adhemerval Zanella (Code Review)
2019-11-20 14:51 ` [review v3] " Adhemerval Zanella (Code Review)
2019-11-22 11:09 ` Florian Weimer (Code Review)
2019-11-26 14:20 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114113139.041C920AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=gnutoolchain-gerrit@osci.io \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).