From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A82871F4B5 for ; Tue, 12 Nov 2019 20:08:45 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=G2MI 94PNSKKKmmjXR/iemnFCKfNPY+cllY/xgW6TKgnGfBdkq1J5HuQp3Lw2wN7Bnd3O etDKYp6GJ5NbXCrFfr+URIEIcSsdUcPFcRo+I5KqlAXXPXqSDwehAvQ19pQugrtD ZaCpLvRnyPNfQWn8sSUIouzZ+mDhq1ZD1cX7JGE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=Aw5lnScLAi Tngubq9lVWuHTMvmo=; b=qDAxZeKBPR7LEOfAIh4j85bX5uSCyKLg/sjUFG7JE/ C6JWk9Agiltajf0TVGp2ZPFK4r7P702PL7WL6R+vdVv3DPRe7NuvIN4PfoJR3wYs omJx+6i8HQYnxqTd/kdi10qWxd1Psvnlj5b63Qr6fmdiS5cw2spGF4HM4RqSAEPs g= Received: (qmail 109437 invoked by alias); 12 Nov 2019 20:08:43 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 109427 invoked by uid 89); 12 Nov 2019 20:08:43 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-pl1-f170.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cDeog5thwe31c4Og84mpYERA7Nez58h6VkJgCJ+gqOk=; b=XTy+GHrE5SkeFFlolZRy6MODwIHqz5ntjzHJ923tzrPG6rD5s3Dg0eH5rCZzIZDSgJ gN6p3XDheiA4qk4k/Q7wFD237YsK5Uk7KNXvqiY3f2qNstaoi9bRg3Z4JA+lK/cv97K+ yjNu+nfLMbWGnfkeYJ90NM4KNzx6aHcIvhBdbuO0pAySv8KNXW+yheXdvvB0BoR78v/u ZXotJ5r5D+ffelhQ616mf6kfkRYn3DQvvzjzLOMp4MJeGanfPa73X/zNozStRWKgRtok FV2+MrEQyqNylkezMZaU01KRH1LXkHDopBguxZ1/urM2dzGlktbdRHFwpXC3+PEWjI+c mcwQ== Date: Tue, 12 Nov 2019 12:08:37 -0800 From: Jonathan Nieder To: Florian Weimer Cc: Carlos O'Donell , libc-alpha Subject: Re: How to keep Reviewed-by lines in git commits with gerrit. Message-ID: <20191112200837.GC25693@google.com> References: <7b4aa5d2-14e7-c0aa-a258-bbd60455fae5@redhat.com> <87lfskgbgw.fsf@mid.deneb.enyo.de> <593d3aac-c38e-4d01-2652-41ec5442d062@redhat.com> <87h838ga00.fsf@mid.deneb.enyo.de> <20191112195939.GA25693@google.com> <8736esg8wq.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8736esg8wq.fsf@mid.deneb.enyo.de> User-Agent: Mutt/1.10.1 (2018-07-13) Florian Weimer wrote: > * Jonathan Nieder: >>>> I would prefer it to be automatically added by the review tool, as >>>> gerrit is designed to do. >>> >>> Is it? >> >> The Cherry Pick and Rebase Always submit strategies[1] automatically >> add Reviewed-by footers. >> >> Other submit strategies (like Merge If Necessary) are designed to not >> touch the change uploader's commit (e.g. they may have signed it) so >> they don't add the footer. > >> [1] >> https://gerrit-review.googlesource.com/Documentation/concept-changes.html#submit-strategies > > I'm confused. Is it expected that these changes are not visible in > the commits I can download (under the DOWNLOAD button) or in the web > UI? Are they added only during the push? They are added at submit time, after the review. At that point, they show up as one final patch set. See https://chromium-review.googlesource.com/c/chromium/src/+/1900995 for an example. (The Cr-Commit-Position comes from a chromium-specific plugin.) You can use https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#submit-preview to preview it, though that's a bit fussy.