From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2AE8E1F4B5 for ; Tue, 12 Nov 2019 17:24:48 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; q=dns; s=default; b=xC0as1KaEOc3YHQVR+D6ENKpH7BjXPC RInr3MJgqtiKCUCuPK8w/T8FEbD/TxCLt6cJiA2JS8MHHrz0Hn4wCZ5mMW+Idd8m sNI04rreTeweIKvTxF27CNaLNlGI+a/G7l1icStxnvPfNKHCXk3z/kNKpFqyZB+8 9qN8LyYzgdbw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; s=default; bh=VoQ36N+wQsTVokUelDJMyoATCig=; b=l+QqH kbyNQPW3J41/IzQLLQhun8eqicRBPeMdXh1XNvyP6XfnTFFwXaO9Bq1To12wHC/6 4l+LAjsAuMwYNm5iiQ99V1GaM1pBcgGN/4L+Zbu4phvZ89giy6i8MTAEAuhPaHB8 Vgfk8K/lr/dJS6QaxUji3AeYyl+dequ8SXFgRA= Received: (qmail 36353 invoked by alias); 12 Nov 2019 17:24:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 36338 invoked by uid 89); 12 Nov 2019 17:24:45 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.osci.io X-Gerrit-PatchSet: 2 Date: Tue, 12 Nov 2019 12:24:39 -0500 From: "Carlos O'Donell (Code Review)" To: Florian Weimer , libc-alpha@sourceware.org Cc: "Gabriel F. T. Gomes" Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Clarify purpose of assert in _dl_lookup_symbol_x X-Gerrit-Change-Id: I3384349cef90cfd91862ebc34a4053f0c0a99404 X-Gerrit-Change-Number: 469 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6f486dd93b0d74dfadbfe4a1c15730dd15ba526c In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 12 Nov 2019 12:24:39 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191112172439.84DBE20AF6@gnutoolchain-gerrit.osci.io> Carlos O'Donell has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/469 ...................................................................... Patch Set 2: > Patch Set 2: > > (1 comment) > > I've added you to the glibc-maintainers group, so you can give +2 now as well. > > (I'm not sure if we can keep up the practice of adding Reviewed-By: lines with Gerrit, because doing so creates a new patch version that needs review.) Reviewed-By: lines are important for my yearly metrics to see how we as a community are growing and who is reviewing and thanking them. Let me try something. -- Gerrit-Project: glibc Gerrit-Branch: master Gerrit-Change-Id: I3384349cef90cfd91862ebc34a4053f0c0a99404 Gerrit-Change-Number: 469 Gerrit-PatchSet: 2 Gerrit-Owner: Florian Weimer Gerrit-Reviewer: Florian Weimer Gerrit-Reviewer: Gabriel F. T. Gomes Gerrit-CC: Carlos O'Donell Gerrit-Comment-Date: Tue, 12 Nov 2019 17:24:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment