From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D83941F4B5 for ; Tue, 12 Nov 2019 12:51:25 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; q=dns; s=default; b=aRne2p4qEzrJURJO3c8f1JUe7MPrfTM +2sOEqJYzdOPVem+wd8W8al4/yGcC8ciBTt6uq5lIq75sdnnTmlJLYrqxaUVHrG4 qPLlYTbNl+w0XgAWN9QWmlYIfkeqojnJNh1db9TA64B3CG6I741Avta1tzCywxid 1qKcmS8b23hE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; s=default; bh=bijh67a1x9K6+q0ph8NEkptAiN0=; b=xNlGD HfMVKrLZYPdWd1JHKYtytLcNB0x+XhmGSGWvXSl8bvtsnF2VgVy/0+Z1/5BS1Bvf iDRVBFz5OhJZgoBndpTd+kapDLGVadN2WhmT9EbXRKSQEQP5CifcHSMr/hZ290bf DPjnsrRN/EsdV2jrhYNdkhcVwDC96gfvyWhyFU= Received: (qmail 59573 invoked by alias); 12 Nov 2019 12:51:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 59565 invoked by uid 89); 12 Nov 2019 12:51:23 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.osci.io X-Gerrit-PatchSet: 2 Date: Tue, 12 Nov 2019 07:51:16 -0500 From: "Florian Weimer (Code Review)" To: Florian Weimer , "Gabriel F. T. Gomes" , libc-alpha@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review v2] Clarify purpose of assert in _dl_lookup_symbol_x X-Gerrit-Change-Id: I3384349cef90cfd91862ebc34a4053f0c0a99404 X-Gerrit-Change-Number: 469 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6f486dd93b0d74dfadbfe4a1c15730dd15ba526c In-Reply-To: References: Reply-To: fweimer@redhat.com, gabriel@inconstante.net.br, fweimer@redhat.com, libc-alpha@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191112125116.CA12F20AF6@gnutoolchain-gerrit.osci.io> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/469 ...................................................................... Clarify purpose of assert in _dl_lookup_symbol_x Only one of the currently defined flags is incompatible with versioned symbol lookups, so it makes sense to check for that flag and not its complement. Reviewed-by: Gabriel F. T. Gomes Change-Id: I3384349cef90cfd91862ebc34a4053f0c0a99404 --- M elf/dl-lookup.c 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c index fd44cd4..aaaf437 100644 --- a/elf/dl-lookup.c +++ b/elf/dl-lookup.c @@ -792,11 +792,9 @@ bump_num_relocations (); - /* No other flag than DL_LOOKUP_ADD_DEPENDENCY or DL_LOOKUP_GSCOPE_LOCK - is allowed if we look up a versioned symbol. */ - assert (version == NULL - || (flags & ~(DL_LOOKUP_ADD_DEPENDENCY | DL_LOOKUP_GSCOPE_LOCK)) - == 0); + /* DL_LOOKUP_RETURN_NEWEST does not make sense for versioned + lookups. */ + assert (version == NULL || !(flags & DL_LOOKUP_RETURN_NEWEST)); size_t i = 0; if (__glibc_unlikely (skip_map != NULL)) -- Gerrit-Project: glibc Gerrit-Branch: master Gerrit-Change-Id: I3384349cef90cfd91862ebc34a4053f0c0a99404 Gerrit-Change-Number: 469 Gerrit-PatchSet: 2 Gerrit-Owner: Florian Weimer Gerrit-Reviewer: Gabriel F. T. Gomes Gerrit-MessageType: newpatchset