From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4756D1F4B5 for ; Tue, 12 Nov 2019 11:47:42 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; q=dns; s=default; b=HmPyaeUMeayhnwBwGU0Cy1laJiuj9k0 Qc1OnVHNnlZsqg0kBk98ju3/hHPL5Ax9eY3ZEITL/xo4nkdn9Xhb933S6nhwjrPG UabnFFYEfWXfMb10bimnzHy4+6+tq/Fpjz+danw6GMMQ5pSOC7Ypnm6+69EL7MHB q4hDFacgaJ2U= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; s=default; bh=H41nr39DjfFgd9pOY3oFW7+2d1E=; b=IAySL 8rq5iEhREZpP165YSzReRXWfYh5rtTOThe79Bj5rEUBoBy+kb1RPBUok19E5Mwcm bG/0TjPwjtqhm5ETmc+/FJu4vqWFXWjEOp1pwmNepLY6o9p6YAxmeBadowlDkGMp vklTlLOgUvFyDBe2Z0COuyaA2XWczVKipXFpXs= Received: (qmail 99915 invoked by alias); 12 Nov 2019 11:47:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 99907 invoked by uid 89); 12 Nov 2019 11:47:39 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.osci.io X-Gerrit-PatchSet: 3 Date: Tue, 12 Nov 2019 06:47:31 -0500 From: "Florian Weimer (Code Review)" To: Florian Weimer , libc-alpha@sourceware.org Cc: Szabolcs Nagy Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] slotinfo in struct dtv_slotinfo_list should be flexible array [BZ #25... X-Gerrit-Change-Id: I51be146a7857186a4ede0bb40b332509487bdde8 X-Gerrit-Change-Number: 489 X-Gerrit-ChangeURL: X-Gerrit-Commit: 84589a93580d952e4a39b1a5ccef3a55b7f644ba In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 12 Nov 2019 06:47:31 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191112114732.2175B20AF6@gnutoolchain-gerrit.osci.io> Florian Weimer has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/489 ...................................................................... Patch Set 3: (2 comments) This should be ready for committing. | --- csu/libc-tls.c | +++ csu/libc-tls.c | @@ -199,18 +193,18 @@ #endif | /* Update the executable's link map with enough information to make | the TLS routines happy. */ | main_map->l_tls_align = align; | main_map->l_tls_blocksize = memsz; | main_map->l_tls_initimage = initimage; | main_map->l_tls_initimage_size = filesz; | main_map->l_tls_modid = 1; | | init_slotinfo (); | // static_slotinfo.si.slotinfo[1].gen = 0; already zero PS2, Line 202: Right, fixed. That removes the last .si reference from the file. | - static_slotinfo.si.slotinfo[1].map = main_map; | + static_slotinfo.slotinfo[1].map = main_map; | | memsz = roundup (memsz, align ?: 1); | | #if TLS_DTV_AT_TP | memsz += tcb_offset; | #endif | | --- nptl_db/db_info.c | +++ nptl_db/db_info.c | @@ -49,15 +49,18 @@ #define schedparam_sched_priority schedparam.sched_priority | | #define eventbuf_eventmask eventbuf.eventmask | #define eventbuf_eventmask_event_bits eventbuf.eventmask.event_bits | | #define DESC(name, offset, obj) \ | DB_DEFINE_DESC (name, 8 * sizeof (obj), 1, offset); | #define ARRAY_DESC(name, offset, obj) \ | DB_DEFINE_DESC (name, \ | - 8 * sizeof (obj)[0], sizeof (obj) / sizeof (obj)[0], \ | + 8 * sizeof (obj)[0], sizeof (obj) / sizeof (obj)[0], \ PS2, Line 57: No, it's not, it's a leftover from previous changes. Fixed. | offset); | +/* Flexible arrays do not have a length that can be determined. */ | +#define FLEXIBLE_ARRAY_DESC(name, offset, obj) \ | + DB_DEFINE_DESC (name, 8 * sizeof (obj)[0], 0, offset); | | #if TLS_TCB_AT_TP | # define dtvp header.dtv | #elif TLS_DTV_AT_TP | /* Special case hack. If TLS_TCB_SIZE == 0 (on PowerPC), there is no TCB -- Gerrit-Project: glibc Gerrit-Branch: master Gerrit-Change-Id: I51be146a7857186a4ede0bb40b332509487bdde8 Gerrit-Change-Number: 489 Gerrit-PatchSet: 3 Gerrit-Owner: Florian Weimer Gerrit-Reviewer: Florian Weimer Gerrit-Reviewer: Szabolcs Nagy Gerrit-Comment-Date: Tue, 12 Nov 2019 11:47:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Szabolcs Nagy Gerrit-MessageType: comment