From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A5F8C1F454 for ; Mon, 11 Nov 2019 15:45:47 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; q=dns; s=default; b=Cz5ZO 7zlUE64u+DbDfhlBUzCt3GiAvd0rcvszRQhgVwdRR/BbSCd35Pu13sVMftn4q2hl 5xrHrENoCdqwFnwetPqdzvmcxKJr72kF9IixwWYcJh2H8PmDzmD0vKoW9JWSc2jA 86zP2SlyxnXlhhTCz3SHH4A7o3CHWr1KVA+GO8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; s=default; bh=yZjS2yd+uhh u1V4W4Rd1LMmZRX4=; b=ootr4ntZ4eXK75bl6ShXcQE2qC3g0HT5mTbj5nnT4Zh 9q8MxkW2/nWt0w/GWVRe8UVcuwegiow6SBoh5Ec2TpMFJPFJy9/Kt0aZV2r/MChn bAlnV4QjKr+XLbwaow/XCxg9QY6nYYgANdIdIBB7ad55acM93v9Yl326Z7hw5yZY = Received: (qmail 45771 invoked by alias); 11 Nov 2019 15:45:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 45760 invoked by uid 89); 11 Nov 2019 15:45:44 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-out.m-online.net Date: Mon, 11 Nov 2019 16:45:31 +0100 From: Lukasz Majewski To: Joseph Myers , Paul Eggert Cc: Alistair Francis , Alistair Francis , GNU C Library , Adhemerval Zanella , Florian Weimer , Florian Weimer , Zack Weinberg , Carlos O'Donell Subject: Re: [PATCH 1/2] linux: clock_settime: Remove check for nanoseconds validity Message-ID: <20191111164531.1411bd48@jawa> In-Reply-To: <20191108153344.10949-1-lukma@denx.de> References: <20191108153344.10949-1-lukma@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/CUaWsgzGuFlLd_=rXPE54uD"; protocol="application/pgp-signature" --Sig_/CUaWsgzGuFlLd_=rXPE54uD Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Dear Joseph, Paul, > The check if passed nanoseconds via struct __timespec64's *tp pointer > is also performed in the Linux kernel. Remove it from glibc to avoid > duplication. > --- > sysdeps/unix/sysv/linux/clock_settime.c | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/sysdeps/unix/sysv/linux/clock_settime.c > b/sysdeps/unix/sysv/linux/clock_settime.c index > bda113809b..6706dbb31f 100644 --- > a/sysdeps/unix/sysv/linux/clock_settime.c +++ > b/sysdeps/unix/sysv/linux/clock_settime.c @@ -25,13 +25,6 @@ > int > __clock_settime64 (clockid_t clock_id, const struct __timespec64 *tp) > { > - /* Make sure the time cvalue is OK. */ > - if (! valid_nanoseconds (tp->tv_nsec)) > - { > - __set_errno (EINVAL); > - return -1; > - } > - I'm just wondering if this patch is OK, as with other patches, which=20 convert time to use 64 bit syscalls we do rely on Linux kernel to check the nanoseconds (and return proper error). > #ifdef __ASSUME_TIME64_SYSCALLS > # ifndef __NR_clock_settime64 > # define __NR_clock_settime64 __NR_clock_settime Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/CUaWsgzGuFlLd_=rXPE54uD Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl3JghsACgkQAR8vZIA0 zr1ggQf/YmD6XNtcHuw9Zt45b1kRTkfXcaEYaOrF4u36a7xPgcuxe7U6hvf8Th0F YKSUQu9VfCVrAse4upGIUE9wgkOStfg1SuXCs7fdAwfoDnMXszYpalFght0rYaMA Sc1npXvKaf7Y02LqM7xHEHhvAtbw5kUT/ddZEbFD3M0cA3tODqO06zO5dXXPNoKk qJBs5GSZFDg20xJNGDc+3rGw3Jeu10HzoETj8Q5iKys9xMIxAXr2Za3Sz3/qOoQL ejrwAX/dMM2o0jkk8fO5efYVHvZLF76gQbalrqgXCtfnbgg8gvkG4+ut2McBXOTV zOZLoZZu32zE083ErKTZUIK26b2I/g== =2//w -----END PGP SIGNATURE----- --Sig_/CUaWsgzGuFlLd_=rXPE54uD--