From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 47D671F454 for ; Thu, 7 Nov 2019 20:59:50 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; q=dns; s=default; b=bL7ixYgjatjPYEib92WqWf776Cjq7wc imT8ZeyO0R4d1iOJhpF9ypVAH+VABsi1WftuHXUK+xQb0mCzfBNyUtio8kBSjiJF XgyAdVxEDkQ9kGcMTuF952pSLtNgmtsaWa2Ef4ioMFRpHYj1rjOIF2IhWj+0KXkn 4x4Bzc6L+7zw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; s=default; bh=UI5lyBfL+uM5Tl9EFJWJGFk74fc=; b=rnIDG dk25f3/Q4t/sKL/liA4wPcg3VsqorY5DzvBPdFb983oe9Ru3MrspifsGrJh8Q64t v9ZPtmTjs7xJl2+WkiT0AiHrHovv8tycLNOceVCxNgqqt60knXqsyaOorB0zgt5N jUgavgMV4Wrv1ZD8RsXGuBoKODcbQuZpBZ0+8s= Received: (qmail 65574 invoked by alias); 7 Nov 2019 20:59:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 65565 invoked by uid 89); 7 Nov 2019 20:59:47 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.osci.io X-Gerrit-PatchSet: 1 Date: Thu, 7 Nov 2019 15:59:36 -0500 From: "Florian Weimer (Code Review)" To: Adhemerval Zanella , libc-alpha@sourceware.org Cc: Florian Weimer Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] nptl: Add mutex-internal.h X-Gerrit-Change-Id: I30a22c3e3497805fd6e52994c5925897cffcfe13 X-Gerrit-Change-Number: 518 X-Gerrit-ChangeURL: X-Gerrit-Commit: fca980b7ea48e9218918f579a6ebac457f228600 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 7 Nov 2019 15:59:36 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191107205936.81C3025B28@gnutoolchain-gerrit.osci.io> Florian Weimer has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/518 ...................................................................... Patch Set 1: (1 comment) I think this goes in the right direction, but I really dislike the header file name. https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/518/1/sysdeps/nptl/bits/mutex-internal.h File sysdeps/nptl/bits/mutex-internal.h: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/518/1/sysdeps/nptl/bits/mutex-internal.h PS1: I don't think we should use mutex-internal.h as the name of an *installed* header. So far, we used “internal” headers for headers which cross subsystem boundaries, but which are still, well, internal to glibc. Given that this is now essentially one of these per-type headers, maybe use our naming convention for them? -- Gerrit-Project: glibc Gerrit-Branch: master Gerrit-Change-Id: I30a22c3e3497805fd6e52994c5925897cffcfe13 Gerrit-Change-Number: 518 Gerrit-PatchSet: 1 Gerrit-Owner: Adhemerval Zanella Gerrit-CC: Florian Weimer Gerrit-Comment-Date: Thu, 07 Nov 2019 20:59:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment