From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0243B1F454 for ; Mon, 4 Nov 2019 18:10:56 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=b+qPz7dATD39NMJPBW4y5J9Q4Zf8hkwCAlRgKGQFLH1 AEOKKiCvRcoDdsv8CaxqOUIr2Vwx8/5uUrJeJe8Ydt24HJZ+0lDfkNkyP3tJXyib 3A3/RlzM3zMueWY+khdG1VTcE7I4KNbwP1J1aQi6Czoy/MHiE/ezgxb6ehMEccGY = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; s=default; bh=2J0/fUlEVM8quCCsj9fdrEBOD1U=; b=iE997OzQdJJNm9Dat 9E5GyTpmk56PftVXOz3+we42CmfC5yP5I2LwJVpjhwF49/Omlf1kLPo9ecLwuxJ+ i1M7qfCzw55oef+6KpNaULsDgw1rm2tVprNT9NtaxrozoP0VUs43rr/xOK9IZ/eV vcVHSZ7yrNscNuidzZB6gLLrtc= Received: (qmail 23227 invoked by alias); 4 Nov 2019 18:10:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 23214 invoked by uid 89); 4 Nov 2019 18:10:54 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Mon, 4 Nov 2019 15:10:41 -0300 From: "Gabriel F. T. Gomes" To: Paul E Murphy CC: Subject: Re: [PATCH v2 02/30] ldbl-128ibm-compat: Add wide character printing functions Message-ID: <20191104151041.69c50b4c@tereshkova> In-Reply-To: <6cd56f3e-847f-f1bc-7ae4-f30d58bfdd0a@linux.ibm.com> References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-3-gabriel@inconstante.net.br> <6cd56f3e-847f-f1bc-7ae4-f30d58bfdd0a@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 7613898120981892664 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedruddufedgudduudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Hi, Paul, On Mon, 04 Nov 2019, Paul E Murphy wrote: > >Is it prohibitively difficult to merge the wide character tester with >the one in the previous patch? Otherwise, this looks OK too. It's not difficult... In fact, that's how I started it, but it ended up being too hard to read (imo, anyway), because of the excessive use of macros and because of the not so nice correspondence between function names. I suppose you're suggesting it so that we have less code duplication. I can make the merge... It's just not how I would do it.