* [PATCH] ldd: Print "not a dynamic executable" on standard error [BZ #24150]
@ 2019-10-08 17:01 Florian Weimer
2019-10-15 14:29 ` Richard W.M. Jones
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2019-10-08 17:01 UTC (permalink / raw
To: libc-alpha
Tested with the testsuite on x86_64-linux-gnu, and manually.
2019-10-08 Florian Weimer <fweimer@redhat.com>
[BZ #24150]
* elf/ldd.bash.in: Print "not a dynamic executable" message to
standard error.
diff --git a/elf/ldd.bash.in b/elf/ldd.bash.in
index 843e352a6b..6162004818 100644
--- a/elf/ldd.bash.in
+++ b/elf/ldd.bash.in
@@ -167,7 +167,7 @@ warning: you do not have execution permission for" "\`$file'" >&2
1)
# This can be a non-ELF binary or no binary at all.
nonelf "$file" || {
- echo $" not a dynamic executable"
+ echo $" not a dynamic executable" >&2
result=1
}
;;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ldd: Print "not a dynamic executable" on standard error [BZ #24150]
2019-10-08 17:01 [PATCH] ldd: Print "not a dynamic executable" on standard error [BZ #24150] Florian Weimer
@ 2019-10-15 14:29 ` Richard W.M. Jones
2019-10-15 14:34 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Richard W.M. Jones @ 2019-10-15 14:29 UTC (permalink / raw
To: Florian Weimer; +Cc: libc-alpha
On Tue, Oct 08, 2019 at 07:01:31PM +0200, Florian Weimer wrote:
> Tested with the testsuite on x86_64-linux-gnu, and manually.
>
> 2019-10-08 Florian Weimer <fweimer@redhat.com>
>
> [BZ #24150]
> * elf/ldd.bash.in: Print "not a dynamic executable" message to
> standard error.
>
> diff --git a/elf/ldd.bash.in b/elf/ldd.bash.in
> index 843e352a6b..6162004818 100644
> --- a/elf/ldd.bash.in
> +++ b/elf/ldd.bash.in
> @@ -167,7 +167,7 @@ warning: you do not have execution permission for" "\`$file'" >&2
> 1)
> # This can be a non-ELF binary or no binary at all.
> nonelf "$file" || {
> - echo $" not a dynamic executable"
> + echo $" not a dynamic executable" >&2
> result=1
> }
Yes, finally!
So the patch itself is basically obvious, adding the >&2, therefore:
ACK
Thanks,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ldd: Print "not a dynamic executable" on standard error [BZ #24150]
2019-10-15 14:29 ` Richard W.M. Jones
@ 2019-10-15 14:34 ` Florian Weimer
2019-10-15 14:37 ` Richard W.M. Jones
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2019-10-15 14:34 UTC (permalink / raw
To: Richard W.M. Jones; +Cc: libc-alpha
* Richard W. M. Jones:
> On Tue, Oct 08, 2019 at 07:01:31PM +0200, Florian Weimer wrote:
>> Tested with the testsuite on x86_64-linux-gnu, and manually.
>>
>> 2019-10-08 Florian Weimer <fweimer@redhat.com>
>>
>> [BZ #24150]
>> * elf/ldd.bash.in: Print "not a dynamic executable" message to
>> standard error.
>>
>> diff --git a/elf/ldd.bash.in b/elf/ldd.bash.in
>> index 843e352a6b..6162004818 100644
>> --- a/elf/ldd.bash.in
>> +++ b/elf/ldd.bash.in
>> @@ -167,7 +167,7 @@ warning: you do not have execution permission for" "\`$file'" >&2
>> 1)
>> # This can be a non-ELF binary or no binary at all.
>> nonelf "$file" || {
>> - echo $" not a dynamic executable"
>> + echo $" not a dynamic executable" >&2
>> result=1
>> }
>
> Yes, finally!
>
> So the patch itself is basically obvious, adding the >&2, therefore:
>
> ACK
>
> Thanks,
Thanks. May I turn this into a Reviewed-By?
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ldd: Print "not a dynamic executable" on standard error [BZ #24150]
2019-10-15 14:34 ` Florian Weimer
@ 2019-10-15 14:37 ` Richard W.M. Jones
0 siblings, 0 replies; 4+ messages in thread
From: Richard W.M. Jones @ 2019-10-15 14:37 UTC (permalink / raw
To: Florian Weimer; +Cc: libc-alpha
On Tue, Oct 15, 2019 at 04:34:31PM +0200, Florian Weimer wrote:
> * Richard W. M. Jones:
>
> > On Tue, Oct 08, 2019 at 07:01:31PM +0200, Florian Weimer wrote:
> >> Tested with the testsuite on x86_64-linux-gnu, and manually.
> >>
> >> 2019-10-08 Florian Weimer <fweimer@redhat.com>
> >>
> >> [BZ #24150]
> >> * elf/ldd.bash.in: Print "not a dynamic executable" message to
> >> standard error.
> >>
> >> diff --git a/elf/ldd.bash.in b/elf/ldd.bash.in
> >> index 843e352a6b..6162004818 100644
> >> --- a/elf/ldd.bash.in
> >> +++ b/elf/ldd.bash.in
> >> @@ -167,7 +167,7 @@ warning: you do not have execution permission for" "\`$file'" >&2
> >> 1)
> >> # This can be a non-ELF binary or no binary at all.
> >> nonelf "$file" || {
> >> - echo $" not a dynamic executable"
> >> + echo $" not a dynamic executable" >&2
> >> result=1
> >> }
> >
> > Yes, finally!
> >
> > So the patch itself is basically obvious, adding the >&2, therefore:
> >
> > ACK
> >
> > Thanks,
>
> Thanks. May I turn this into a Reviewed-By?
Ah .. I was searching around the list trying to find an existing
example of the preferred format. Here you go:
Reviewed-By: Richard W.M. Jones <rjones@redhat.com>
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-15 14:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-08 17:01 [PATCH] ldd: Print "not a dynamic executable" on standard error [BZ #24150] Florian Weimer
2019-10-15 14:29 ` Richard W.M. Jones
2019-10-15 14:34 ` Florian Weimer
2019-10-15 14:37 ` Richard W.M. Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).