From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5A9801F463 for ; Sat, 28 Sep 2019 08:53:55 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=xy2l 01/Bf8W2hF0gtlh9oWJWbIXeK7ndIVidi3dQOFs5wH5fMCVeKoIPbexSv0pz3WM2 uFJQX7YcWFuhcZDeSEv94nMYmM6nahAMNAnRyKg+fn57O1XkTwrp+Pr5ZSA3ASU2 O7IZJBKyoaHadAuSwX0OOFrD/TD/4rHY2cjYJK4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=WecTHB4tlc QrZBXoPM3QV1jkrBw=; b=S3Syvq8q2WwNrUzJRAIsWEUm7eePWTUGmVrwpemmni rE4WP8tPOhVz64sAT+hl9VV0/70evSKeHCLQp/334FfmiIGVyK2VRoHbW52kOpvf q3NIBkyYgYcV6Ni0liPUObaIGb+Wt6LqjIFaRqVQ36C68QJrJsNX8aXCO/xPS8M3 g= Received: (qmail 124369 invoked by alias); 28 Sep 2019 08:53:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 124361 invoked by uid 89); 28 Sep 2019 08:53:53 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: avasout06.plus.net X-Clacks-Overhead: "GNU Terry Pratchett" X-CM-Score: 0.00 Date: Sat, 28 Sep 2019 09:53:47 +0100 From: Mike Crowe To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 2/4] manual: Add documentation for pthread_tryjoin_np and pthread_timedjoin_np Message-ID: <20190928085347.GA11327@mcrowe.com> References: <11fa584c-ca33-dc49-7d2b-f590b53cd032@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11fa584c-ca33-dc49-7d2b-f590b53cd032@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) On Thursday 26 September 2019 at 14:26:00 -0700, Adhemerval Zanella wrote: > On 18/09/2019 05:30, Mike Crowe wrote: > > This documentation isn't perfect, but it's better than nothing and can > > hopefully act as a basis for future improvement. In particular, although > > I'm certain that the functions are MT-Safe, I'm not sure about the rest of > > the @safety line. > > > > Yann Droneaud pointed out that pthread_timedjoin_np would wait forever if > > the timeout parameter is passed as NULL. Since it's now too late to change > > that, I've documented it. > > To which semantic do you think it would be better to change? Since this > symbol are not yet in POSIX there still the possibility to change it > by using a new plus a compat symbol. The alternative would be to mark the timeout parameter as __nonnull and not permit it to be NULL, as is the case for the other pthread timed*/clock* functions. I imagine that if the functions were ever standardised then this would be the case - but that doesn't look like it's on the horizon. Although we wouldn't break existing binaries if we change the behaviour and add a compat symbol, we could break people compiling existing source. I don't think it's a serious enough problem for it to be worth even doing that. However, if others feel strongly about it then I'm prepared to make that change. Thanks. Mike.