From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 82E921F463 for ; Thu, 19 Sep 2019 21:21:24 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; q=dns; s=default; b=d7ie/ 7+pz31oQGgEs8MM3bbr9Axzd54dzTRVUwhJ0dhz+MBSX5jMXFK51W3igIbWq0ZHc ZYa5XzjQp/LxMjMVQdW1vaXJ1cTHDNigsnZc7LCl3Vhq1GK05l7lwjg1USws3USn Wf3m+QwYJTlBIqP2MFNT1HiyL0zc1Fz4inoGFk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; s=default; bh=ejKaJtInijl bU5F9OwkMliYpu9k=; b=IBphzEQTZ9twiAvqDcB5V7bH/XMtS6YJ6gSbZAICz6v PraThqzVRh0ZulM54XH+OwswUvtsj3ahn25aEqtgAOR6mQ/Br7Uv5dyzCu6wLGSR lGc6lq7msRHD5joyw+PdiDTuDaqfrPbHmFqTFZLnGGPhq3ju9J8GhPHWtRViYbB8 = Received: (qmail 47377 invoked by alias); 19 Sep 2019 21:21:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 47369 invoked by uid 89); 19 Sep 2019 21:21:21 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-out.m-online.net Date: Thu, 19 Sep 2019 23:21:06 +0200 From: Lukasz Majewski To: Joseph Myers Cc: Alistair Francis , Alistair Francis , Zack Weinberg , Arnd Bergmann , GNU C Library , Adhemerval Zanella , Florian Weimer , Carlos O'Donell , Stepan Golosunov Subject: Re: [PATCH v8 2/3] y2038: Provide conversion helpers for struct __timespec64 Message-ID: <20190919232106.160135df@jawa> In-Reply-To: References: <20190918211603.8444-1-lukma@denx.de> <20190918211603.8444-3-lukma@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/kmbaXrIUI2sF.H8rhXdyvYQ"; protocol="application/pgp-signature" --Sig_/kmbaXrIUI2sF.H8rhXdyvYQ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Joseph, > On Wed, 18 Sep 2019, Lukasz Majewski wrote: >=20 > > +/* Convert a known valid struct __timespec64 into a struct > > timespec. */ =20 >=20 > It's not just "valid", it's valid *and within range of struct > timespec*. (That is, I think the comment needs to be expanded.) >=20 > > +/* Convert a known valid struct __timespec64 into a struct > > timeval. */ =20 >=20 > Likewise. >=20 > > +/* Check and convert a struct timespec into a struct __timespec64. > > */ +static inline bool > > +timespec_to_timespec64 (const struct timespec *ts32, > > + struct __timespec64 *ts64) =20 >=20 > The comment on the function needs to say what the return value means. >=20 > > +/* Check and convert a struct __timespec64 into a struct timespec. > > */ +static inline bool > > +timespec64_to_timespec (const struct __timespec64 *ts64, > > + struct timespec *ts32) =20 >=20 > Likewise. >=20 > > +/* Check and convert a struct __timespec64 into a struct timeval. > > */ +static inline bool > > +timespec64_to_timeval (const struct __timespec64 *ts64, > > + struct timeval *tv32) =20 >=20 > Likewise. >=20 I will wait for your review of patch 3/3 of this series ( the one which converts clock_settime to use __clock_settime64 internally) and send v9 with adjusted comments. Thanks for the review. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/kmbaXrIUI2sF.H8rhXdyvYQ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl2D8UIACgkQAR8vZIA0 zr0DKQf+MvRY8/a5f9MtWKME6Rd7jlTK0BQoOMMXpeWIbr4zSboRxOomaagF4cFK ZM+cR0RWtahu1+Oul2G2V5Q10UdKEebCP0FixrVzDN/Vd8Ded4+kXjKS1UgLETH6 bGSxXxumhZe8TG9cwGXm/hUe7edwITU4DAbpjgT1j3Z1QRQuiJOsetqZgH6B2FFJ 3rnxGTjr/ei09DcwuBqGXcqxHmlmU5/sbvOrTR2hf6Fe4tBhZT/tifc/tv4fic6Y N1MzaGRnkolwnsojrvvz4uwDDXhIh49eQ22e4oss0O0pfSH+ejMjUd9cwtUYnto7 g74TcG9fyhgJQrlQwZ4kzLA/kuisJg== =IXdL -----END PGP SIGNATURE----- --Sig_/kmbaXrIUI2sF.H8rhXdyvYQ--