From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0FC151F463 for ; Thu, 12 Sep 2019 20:13:33 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=q5pZ 5xt4pk7xZWiITBHaaDk+vrF+Ce6mUGbh6N1iOVmMF+WoqPsASOickqQhRgVICEdO d9uNIizrcar5EMe595+ViOVkQna6O/QNNlM9UbwRUyd9lG6GSnyp+5It3HJ8mTHW hsg5U7K42qjRyt+sNSmpknWiEYiXWSyex6lXMDk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=SqyofM0r2Z NxYEeFX4MQzBFxsj4=; b=D8V60XYhSxBokLFWOqqimvD3hpwVMAkPhK+krAcX6P lKVISXa/jFuhoSonjakEV8E2drMViAn+iLL7cdhvzSUwG/IHfvmniG4TY5JyykVk Vld3lO1K6O2QxtET5d3wTraGEmuOqJWwBXYejPrReEt+G/pM5qdNCV7gOSz4p6L1 s= Received: (qmail 62498 invoked by alias); 12 Sep 2019 20:13:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 62490 invoked by uid 89); 12 Sep 2019 20:13:30 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-pg1-f195.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=776R9d2H5TsJORMQZjqFgocaBlyAcF35Dh/xJcs9Smo=; b=T8rMZsc8wnnQlEpkfXy8LosTg+vPewu5ex/xc9DGV9HbGMmU6OyGaqdSUTJ9y43bXY SvWR6cCi1HzH1TK99w4t5+a+mvRHNLWtJHbIlKc+rrLZrA3ccE/OPYd8btQbgZCKeK/c qDvMDQDw3DF+SH+sj8HL2cv8CBoHmL3V9ux7RbM4wnHo9Tr82l27j1b4aWWBbTVxy3AN coE4Ghncq/HsFIfBe65nrg4SFGCJNsTvwL0XKdRDZep2XpXQFXN/fYJ69slabphYH1rM 5ZKmfJuW/FQC2FipiIdCRICsKQdc/GAxvaAAneSrRIubyIiyDSLpTruRYhu2M61KUMAz HvpQ== Date: Thu, 12 Sep 2019 11:43:49 -0700 From: Isaku Yamahata To: DJ Delorie Cc: Isaku Yamahata , libc-alpha@sourceware.org Subject: Re: [RFC PATCH 07/11] malloc: make arena size configurable on startup Message-ID: <20190912184349.GA24370@private.email.ne.jp> References: <0438c6b3f81ee46abef884de161dbb4b624655db.1568219400.git.isaku.yamahata@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Thanks for feedback. On Wed, Sep 11, 2019 at 09:03:59PM -0400, DJ Delorie wrote: > > I have no fundamental problem with tuning the heap size, but... > > 1. The heap size must always be a power of two; you need to enforce that > in the tunable callback. sure. > 2. Do you have any benchmarks that show that these changes don't affect > performance? I don't mean differing size heaps, I mean changing a > constant to a variable in the code. So far not yet. let me try bench-malloc-simple.c bench-malloc-thread.c > 3. I don't see the point of heap_max_specified. ok. Let me fix it with the next spin. -- Isaku Yamahata