unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* hppa build broken
@ 2019-07-16 20:45 Florian Weimer
  2019-07-17  8:44 ` Mike Crowe
  2019-07-17 16:58 ` Adhemerval Zanella
  0 siblings, 2 replies; 3+ messages in thread
From: Florian Weimer @ 2019-07-16 20:45 UTC (permalink / raw)
  To: libc-alpha; +Cc: Adhemerval Zanella, Mike Crowe

In file included from tst-mutex5.c:27:
tst-mutex5.c: In function ‘do_test_clock’:
tst-mutex5.c:76:19: error: implicit declaration of function ‘pthread_mutex_clocklock’; did you mean ‘pthread_mutex_unlock’? [-Werror=implicit-function-declaration]
   76 |     TEST_COMPARE (pthread_mutex_clocklock (&m, clockid, &ts_timeout),
      |                   ^~~~~~~~~~~~~~~~~~~~~~~
../support/check.h:103:28: note: in definition of macro ‘TEST_COMPARE’
  103 |     typedef __typeof__ (+ (left)) __left_type;                          \
      |                            ^~~~

I think this is because the hppa copy of pthread.h wasn't updated for
the recent nptl changes.

I will fix this tomorrow if no one else steps in before that.

Thanks,
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: hppa build broken
  2019-07-16 20:45 hppa build broken Florian Weimer
@ 2019-07-17  8:44 ` Mike Crowe
  2019-07-17 16:58 ` Adhemerval Zanella
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Crowe @ 2019-07-17  8:44 UTC (permalink / raw)
  To: libc-alpha

On Tuesday 16 July 2019 at 22:45:04 +0200, Florian Weimer wrote:
> In file included from tst-mutex5.c:27:
> tst-mutex5.c: In function ‘do_test_clock’:
> tst-mutex5.c:76:19: error: implicit declaration of function ‘pthread_mutex_clocklock’; did you mean ‘pthread_mutex_unlock’? [-Werror=implicit-function-declaration]
>    76 |     TEST_COMPARE (pthread_mutex_clocklock (&m, clockid, &ts_timeout),
>       |                   ^~~~~~~~~~~~~~~~~~~~~~~
> ../support/check.h:103:28: note: in definition of macro ‘TEST_COMPARE’
>   103 |     typedef __typeof__ (+ (left)) __left_type;                          \
>       |                            ^~~~
> 
> I think this is because the hppa copy of pthread.h wasn't updated for
> the recent nptl changes.

Proposed fix at https://sourceware.org/ml/libc-alpha/2019-07/msg00354.html

Mike.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: hppa build broken
  2019-07-16 20:45 hppa build broken Florian Weimer
  2019-07-17  8:44 ` Mike Crowe
@ 2019-07-17 16:58 ` Adhemerval Zanella
  1 sibling, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2019-07-17 16:58 UTC (permalink / raw)
  To: Florian Weimer, libc-alpha; +Cc: Mike Crowe



On 16/07/2019 17:45, Florian Weimer wrote:
> In file included from tst-mutex5.c:27:
> tst-mutex5.c: In function ‘do_test_clock’:
> tst-mutex5.c:76:19: error: implicit declaration of function ‘pthread_mutex_clocklock’; did you mean ‘pthread_mutex_unlock’? [-Werror=implicit-function-declaration]
>    76 |     TEST_COMPARE (pthread_mutex_clocklock (&m, clockid, &ts_timeout),
>       |                   ^~~~~~~~~~~~~~~~~~~~~~~
> ../support/check.h:103:28: note: in definition of macro ‘TEST_COMPARE’
>   103 |     typedef __typeof__ (+ (left)) __left_type;                          \
>       |                            ^~~~
> 
> I think this is because the hppa copy of pthread.h wasn't updated for
> the recent nptl changes.
> 
> I will fix this tomorrow if no one else steps in before that.
> 
> Thanks,
> Florian
> 

Sorry about that, my build testing only checked the glibc build itself
on hppa. Next time I will add a full build including tests as well.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-17 16:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 20:45 hppa build broken Florian Weimer
2019-07-17  8:44 ` Mike Crowe
2019-07-17 16:58 ` Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).