From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id CAFFB1F461 for ; Fri, 5 Jul 2019 01:23:15 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=vPK/ sBeay4zz+4MMVhRWN1GwhJLGDG9yK0zZNy2pb85N3VU0hGNU9VKl0qjInmWwjf5m A93jcd3JGacYbhP4mZ43fYKphM11lq55mti/P9WnWuZ7ljrYuVeQotWqWCfB6wiF S30OWDq7zp5Qle3Oxi5v7Z8dw1pAIUPkHZ5bPPs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=cmuXbaozT1 Rkzy3Hos9CXC/lahQ=; b=uTrJWHmABFkXTnhHtqTL1uXAQGSjTozYOpOF8MrnNS WONWVK6imQ4TqmTxC6GmM/tAHpC5lbsUPLIczrNsqcqUi2jxM54xFIxkNvKirh6d JsKRL4M6EbnJWDtPG3jDPKr4F6EGAbTUuiQ83GnDrV6dSGPmvRtRs2YG9UiDJ3M9 8= Received: (qmail 91357 invoked by alias); 5 Jul 2019 01:23:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 91346 invoked by uid 89); 5 Jul 2019 01:23:12 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Thu, 4 Jul 2019 22:23:01 -0300 From: "Gabriel F. T. Gomes" To: Adhemerval Zanella CC: Subject: Re: [PATCH 25/28] powerpc: Refactor modf{f} Message-ID: <20190705012301.GA7290@tereshkova> References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-26-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190329133529.22523-26-adhemerval.zanella@linaro.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Ovh-Tracer-Id: 11996463510638087881 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrfeefgdegiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd On Fri, Mar 29 2019, Adhemerval Zanella wrote: > The modf{f} optimization is not an optimization for ISA 2.07+. This > patch move the IFUNC for powerpc64 only, move the power5+ to generic > location, and include the generic implementation for ISA 2.07+. Looks good to me. Thanks. Reviewed-by: Gabriel F. T. Gomes