From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E4F6E1F4B6 for ; Tue, 25 Jun 2019 18:44:18 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=VqdF gYUHsbW5hpuRglRDetf+J7+BsD07TjcDMuFP5xNMnmWrcUxihIGWDC8bOZTpG7D6 QGod9Uis9MB7pPFuzGEr1sGiJR6dSMXsRN5IHYIyMwSNGw4l5RZN7mZzFzlocLwX E9aFs/Y5zDtKr/6m42e0bgqC6Lv9vFDKPgIS1w4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=U9kdYqfEBL hasMgMddEBQz/K3Qw=; b=heSvPzyTw7lwFR985vdiReQT/dbTIMGutV5OH0RjTi iSySuotfXozCT0yx87ML0KCCetwtKgqfwzx28Botq93nsxTgdZ0wMA1SDn51HAmH ZcMxbKX8xHXHYXxKtNMqmobuSezuMTp2JhB7bESvLx4GAuRJA2t8K7ZSFKzLGys+ A= Received: (qmail 33378 invoked by alias); 25 Jun 2019 18:44:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 33368 invoked by uid 89); 25 Jun 2019 18:44:15 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: smtpout1.mo803.mail-out.ovh.net Date: Tue, 25 Jun 2019 15:44:05 -0300 From: "Gabriel F. T. Gomes" To: Adhemerval Zanella CC: Subject: Re: [PATCH 21/28] powerpc: Refactor powerpc32 lround/lroundf/llround/llroundf Message-ID: <20190625184405.pr326tpsdgisvmv6@tereshkova> References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-22-adhemerval.zanella@linaro.org> <20190624210726.nllhjjcdtruehpn6@tereshkova> <94c7d9c7-9f30-7a77-de52-6199b7d8cd29@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <94c7d9c7-9f30-7a77-de52-6199b7d8cd29@linaro.org> User-Agent: NeoMutt/20180716 X-Ovh-Tracer-Id: 7744502513407282889 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudeggdduvdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm On Tue, Jun 25 2019, Adhemerval Zanella wrote: > > Without math_opt_barrier I am seeing with gcc 8.2.1 20190214 > (--build=powerpc64-unknown-linux-gnu --host=powerpc64-unknown-linux-gnu > --target=powerpc-glibc-linux-gnu no extra option, built with > build-many-glibcs.py) I see using the flags: > > powerpc-glibc-linux-gnu-gcc -mcpu=power4 ../sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llround-power6.c -c -std=gnu11 -fgnu89-inline -g -O2 -mcpu=power4 -Wall -Wwrite-strings -Wundef -Werror -fmerge-all-constants -frounding-math -fno-stack-protector -mhard-float -Wstrict-prototypes -Wold-style-definition -fno-math-errno -mlong-double-128 -mcpu=power6 -D__NO_MATH_INLINES -D__LIBC_INTERNAL_MATH_INLINES > > --- > __llround_power6: > .LVL0: > .LFB46: > .file 1 "../sysdeps/powerpc/powerpc32/fpu/s_llround.c" > .loc 1 33 1 view -0 > .cfi_startproc > .loc 1 35 3 view .LVU1 > .loc 1 35 10 is_stmt 0 view .LVU2 > b llround > .LVL1: > .loc 1 35 10 view .LVU3 > .cfi_endproc > --- Oh, I see. Thank you for the details! :) The patch looks good to me. Reviewed-by: Gabriel F. T. Gomes