From: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 20/28] powerpc: Refactor powerpc64 lround/lroundf/llround/llroundf
Date: Thu, 13 Jun 2019 16:30:29 -0300 [thread overview]
Message-ID: <20190613193029.sv2hq5shkamijxat@tereshkova> (raw)
In-Reply-To: <20190329133529.22523-21-adhemerval.zanella@linaro.org>
I found just a small problem in this patch (see below).
On Fri, Mar 29 2019, Adhemerval Zanella wrote:
>
> The IFUNC support is also moved only to powerpc64 only, since for
> powerpc64le generic implementation resulting in optimized code.
Thanks, again.
For reference, again, a powerpc64 build produces:
000000000007e6c0 <.__llround_power8>:
7e6c0: fc 20 0b 10 frin f1,f1
7e6c4: fc 00 0e 5e fctidz f0,f1
7e6c8: 7c 03 00 66 mfvsrd r3,vs0
7e6cc: 4e 80 00 20 blr
000000000007e6e0 <.__llround_power6x>:
7e6e0: fc 20 0b 10 frin f1,f1
7e6e4: fc 00 0e 5e fctidz f0,f1
7e6e8: 7c 60 05 be mftgpr r3,f0
7e6ec: 4e 80 00 20 blr
000000000007e700 <.__llround_power5plus>:
7e700: fc 20 0b 10 frin f1,f1
7e704: fc 00 0e 5e fctidz f0,f1
7e708: d8 01 ff f8 stfd f0,-8(r1)
7e70c: 60 00 00 00 nop
7e710: e8 61 ff f8 ld r3,-8(r1)
7e714: 4e 80 00 20 blr
000000000007e730 <.__llround_ppc64>:
7e730: 3d 22 ff fa addis r9,r2,-6
7e734: fc 00 0a 10 fabs f0,f1
7e738: 38 60 00 00 li r3,0
7e73c: c1 89 a1 f4 lfs f12,-24076(r9)
7e740: fc 00 60 00 fcmpu cr0,f0,f12
7e744: 4d 80 00 20 bltlr
7e748: 3d 22 ff fa addis r9,r2,-6
7e74c: c1 49 6a 04 lfs f10,27140(r9)
7e750: fc 00 50 00 fcmpu cr0,f0,f10
7e754: 40 80 00 2c bge 7e780 <.__llround_ppc64+0x50>
7e758: fd 60 50 2a fadd f11,f0,f10
7e75c: fd 6b 50 28 fsub f11,f11,f10
7e760: fc 00 58 00 fcmpu cr0,f0,f11
7e764: 41 82 00 1c beq 7e780 <.__llround_ppc64+0x50>
7e768: 3d 22 ff fa addis r9,r2,-6
7e76c: fc 00 60 2a fadd f0,f0,f12
7e770: c1 69 9c e0 lfs f11,-25376(r9)
7e774: fc 01 58 00 fcmpu cr0,f1,f11
7e778: 41 80 00 28 blt 7e7a0 <.__llround_ppc64+0x70>
7e77c: fc 20 00 90 fmr f1,f0
7e780: fc 20 0e 5e fctidz f1,f1
7e784: d8 21 ff f8 stfd f1,-8(r1)
7e788: 60 00 00 00 nop
7e78c: 60 00 00 00 nop
7e790: 60 00 00 00 nop
7e794: e8 61 ff f8 ld r3,-8(r1)
7e798: 4e 80 00 20 blr
> --- a/sysdeps/powerpc/powerpc64/be/fpu/multiarch/Makefile
> +++ b/sysdeps/powerpc/powerpc64/be/fpu/multiarch/Makefile
>
> [...]
> CFLAGS-s_roundf-power5+.c = -mcpu=power5+
> CFLAGS-s_trunc-power5+.c = -mcpu=power5+
> CFLAGS-s_truncf-power5+.c = -mcpu=power5+
> -CFLAGS-s_llrint-power8.c += -mcpu=power8
> -CFLAGS-s_llrint-power6x.c += -mcpu=power6x
> +CFLAGS-s_llround-power8.c += -mcpu=power8
> +CFLAGS-s_llround-power6x.c += -mcpu=power6x
> +CFLAGS-s_llround-power5+.c += -mcpu=power5+
> endif
The removal of the two lines above is likely unintentional and wrong.
Looks good to me with that fixed. Thanks.
Reviewed-by: Gabriel F. T. Gomes <gabrielftg@linux.ibm.com>
next prev parent reply other threads:[~2019-06-13 19:30 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 13:35 [PATCH 00/28] powerpc floating-point optimization refactor Adhemerval Zanella
2019-03-29 13:35 ` [PATCH 01/28] powerpc: Use generic fabs{f} implementations Adhemerval Zanella
2019-04-01 20:04 ` Joseph Myers
2019-04-03 1:04 ` Adhemerval Zanella
2019-04-15 20:23 ` Gabriel F. T. Gomes
2019-04-15 21:32 ` Tulio Magno Quites Machado Filho
2019-04-17 17:08 ` Adhemerval Zanella
2019-03-29 13:35 ` [PATCH 02/28] powerpc: fma using builtins Adhemerval Zanella
2019-04-01 20:05 ` Joseph Myers
2019-04-03 1:06 ` Adhemerval Zanella
2019-04-15 21:44 ` Gabriel F. T. Gomes
2019-04-17 21:10 ` Joseph Myers
2019-04-17 21:28 ` Adhemerval Zanella
2019-03-29 13:35 ` [PATCH 03/28] powerpc: Remove power4 mpa optimization Adhemerval Zanella
2019-04-24 21:51 ` Gabriel F. T. Gomes
2019-04-25 12:19 ` Adhemerval Zanella
2019-03-29 13:35 ` [PATCH 04/28] powerpc: ceil/ceilf refactor Adhemerval Zanella
2019-04-25 1:56 ` Gabriel F. T. Gomes
2019-04-25 21:58 ` Adhemerval Zanella
2019-05-02 18:41 ` Gabriel F. T. Gomes
2019-05-04 21:46 ` Gabriel F. T. Gomes
2019-05-06 12:22 ` Adhemerval Zanella
2019-05-09 19:56 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 05/28] powerpc: floor/floorf refactor Adhemerval Zanella
2019-05-03 21:44 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 06/28] powerpc: round/roundf refactor Adhemerval Zanella
2019-05-04 1:10 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 07/28] powerpc: trunc/truncf refactor Adhemerval Zanella
2019-05-09 20:06 ` Gabriel F. T. Gomes
2019-05-09 20:54 ` Adhemerval Zanella
2019-05-09 21:36 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 08/28] powerpc: generic nearbyint/nearbyintf Adhemerval Zanella
2019-05-27 20:42 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 09/28] powerpc: consolidate rint Adhemerval Zanella
2019-05-30 14:36 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 10/28] powerpc: copysign cleanup Adhemerval Zanella
2019-05-31 14:14 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 11/28] benchtests: Add isnan/isinf/isfinite benchmark Adhemerval Zanella
2019-06-05 22:45 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 12/28] math: Use wordsize-64 version for isnan Adhemerval Zanella
2019-06-05 22:45 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 13/28] powerpc: Remove optimized isnan Adhemerval Zanella
2019-06-05 22:46 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 14/28] math: Use wordsize-64 version for isinf Adhemerval Zanella
2019-06-11 13:13 ` Gabriel F. T. Gomes
2019-06-13 8:57 ` Szabolcs Nagy
2019-06-13 9:11 ` Szabolcs Nagy
2019-03-29 13:35 ` [PATCH 15/28] powerpc: Remove optimized isinf Adhemerval Zanella
2019-06-11 13:45 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 16/28] math: Use wordsize-64 version for finite Adhemerval Zanella
2019-06-11 16:20 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 17/28] powerpc: Remove optimized finite Adhemerval Zanella
2019-06-11 18:08 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 18/28] powerpc: refactor powerpc64 lrint/lrintf/llrint/llrintf Adhemerval Zanella
2019-06-13 19:30 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 19/28] powerpc: Refactor powerpc32 lrint/lrintf/llrint/llrintf Adhemerval Zanella
2019-06-14 18:34 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 20/28] powerpc: Refactor powerpc64 lround/lroundf/llround/llroundf Adhemerval Zanella
2019-06-13 19:30 ` Gabriel F. T. Gomes [this message]
2019-03-29 13:35 ` [PATCH 21/28] powerpc: Refactor powerpc32 lround/lroundf/llround/llroundf Adhemerval Zanella
2019-06-24 21:07 ` Gabriel F. T. Gomes
2019-06-25 18:34 ` Adhemerval Zanella
2019-06-25 18:44 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 22/28] powerpc: Use generic e_expf Adhemerval Zanella
2019-06-26 12:59 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 23/28] benchtests: hypot benchmark Adhemerval Zanella
2019-06-26 19:58 ` Gabriel F. T. Gomes
2019-03-29 13:35 ` [PATCH 24/28] powerpc: hypot refactor and optimization Adhemerval Zanella
2019-04-01 20:14 ` Joseph Myers
2019-04-03 1:08 ` Adhemerval Zanella
2019-06-26 19:59 ` Gabriel F. T. Gomes
2019-07-08 15:37 ` Adhemerval Zanella
2019-07-08 18:30 ` Adhemerval Zanella
2019-03-29 13:35 ` [PATCH 25/28] powerpc: Refactor modf{f} Adhemerval Zanella
2019-07-05 1:23 ` Gabriel F. T. Gomes
2019-07-08 18:30 ` Adhemerval Zanella
2019-03-29 13:35 ` [PATCH 26/28] benchtests: Add logb{f} benchmark Adhemerval Zanella
2019-07-05 1:23 ` Gabriel F. T. Gomes
2019-07-08 18:31 ` Adhemerval Zanella
2019-03-29 13:35 ` [PATCH 27/28] math: Use wordsize-64 version for s_logb Adhemerval Zanella
2019-07-05 1:23 ` Gabriel F. T. Gomes
2019-07-08 18:31 ` Adhemerval Zanella
2019-03-29 13:35 ` [PATCH 28/28] powerpc: refactor logb{f,l} Adhemerval Zanella
2019-07-05 1:24 ` Gabriel F. T. Gomes
2019-07-08 18:31 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613193029.sv2hq5shkamijxat@tereshkova \
--to=gabriel@inconstante.eti.br \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).