From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7ED271F462 for ; Wed, 5 Jun 2019 22:46:29 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=JySKge7ToFcqXC2sZLAWNoFiakA4mHiYdLCPu1gz5PQ xZT6TSzPbeB2ma8k3+zY/gYIInpWy6yehAp246T3LvMZHvVgXwurjjzs5HxXcGjf oU2i5ttZv99gTYn4Vy2LX6cmprB1R+CWw6Bz8bM4ltO/PZmGeLa0Brhuu1jtZoiY = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; s=default; bh=Hat4vv1vQZ4MMOBf6UFEbs2NEQ4=; b=WRPJCSXd0GBXZvRs8 BVjAMm4o8mmvt72ieYCl7g9T9exOuxwzxGZGsLrco6NlPBXwvfXNEcG+zKPZLYtQ nPJGoJ6h4LJBgTdueS8H17ACXw48SXeyAS5UeXOW4rrWw8/biTh0ek21bBQRQRPX b3ZHa5cQ/37hskw7EuPVyFdKYQ= Received: (qmail 88157 invoked by alias); 5 Jun 2019 22:46:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 88148 invoked by uid 89); 5 Jun 2019 22:46:27 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx0a-001b2d01.pphosted.com Date: Wed, 5 Jun 2019 19:46:14 -0300 From: "Gabriel F. T. Gomes" To: Adhemerval Zanella Cc: Subject: Re: [PATCH 13/28] powerpc: Remove optimized isnan Message-ID: <20190605194614.2f3aa98b@tereshkova.br.ibm.com> In-Reply-To: <20190329133529.22523-14-adhemerval.zanella@linaro.org> References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-14-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, Mar 29 2019, Adhemerval Zanella wrote: > > - The power7 uses ftdiv to optimize for some input patterns, but at > cost of others. Comparing against generic C implementation built > for powerpc-linux-gnu-power4 (which uses the hp-timing support on > benchtests): > > [...] > > So it basically optimizes marginally for normal numbers while > increasing the latency for other kind of FP. Fair enough. > * sysdeps/powerpc/x/powerpc32/power4/fpu/multiarch/Makefile ^ Typo in this ChangeLog path. > (sysdeps_routines): Remove s_isnan-* objects. ^~~~~~~~~~~~~~~~ Missing mention to similar changes in libm-sysdep_routines. Also, maybe mention the removal of 's_isnanf-*' files, too. To make clear that the removal of the float variants is intended. I'm OK with the removal of the float variants, by the way. And my concerns about sysdeps/ieee754/dbl-64/wordsize-64/ files do not apply here, because there is no sysdeps/ieee754/flt-32/wordsize-64/. This patch looks good to me, provided we have the previous patch (), or some alternative implementation merged, as well. Reviewed-by: Gabriel F. T. Gomes