From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9DF131F462 for ; Mon, 27 May 2019 20:42:47 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=nkH6 3Y1tyBGsW/a2A8usx/l8Df3T+ivrI2R+29XLor3BIb2NPctX8k7+4jOHooCZaMzF 56pGBkf2Z7SM27rBswbSrB3vkcTlxI/C1RkWubVxowTl/l3twiClwz6PQf8wDsiw Sq+ArLG9kata6gGs6BjuK5gqZ+wymfNgW4NJP+4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=vqge/sAW8o BXp/422ZctEfEYETA=; b=W13I0KLhkQ1vTdXzYoB8E9caHqr49kqbRFVK/Z8SV7 huHRI9PZiubOKrcYKe2Ed1HrxowJmu9xr2cZbxVfYnd1xg4b+hODFkBJS+4rcfNj jNajfmn68HmMTrc125dFZT5HyoW/hOoeXJqhVObagj3lZrz4XsVhpEFVg0UPp3Rh w= Received: (qmail 126221 invoked by alias); 27 May 2019 20:42:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126213 invoked by uid 89); 27 May 2019 20:42:45 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Mon, 27 May 2019 17:42:34 -0300 From: "Gabriel F. T. Gomes" To: Adhemerval Zanella CC: Subject: Re: [PATCH 08/28] powerpc: generic nearbyint/nearbyintf Message-ID: <20190527204234.owhjri4zcerqzvl5@tereshkova> References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-9-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190329133529.22523-9-adhemerval.zanella@linaro.org> User-Agent: NeoMutt/20180716 X-Ovh-Tracer-Id: 5458081276948958921 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddvfedgudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm On Fri, Mar 29 2019, Adhemerval Zanella wrote: > > * sysdeps/powerpc/fpu/round_to_integer.h (set_fenv_mode): Add > NEARBYINT handling. > * sysdeps/powerpc/fpu/s_nearbyint.c: New file. > * sysdeps/powerpc/fpu/s_nearbyintf.c: Likewise. > * sysdeps/powerpc/powerpc32/fpu/s_nearbyint.S: Remove file. > * sysdeps/powerpc/powerpc32/fpu/s_nearbyintf.S: Likewise. > * sysdeps/powerpc/powerpc64/fpu/s_nearbyint.S: Likewise. > * sysdeps/powerpc/powerpc64/fpu/s_nearbyintf.S: Likewise. OK. > + case NEARBYINT: > + /* Disable FE_INEXACT exception */ > + reset_fpscr_bit (FPSCR_XE); > + break; OK. Do not change round direction and disable the inexact exception. > - mffs fp11 > - mtfsb0 4*cr7+lt /* Disable FE_INEXACT exception */ OK. Behaviour copied to the C implementation. Looks good to me, thanks.