From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-1.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MIME_CHARSET_FARAWAY,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 082E71F461 for ; Fri, 17 May 2019 21:00:38 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-transfer-encoding :in-reply-to; q=dns; s=default; b=ftOTaVC4sjSMVZT8Qj98aBplk7vRIE tp9hmOjA9Id/2pD1bJRwPo2aYVwloCr+TViRMGOoGu5iojPxanyx4tPTg6GSrATY 9PDy0w9gJU0B7qxJfpBVBkiDI6YnDAvS4Ww8BSlFkpiQ1SHy93pzovGGLCxJqZpQ otmhW+95Vu+uc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-transfer-encoding :in-reply-to; s=default; bh=0i6KXd0iBzOhEgZxuUic9VtrLZk=; b=cdjP 57lZcBPg2ShAbAIxuh6jmPrd68aV8GwYCwdReF3OKBU1ktWrjeZK0bBZQ7hab5DE 5+XPIBa63pqJcf6J4Pf5Y+hLGZt46NYTUFwbo9l+iCOLGEQLMYqkvrtg/Cm3hbl2 NgOxHIlODIamFOhzObZ0FPSW5VnDvRAidG7laWE= Received: (qmail 104501 invoked by alias); 17 May 2019 21:00:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 104323 invoked by uid 89); 17 May 2019 21:00:19 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay03.nicmail.ru Date: Sat, 18 May 2019 01:00:01 +0400 From: Stepan Golosunov To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 5/5] Update sysvipc kernel-features.h files for Linux 5.1 Message-ID: <20190517210001.kneciomkyvogghj7@sghpc.golosunov.pp.ru> References: <20190516151249.19029-1-adhemerval.zanella@linaro.org> <20190516151249.19029-5-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190516151249.19029-5-adhemerval.zanella@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) 16.05.2019 Χ 12:12:49 -0300 Adhemerval Zanella ΞΑΠΙΣΑΜ: > diff --git a/sysdeps/unix/sysv/linux/semop.c b/sysdeps/unix/sysv/linux/semop.c > index 119ee06878..61649e3f41 100644 > --- a/sysdeps/unix/sysv/linux/semop.c > +++ b/sysdeps/unix/sysv/linux/semop.c > @@ -26,7 +26,9 @@ > int > semop (int semid, struct sembuf *sops, size_t nsops) > { > -#ifdef __ASSUME_DIRECT_SYSVIPC_SYSCALLS > + /* semop wire-up syscall is not exported for 32-bit ABIs (they have There is no semop on 64-bit ABIs too. > + semtimedop_time64 instead with uses a 64-bit time_t). */ > +#ifdef __NR_semop > return INLINE_SYSCALL_CALL (semop, semid, sops, nsops); > #else > return INLINE_SYSCALL_CALL (ipc, IPCOP_semop, semid, nsops, 0, sops); > diff --git a/sysdeps/unix/sysv/linux/semtimedop.c b/sysdeps/unix/sysv/linux/semtimedop.c > index 1d746c4117..6bbca1e16f 100644 > --- a/sysdeps/unix/sysv/linux/semtimedop.c > +++ b/sysdeps/unix/sysv/linux/semtimedop.c > @@ -27,7 +27,9 @@ int > semtimedop (int semid, struct sembuf *sops, size_t nsops, > const struct timespec *timeout) > { > -#ifdef __ASSUME_DIRECT_SYSVIPC_SYSCALLS > + /* semop wire-up syscall is not exported for 32-bit ABIs (they have semtimedop, not semop. And on the three 64-bit ABIs the newly added syscall is still called semtimedop. __ASSUME_DIRECT_SYSVIPC_SYSCALLS condition is still needed for them here (otherwise the new syscall will be used even when __LINUX_KERNEL_VERSION < 0x050100). > + semtimedop_time64 instead with uses a 64-bit time_t). */ > +#ifdef __NR_semtimedop > return INLINE_SYSCALL_CALL (semtimedop, semid, sops, nsops, timeout); > #else > return INLINE_SYSCALL_CALL (ipc, IPCOP_semtimedop, semid,