From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-1.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MIME_CHARSET_FARAWAY,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9E7C71F45F for ; Fri, 10 May 2019 16:15:39 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-transfer-encoding :in-reply-to; q=dns; s=default; b=Fo2mR0IG8Ne4FcQUrnHJzFjbnvB38p 2cOlWu0hUzKV7iXfdvbAxmnp7O7yWNRLgRut0G448feJNI4VaI/5L73WeGIDP/RW zOPRzaN7GZuGzHqb4GoVrhwiZ9mSWtxJ/yJr59zEoRnZG34JZesF1RgxQezlvFOp UNfMcupbvKTYY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-transfer-encoding :in-reply-to; s=default; bh=3FipcMyHQAgx5+JNPjcWhyGg6lw=; b=NcUJ KRiWqYpcnFRTSX7bfIB1Cu+LjabdO/yCJnv12hegZehsLf/pHlqrFiUzmIgQY33h 8nM0ys2LQnjL+O5jlGcSHnw6Ekia6AP97jreW/yyft2aZIreMUg4hkBzdQ9dVDB3 CixSWA5e4/VyU1fEaXkMD3qjHXwfV0GFT+mczPs= Received: (qmail 5886 invoked by alias); 10 May 2019 16:15:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 5803 invoked by uid 89); 10 May 2019 16:15:32 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay13.nicmail.ru Date: Fri, 10 May 2019 20:15:25 +0400 From: Stepan Golosunov To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: Update kernel-features.h files for Linux 5.1 Message-ID: <20190510161524.vlsox333fwqgwg35@sghpc.golosunov.pp.ru> References: <20190510102713.udgjb6ilygibgd5x@sghpc.golosunov.pp.ru> <77b2e1fd-7f91-5de3-6e33-e72f00f93544@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) 10.05.2019 Χ 12:11:22 -0300 Adhemerval Zanella ΞΑΠΙΣΑΜ: > On 10/05/2019 12:07, Adhemerval Zanella wrote: > > On 10/05/2019 07:27, Stepan Golosunov wrote: > >> 09.05.2019 Χ 23:00:37 +0000 Joseph Myers ΞΑΠΙΣΑΜ: > >>> Linux 5.1 adds missing syscalls to the syscall table for many Linux > >>> kernel architectures. This patch updates the kernel-features.h > >>> headers accordingly. I believe the statfs64 structure used by alpha > >>> matches what the new kernel syscalls use, but that should be reviewed > >>> carefully. > >>> > >>> Tested with build-many-glibcs.py. > >> > >> The newly added direct ipc syscalls are different from the old ones: > >> > >> 1. They do not accept IPC_64. This means that __IPC_64 should be set > >> to zero when new syscalls are used. And new syscalls can not be used > >> for compat functions like __old_semctl. > > > > So it seems we will need to conditionally set __IPC_64 based on kernel > > version. It also seems that our default value on generic ipc_priv.h > > is not really expressing the kernel ABI. > > > >> > >> (Hmm. Is __old_msgctl already buggy due to its use of __IPC_64 when > >> __ASSUME_DIRECT_SYSVIPC_SYSCALLS is defined? Is there any > >> architecture with both __ASSUME_DIRECT_SYSVIPC_SYSCALLS and > >> __old_msgctl currently?) > > > > The architectures that exports msgctl@GLIBC_2.0 as compat symbol are > > alpha, i686, m68k, mips-o32, powerpc32, s390-32, and sparc32. And > > from these one alpha currently is the only architecture that defines > > __ASSUME_DIRECT_SYSVIPC_SYSCALLS. So it is buggy for alpha currently > > and it would be for the aforementioned architectures once they > > start to use wire-up syscall. > > > > > >> > >> 2. semtimedop does not exist on 32-bit ABIs. They have > >> semtimedop_time64 instead. > >> (I also think that ipc with IPCOP_semtimedop was accidentally made to > >> behave like semtimedop_time64 in 32-bit builds of linux 5.1. But that > >> would be a kernel bug.) > > > > So it seems we would need to either add an __ASSUME specific for semtimedop > > to just enable wire-up calls if time64 is defined or add another pre-processor > > check to see if __NR_semtimeop is defined as well. > > > > > > To summarize, I think we need too: > > > > 1. Fix Linux msgctl compat function to remove __IPC64. > > > > 2. Move __IPC64 to kernel-feature.h and define it based on kernel version > > along with __ASSUME_DIRECT_SYSVIPC_SYSCALLS. > > > > 3. Only use wire-up semtimeop iff __NR_semtimedop is also defined. > > > > It seems semop would also need be handled this way. 5. Ensure __old_msgctl, __old_semctl and __old_shmctl do not use direct syscalls when __IPC64 is zero.