From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B05581F45F for ; Wed, 8 May 2019 16:17:34 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=BF81 uh3xbNZwe1Y2K1qzDreOtvs4/YXBNa3dDPdwwiGc5QGJ12GJDz1DWATfoBkcwobe Zqx+/QbfWxaallim7D8O1RQTawxNugVfLTOUwMhdAVu09hMPT+H/1zSAzRelstG9 Wqb/t2RIawycl7osUE2BlISPv6JW8wkhNqC/NV4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=7z3cUrSANq G2XCOHM03igZIQkmE=; b=v7Ny+zTOtzfEJlDBcQYHFHvyx4pbQq9RCuPpVLC36k x59qjKyh3gwgcVD5VBU/Uq8gKApft+jg/j3OJ2O/cDtt8zleiubEpxDNnSxjCXuX beOOzfb1dXaT8OUEqj3JQWB+qnRG+o3wJxzHFg8+n3cO39qMg0i1/Gpgia5SzZSq 8= Received: (qmail 46709 invoked by alias); 8 May 2019 16:17:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 46698 invoked by uid 89); 8 May 2019 16:17:31 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: avasout02.plus.net X-CM-Score: 0.00 Date: Wed, 8 May 2019 17:17:26 +0100 From: Mike Crowe To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 1/5] support: Add xclock_gettime Message-ID: <20190508161726.vaebepjg6jaq73mr@mcrowe.com> References: <87ef59xdmf.fsf@oldenburg2.str.redhat.com> <20190508142220.6pfy44weefmbdn5r@mcrowe.com> <87k1f1vvmz.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k1f1vvmz.fsf@oldenburg2.str.redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) On Wednesday 08 May 2019 at 17:00:36 +0200, Florian Weimer wrote: > * Mike Crowe: > > > On Wednesday 08 May 2019 at 15:46:48 +0200, Florian Weimer wrote: > >> * Mike Crowe: > >> > * support/xclock_gettime.c (xclock_gettime): New file. Provide > >> > clock_gettime wrapper for use in tests that fails the test rather > >> > than returning failure. > >> > > >> > * support/xtime.h: New file to declare xclock_gettime. > >> > > >> > * support/Makefile: Add xclock_gettime.c. > >> > > >> > * support/README: Mention xtime.h. > >> > >> Patch looks good, but the commit message above looks a bit odd (I mean > >> the indentation). > > > > I just copied and pasted from the ChangeLog entry, so each line starts with > > a tab. This seems to be quite common looking through the existing history > > (e.g. 52faba65f84ee5a8d82ff813bcfa0ee5f4d480cf) but I can reformat it to > > remove the tab if required. I could also add some explanatory text before > > the ChangeLog entry if you think that would be better. > > Something ate the first tab character, on the initial line. I've fixed > it. (I don't think it's Zimbra's fault, it's missing in the web > archives as well.) You're right. The initial tab is in the file that git series format generated, but either git send-email or my MTA ate it. :( I shall remove the tabs in future to avoid that problem. > >> Do you have an account on sourceware? If yes, please push this > >> independently of the rest. > > > > No, I do not. > > Okay, I've pushed it for you. Thanks! Mike.