From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7F5F11F453 for ; Fri, 3 May 2019 21:44:31 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=wDv2 GmTPUFFXsG7T2xR306g0nke9BCI5X04D2kVG8Pkondrf6lZ+IZcigLa73HPxGSI8 /3UhR+rCYOuwIgRcTs/UAWlJEce/zaBFTNXOQkVlXDT1ZYaQYz0SSXkJ4TkKDpV+ XRGHPh/1saJE88R4RXnJOC4h7nN+/+7X99UH58o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=jKPHWXQZ0m PeC54LstOB2wOl/hc=; b=PI2Rm93DoZiGmQH0NMtWl6+BnHg6WdidOJ605eFxCC 4yZh2pNvSTwILTqPxnVJhlZ3gEgcaXIBFAASt93UEpuBXUfR5yZmSd+2clHCVRKY NgTZCd1v3DR9GKKwVWjIYq1lZawaCbtZG4ezPUMOMJnvBmr61ZU29Lbe3YDzLZmX k= Received: (qmail 7778 invoked by alias); 3 May 2019 21:44:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 7770 invoked by uid 89); 3 May 2019 21:44:28 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: smtpout1.mo803.mail-out.ovh.net Date: Fri, 3 May 2019 18:44:17 -0300 From: "Gabriel F. T. Gomes" To: Adhemerval Zanella CC: Subject: Re: [PATCH 05/28] powerpc: floor/floorf refactor Message-ID: <20190503214417.egtld4gzw5pyvvnx@tereshkova> References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-6-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190329133529.22523-6-adhemerval.zanella@linaro.org> User-Agent: NeoMutt/20180716 X-Ovh-Tracer-Id: 13129963240839237321 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrjedvgddtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd On Fri, Mar 29 2019, Adhemerval Zanella wrote: > > * sysdeps/powerpc/fpu/round_to_integer.h (set_rounding_mode): > Add FLOOR option. Since you removed the definition of FLOOR from round_mode (enum) in the previous patch, make sure you updated this ChangeLog entry with something similar to: (round_mode): Add definition for FLOOR. > diff --git a/sysdeps/powerpc/fpu/round_to_integer.h b/sysdeps/powerpc/fpu/round_to_integer.h > index 417aae6242..77d9fc1f86 100644 > --- a/sysdeps/powerpc/fpu/round_to_integer.h > +++ b/sysdeps/powerpc/fpu/round_to_integer.h > @@ -37,6 +37,7 @@ set_fenv_mode (enum round_mode mode) > switch (mode) > { > case CEIL: rmode = FE_UPWARD; break; > + case FLOOR: rmode = FE_DOWNWARD; break; > default: rmode = FE_TONEAREST; break; > } > __fesetround_inline_nocheck (rmode); Likewise, in this file, make sure you added the definition for FLOOR. The patch looks good to me, with these changes. Reviewed-by: Gabriel F. T. Gomes > +double > +__floor (double x) > +{ > +#ifdef _ARCH_PWR5X > + return __builtin_floor (x); > +#else > + return round_to_integer_double (FLOOR, x); > +#endif > +} OK. The arch check looks correct.