From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A251F1F453 for ; Thu, 2 May 2019 18:42:06 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=LmvB XDE7zlDhmie6hUAQ0gHlfg1NW2ehm3q6focXQfzpvGubwCYiMReFvdeTMYyuL4HV 54XOQFzp0gmuvAFgw9ImVsFSxXz1JPO337/oCZWGaEDHL1Kk9vQGWRU6rT2cpgEj dEi/tPebFecjfO7yZ8PUvXoiZ2x4/BN9eFw6nM8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=58/e6rDSK0 eArZEHZRDCUOmgz14=; b=w8UgtPCZ9/WgaHVCNbKIQ3K3dJYZ1dUnJpslX92mdh oz7VqujeNVlkVQWR8RZriwvrzZVZN3t+NdSo9Vr1HpqHBntWoaXmz4nFjRt5GSqu WGu1fh9G7s2gPQdkG76rm20jxoGegTYyuaIwcpmGAH26A1YduNOQWmXn+D6QDEbX 0= Received: (qmail 28818 invoked by alias); 2 May 2019 18:41:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 28742 invoked by uid 89); 2 May 2019 18:41:46 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Thu, 2 May 2019 15:41:36 -0300 From: "Gabriel F. T. Gomes" To: Adhemerval Zanella CC: Subject: Re: [PATCH 04/28] powerpc: ceil/ceilf refactor Message-ID: <20190502184136.2d7xcc44zvcn5imo@tereshkova.br.ibm.com> References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-5-adhemerval.zanella@linaro.org> <20190425015655.c2wckfwowa4xboc4@tereshkova> <83c7cdd1-0042-fa33-36f4-93d732fedba0@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <83c7cdd1-0042-fa33-36f4-93d732fedba0@linaro.org> User-Agent: NeoMutt/20180716 X-Ovh-Tracer-Id: 4171740631446113993 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrieelgddufeduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm On Thu, Apr 25 2019, Adhemerval Zanella wrote: > On 24/04/2019 22:56, Gabriel F. T. Gomes wrote: > > > What would be a runtime check to use DFP syntax? Are you referring to > > the optional third parameter (W) to mtfsfi? I don't see such mechanism > > in __fesetround_inline, so I'm not sure I understand this > > comment/comparison. > > The comment is not clear indeed, to use mtfsfi correctly one should > check hwcap for PPC_FEATURE_HAS_DFP as fesetenv_register do. I changed > comment to: > > /* Same as __fesetround_inline, however without runtime check to use DFP > mtfsfi syntax (as relax_fenv_state) or if round value is valid. */ Aha, now I get it, thanks. With this change, the patch looks good to me. Reviewed-by: Gabriel F. T. Gomes > >> +enum round_mode > >> +{ > >> + CEIL, > >> + FLOOR, > >> + ROUND, > >> + TRUNC, > >> + NEARBYINT, > >> +}; > > > > OK. To be used in following patches. > > In fact I think it would be better to add each round_mode on each > patch it implements. I have changed it locally. OK.