From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AE8F120248 for ; Mon, 15 Apr 2019 21:44:33 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=TWxn NW0Il34SKTKmXoRSmuJllSzB+h2jbAm0xZpD/et6YH/MSj3T2mX+BP1bGd3hSQxP c8STCNNiRT2yhO2Pp+cji8IQriueZFn5SHI6ynI4PhlEtrQ44QoIqBhZ3vlkoFSw L2+U/0wcrA7RKu6oWHEbOd4LZuysXJZZj6u6kXc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=uz4jIUkRR0 Z/wU4ZMN0v+opCad4=; b=oBPInF4FIjlVj+892UMHizhmbl38hBOR8bQ3bCZXNz 6yfZ13mDvSLrnLkNZzOXNCVV0POAQhhp9S2o/222W/UGhJ7FrWAUifXZAimET9nt mwGAuwu7WsoU3U5VTTfuJgnKAjgnzTmT00WAfgJKjH8MM9UFWzeZwQdgVepe4Ggt s= Received: (qmail 71528 invoked by alias); 15 Apr 2019 21:44:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 71517 invoked by uid 89); 15 Apr 2019 21:44:30 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Mon, 15 Apr 2019 18:44:20 -0300 From: "Gabriel F. T. Gomes" To: Adhemerval Zanella CC: Joseph Myers , Subject: Re: [PATCH 02/28] powerpc: fma using builtins Message-ID: <20190415214420.r7pch4dz6njvlmgb@tereshkova> References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-3-adhemerval.zanella@linaro.org> <9b1b57d3-50ff-30c1-6aff-1854a83c643e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9b1b57d3-50ff-30c1-6aff-1854a83c643e@linaro.org> User-Agent: NeoMutt/20180716 X-Ovh-Tracer-Id: 18102781656305553097 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrvdelgdduieegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm On Wed, Apr 03 2019, Adhemerval Zanella wrote: > > On 02/04/2019 03:05, Joseph Myers wrote: > > On Fri, 29 Mar 2019, Adhemerval Zanella wrote: > > > >> +double __fma (double x, double y, double z) > > > > This is not a correctly formatted function definition (return type should > > be on its own line). > > Fixed locally. > > > > >> +float __fmaf (float x, float y, float z) > > > > Likewise. > > > > Ditto. Looks good to me.